[bug+patch] libmutt charset conversion flaw

[Albrecht Dreß <albrecht dress arcor de>]

Hi,

below is a patch to fix a libmutt flaw in Balsa 2.0.17.

If messages with 8-bit chars are received, but they don't have MIME  
headers at all, balsa will either display '?' instead of the 8-bit chars,  
or convert them into a user-selectable charset (e.g. "Western European").

However, if the message has the charset us-ascii either set explicitly  
using the charset MIME parameter, or implicitly through a content-type  
without the charset parameter, libmutt will replace the "broken chars" by  
'?', so the mechanism in balsa will never see the 8-bit stuff. This is of  
course correct if you have the RFC's in mind, but it's actually not what  
the user wants to see, and there are plenty of broken MUA's around...  
Thanks again to Kent Asplund for spotting this problem!

The small patch below (against the 2.0 cvs - last Changelog 2004-05-28  
14:21 PeterB) will suppress the conversion to utf8 if the source charset  
is us-ascii. If the part is 7-bit clean (i.e. correct us-ascii), this  
doesn't make the difference, and if not, the mechanism in libbalsa will  
work, eventually using the selected conversion scheme.

Any comments?

Cheers, Albrecht.

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Albrecht Dreß  -  Johanna-Kirchner-Straße 13  -  D-53123 Bonn (Germany)
      Phone (+49) 228 6199571  -  mailto:albrecht dress arcor de
_________________________________________________________________________

Attachment: balsa-2.0-libmutt-patch.2004-07-02.diff.gz
Description: GNU Zip compressed data

Attachment: pgpxow38xZomo.pgp
Description: PGP signature