Re: Menu items won't open and close after a while



On 01/01/2010 11:41:49 PM, Pawel Salek wrote:
On 01/02/2010 01:56:40 AM, Mike Witt wrote:
[cut]
I think you hit the spot! The pop3 handling code could leak the file descriptors when the network connection was broken while downloading the message. I attach the patch that fixes the problem for me. I have commited it also to git repository.

Pawel

Paweł,

Thank you for doing this. I wonder if the fix will make it into the
Fedora-11 build now that Fedora-12 is already out. I have never tried
to build Balsa myself, but I suppose there's no reason why I couldn't
try.

Mike,

I could push the balsa update for fedora-11 - and for fedora-12 as well! - if the bug fix worked. It is a kind of circular problem :). Hm, as a matter of fact, several bug fixes came in since 2.4.1, they might warrant a balsa update anyway.

One thing I'm a little confused about. I don't see why these files not
getting closed would stop the menu items from opening and closing. Is
it really the same bug?

I am not 100% sure. However, the lsof report indicates that balsa leaks the descriptors. Hell may break loose when a process is out of descriptors, this is a rarely tested corner case. If you want to be sure, please run lsof when the problem with folder opening occurs again. I suspect you will get then a very large number of open descriptors.

Pawel
PS. lsof -p PID is a more reliable way to get the results for a single process only. Using grep in this case will give you false hits whenever you have eg a directory open in bash that includes balsa in its name. I get also false hits whenever pulseaudio is active since it uses libalsa-util.so (OK, this is just one file).

I restarted balsa and then waited until the menus quit working. It took
several hours and I sent and received mail a number of times. When the
menus quit working I had 180 open files (3 of which were deleted pop
connections).

For whatever that's worth.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]