[Notes] [Git][BuildStream/buildstream][bschubert/tests-no-chroot-linux] fixup! Ensure helpful messages are raised when missing dependencies

[Benjamin Schubert <gitlab mg gitlab com>]

Title: GitLab

Benjamin Schubert pushed to branch bschubert/tests-no-chroot-linux at BuildStream / buildstream

Commits:

• 41a94ad2
  by Benjamin Schubert at 2018-11-01T17:49:02Z

  fixup! Ensure helpful messages are raised when missing dependencies
  

2 changed files:

• buildstream/sandbox/_sandboxdummy.py
• tests/integration/missing_dependencies.py

Changes:

buildstream/sandbox/_sandboxdummy.py

---

...	...	@@ -42,4 +42,5 @@ class SandboxDummy(Sandbox):
42	42	"'{}'".format(command[0]),
43	43	reason='missing-command')
44	44
45		- raise SandboxError("This platform does not support local builds: {}".format(self._reason))
	45	+ raise SandboxError("This platform does not support local builds: {}".format(self._reason),
	46	+ reason="unavailable-local-sandbox")

tests/integration/missing_dependencies.py

---

...	...	@@ -89,4 +89,3 @@ def test_old_brwap_has_nice_error_message(cli, datafiles, tmp_path):
89	89	env={'PATH': str(tmp_path.joinpath('bin'))})
90	90	result.assert_task_error(ErrorDomain.SANDBOX, 'unavailable-local-sandbox')
91	91	assert "too old" in result.stderr
92		-

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.