[gnumeric] Goal Seek: Fix crash.



commit 229f1aadd0bd599075a5a1f6de86814b3c146c67
Author: Morten Welinder <terra gnome org>
Date:   Thu Dec 10 11:09:12 2009 -0500

    Goal Seek: Fix crash.

 NEWS                           |    1 +
 src/dialogs/ChangeLog          |    5 +++++
 src/dialogs/dialog-goal-seek.c |   10 ++++++----
 3 files changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/NEWS b/NEWS
index eee5c10..725cc3b 100644
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,7 @@ Morten:
 	* Fix SUMIF problem.  [#603671]
 	* Fix DATEDIF problem across bogus 1900-02-29.  [#599461]
 	* Fix graph editor crash.  [#604223]
+	* Fix goal seek problems.
 
 --------------------------------------------------------------------------
 Gnumeric 1.9.16
diff --git a/src/dialogs/ChangeLog b/src/dialogs/ChangeLog
index a8bf6a1..b454478 100644
--- a/src/dialogs/ChangeLog
+++ b/src/dialogs/ChangeLog
@@ -1,3 +1,8 @@
+2009-12-10  Morten Welinder  <terra gnome org>
+
+	* dialog-goal-seek.c (dialog_init): Force sheets in cell
+	references as code appears to want that.  Fixes crash.
+
 2009-11-29  Morten Welinder <terra gnome org>
 
 	* Release 1.9.16
diff --git a/src/dialogs/dialog-goal-seek.c b/src/dialogs/dialog-goal-seek.c
index d5536f8..c3e3a3d 100644
--- a/src/dialogs/dialog-goal-seek.c
+++ b/src/dialogs/dialog-goal-seek.c
@@ -541,8 +541,9 @@ dialog_init (GoalSeekState *state)
 	table = GTK_TABLE (glade_xml_get_widget (state->gui, "goal-table"));
 	state->set_cell_entry = gnm_expr_entry_new (state->wbcg, TRUE);
 	gnm_expr_entry_set_flags (state->set_cell_entry,
-		GNM_EE_SINGLE_RANGE | GNM_EE_SHEET_OPTIONAL | GNM_EE_FORCE_ABS_REF,
-		GNM_EE_MASK);
+				  GNM_EE_SINGLE_RANGE |
+				  GNM_EE_FORCE_ABS_REF,
+				  GNM_EE_MASK);
 	gtk_table_attach (table, GTK_WIDGET (state->set_cell_entry),
 			  2, 3, 1, 2,
 			  GTK_EXPAND | GTK_FILL, 0,
@@ -554,8 +555,9 @@ dialog_init (GoalSeekState *state)
 
 	state->change_cell_entry = gnm_expr_entry_new (state->wbcg, TRUE);
 	gnm_expr_entry_set_flags (state->change_cell_entry,
-		GNM_EE_SINGLE_RANGE | GNM_EE_SHEET_OPTIONAL | GNM_EE_FORCE_ABS_REF,
-		GNM_EE_MASK);
+				  GNM_EE_SINGLE_RANGE |
+				  GNM_EE_FORCE_ABS_REF,
+				  GNM_EE_MASK);
 	gtk_table_attach (table, GTK_WIDGET (state->change_cell_entry),
 			  2, 3, 3, 4,
 			  GTK_EXPAND | GTK_FILL, 0,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]