[extensions-web] extensions: If we try to download an incompatible extension, 404
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [extensions-web] extensions: If we try to download an incompatible extension, 404
- Date: Wed, 2 May 2012 21:22:35 +0000 (UTC)
commit 2442605851d8e548345d6b89302d7a79a94aff0f
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Wed May 2 17:22:20 2012 -0400
extensions: If we try to download an incompatible extension, 404
... instead of 500-ing
sweettooth/extensions/views.py | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/sweettooth/extensions/views.py b/sweettooth/extensions/views.py
index 4c8ce2a..64b7e2c 100644
--- a/sweettooth/extensions/views.py
+++ b/sweettooth/extensions/views.py
@@ -74,6 +74,9 @@ def shell_download(request, uuid):
extension = get_object_or_404(models.Extension.objects.visible(), uuid=uuid)
version = find_extension_version_from_params(extension, request.GET)
+ if version is None:
+ raise Http404()
+
extension.downloads += 1
extension.save(replace_metadata_json=False)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]