[evolution] Critical warning on ETree dispose, g_object_unref() called on freed object



commit 60c4664090448adf258843915d5e55fe9e3343f1
Author: Milan Crha <mcrha redhat com>
Date:   Thu Sep 13 14:26:49 2012 +0200

    Critical warning on ETree dispose, g_object_unref() called on freed object

 widgets/table/e-tree.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/widgets/table/e-tree.c b/widgets/table/e-tree.c
index d0922cf..a25ef8c 100644
--- a/widgets/table/e-tree.c
+++ b/widgets/table/e-tree.c
@@ -484,10 +484,8 @@ et_dispose (GObject *object)
 		priv->table_canvas = NULL;
 	}
 
-	if (priv->item != NULL) {
-		g_object_unref (G_OBJECT (priv->item));
-		priv->item = NULL;
-	}
+	/* do not unref it, it was owned by priv->table_canvas */
+	priv->item = NULL;
 
 	/* Chain up to parent's dispose() method. */
 	G_OBJECT_CLASS (e_tree_parent_class)->dispose (object);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]