[gnome-maps] mapView: Disconnect signal early



commit 5ad04a343c7efb31fe73e5eb4595de152cac8908
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Sun Apr 7 03:07:04 2013 +0300

    mapView: Disconnect signal early
    
    We shouldn't wait for the Idle handler to disconnect the signal as
    otherwise the signal handler could be called again for another
    'animation-completed::go-to' emission from another context and we don't
    want that.

 src/mapView.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/mapView.js b/src/mapView.js
index a8f23cf..fe5ecef 100644
--- a/src/mapView.js
+++ b/src/mapView.js
@@ -96,8 +96,8 @@ const MapView = new Lang.Class({
                 Mainloop.idle_add(Lang.bind(this,
                     function() {
                         this._view.set_zoom_level(zoom);
-                        this._view.disconnect(anim_completed_id);
                     }));
+                this._view.disconnect(anim_completed_id);
             }));
         this._view.go_to(location.latitude, location.longitude);
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]