[gtksourceview] Fix build with -Wl,--as-needed in the LDFLAGS



commit 8bde9d1e0b3efc703b986d7e970599964cae9b0d
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Tue May 28 15:01:12 2013 +0200

    Fix build with -Wl,--as-needed in the LDFLAGS
    
    The *.la files listed in the LDADD variable were in the wrong order.
    
    If libgtksourceview-3.0.la is before libgtksourcecompletionwords.la,
    the linker doesn't add the DT_NEEDED tag for libgtksourceview-3.0.la
    because at that point in the linkage, libgtksourceview-3.0.la is
    useless.
    
    On the other hand, if libgtksourcecompletionwords.la is listed before
    libgtksourceview-3.0.la, the DT_NEEDED tag is added to the latter
    because the former needs a symbol from the latter.
    
    Thanks to Dominique Leuenberger for the bug report.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=701113

 tests/Makefile.am |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 76cee34..b51c07f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -92,10 +92,10 @@ test_completion_model_LDADD =                                       \
 UNIT_TEST_PROGS += test-completion-words
 test_completion_words_SOURCES = test-completion-words.c
 test_completion_words_LDADD =                                  \
-       $(DEP_LIBS)                                             \
-       $(TESTS_LIBS)                                           \
+       $(top_builddir)/gtksourceview/completion-providers/words/libgtksourcecompletionwords.la \
        $(top_builddir)/gtksourceview/libgtksourceview-3.0.la   \
-       $(top_builddir)/gtksourceview/completion-providers/words/libgtksourcecompletionwords.la
+       $(DEP_LIBS)                                             \
+       $(TESTS_LIBS)
 
 UNIT_TEST_PROGS += test-region
 test_region_SOURCES = test-region.c


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]