[gdm] session: Make sure to clear the worker proxy as well



commit 2d414a916d0e45271df8a2d2e0e3886733b6f1bd
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Tue Aug 19 17:57:41 2014 -0400

    session: Make sure to clear the worker proxy as well
    
    If we leak this, then we open ourselves up for trouble when we have
    active outgoing requests on a freed conversation, leading to crashes and
    other fun things.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727589

 daemon/gdm-session.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/daemon/gdm-session.c b/daemon/gdm-session.c
index bb54084..b2d83c9 100644
--- a/daemon/gdm-session.c
+++ b/daemon/gdm-session.c
@@ -1668,6 +1668,7 @@ free_conversation (GdmSessionConversation *conversation)
         g_free (conversation->service_name);
         g_free (conversation->starting_username);
         g_free (conversation->session_id);
+        g_clear_object (&conversation->worker_proxy);
         g_clear_object (&conversation->session);
         g_free (conversation);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]