[evolution-data-server] libebook: Don’t warn on c alling unimplemented methods



commit d1f237c2e455dda7c91ca79a6f643ef1a613bb61
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Fri Jun 20 19:09:45 2014 +0100

    libebook: Don’t warn on calling unimplemented methods
    
    If a warning is needed, it should be in the method itself. Otherwise we
    can be outputting spurious warnings for methods which don’t need
    implementing.
    
    This fixes the libfolks EDS tests.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731981

 addressbook/libebook/e-book-client-view.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/addressbook/libebook/e-book-client-view.c b/addressbook/libebook/e-book-client-view.c
index 43083f0..7137693 100644
--- a/addressbook/libebook/e-book-client-view.c
+++ b/addressbook/libebook/e-book-client-view.c
@@ -682,7 +682,9 @@ book_client_view_dispose_cb (GObject *source_object,
         * has dropped its final reference and gone on to clean up other things
         * (like the dbus-daemon, if it’s a test harness). */
        if (local_error != NULL &&
-           !g_error_matches (local_error, G_IO_ERROR, G_IO_ERROR_CLOSED)) {
+           !g_error_matches (local_error, G_IO_ERROR, G_IO_ERROR_CLOSED) &&
+           !g_error_matches (local_error, G_DBUS_ERROR,
+                             G_DBUS_ERROR_NOT_SUPPORTED)) {
                g_dbus_error_strip_remote_error (local_error);
                g_warning ("%s: %s", G_STRFUNC, local_error->message);
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]