[gtk/wip/matthiasc/popup5: 186/186] popover: Don't set backdrop state



commit 2a8bac5d5fc06511e91116f71668d6392a658ab3
Author: Matthias Clasen <mclasen redhat com>
Date:   Tue May 28 20:10:07 2019 +0000

    popover: Don't set backdrop state
    
    We don't want to maintain focused state on popovers
    at all, and backdrop does not make sense here.

 gtk/gtkpopover.c | 15 ---------------
 1 file changed, 15 deletions(-)
---
diff --git a/gtk/gtkpopover.c b/gtk/gtkpopover.c
index 267fad09c8..73005e92f7 100644
--- a/gtk/gtkpopover.c
+++ b/gtk/gtkpopover.c
@@ -342,18 +342,6 @@ gtk_popover_key_pressed (GtkWidget       *widget,
   return FALSE;
 }
 
-static void
-ensure_state_flag_backdrop (GtkWidget *widget)
-{
-  GtkPopover *popover = GTK_POPOVER (widget);
-  GtkPopoverPrivate *priv = gtk_popover_get_instance_private (popover);
-
-  if ((priv->state & GDK_SURFACE_STATE_FOCUSED) != 0)
-    gtk_widget_unset_state_flags (widget, GTK_STATE_FLAG_BACKDROP);
-  else
-    gtk_widget_set_state_flags (widget, GTK_STATE_FLAG_BACKDROP, FALSE);
-}
-
 static void
 surface_state_changed (GtkWidget *widget)
 {
@@ -366,9 +354,6 @@ surface_state_changed (GtkWidget *widget)
   changed_mask = new_surface_state ^ priv->state;
   priv->state = new_surface_state;
 
-  if (changed_mask & GDK_SURFACE_STATE_FOCUSED)
-    ensure_state_flag_backdrop (widget);
-
   if (changed_mask & GDK_SURFACE_STATE_WITHDRAWN)
     {
       if (priv->state & GDK_SURFACE_STATE_WITHDRAWN)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]