[gnome-control-center] printers: Use gtk_stack_set_visible_child instead of names



commit 1b999f36e2a94fd47ee276e40ad09175c16f72ae
Author: Robert Ancell <robert ancell canonical com>
Date:   Fri Nov 23 15:37:38 2018 +1300

    printers: Use gtk_stack_set_visible_child instead of names

 panels/printers/pp-details-dialog.c  | 6 ++++--
 panels/printers/pp-details-dialog.ui | 8 +-------
 2 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/panels/printers/pp-details-dialog.c b/panels/printers/pp-details-dialog.c
index d6d1d3aee..8730ee09a 100644
--- a/panels/printers/pp-details-dialog.c
+++ b/panels/printers/pp-details-dialog.c
@@ -42,6 +42,7 @@ struct _PpDetailsDialog {
   GtkDialog parent;
 
   GtkLabel *dialog_title;
+  GtkBox *loading_box;
   GtkEntry *printer_name_entry;
   GtkEntry *printer_location_entry;
   GtkLabel *printer_address_label;
@@ -121,14 +122,14 @@ get_ppd_names_cb (PPDName     **names,
           gtk_label_set_text (self->printer_model_label, _("No suitable driver found"));
         }
 
-      gtk_stack_set_visible_child_name (self->printer_model_stack, "printer_model_label");
+      gtk_stack_set_visible_child (self->printer_model_stack, GTK_WIDGET (self->printer_model_label));
     }
 }
 
 static void
 search_for_drivers (PpDetailsDialog *self)
 {
-  gtk_stack_set_visible_child_name (self->printer_model_stack, "loading");
+  gtk_stack_set_visible_child (self->printer_model_stack, GTK_WIDGET (self->loading_box));
   gtk_widget_set_sensitive (self->search_for_drivers_button, FALSE);
 
   get_ppd_names_async (self->printer_name,
@@ -331,6 +332,7 @@ pp_details_dialog_class_init (PpDetailsDialogClass *klass)
   gtk_widget_class_set_template_from_resource (widget_class, 
"/org/gnome/control-center/printers/pp-details-dialog.ui");
 
   gtk_widget_class_bind_template_child (widget_class, PpDetailsDialog, dialog_title);
+  gtk_widget_class_bind_template_child (widget_class, PpDetailsDialog, loading_box);
   gtk_widget_class_bind_template_child (widget_class, PpDetailsDialog, printer_name_entry);
   gtk_widget_class_bind_template_child (widget_class, PpDetailsDialog, printer_location_entry);
   gtk_widget_class_bind_template_child (widget_class, PpDetailsDialog, printer_address_label);
diff --git a/panels/printers/pp-details-dialog.ui b/panels/printers/pp-details-dialog.ui
index 97f331018..0d93c13d3 100644
--- a/panels/printers/pp-details-dialog.ui
+++ b/panels/printers/pp-details-dialog.ui
@@ -142,12 +142,9 @@
                     <property name="label">HP Inkjet Delux 9000</property>
                     <property name="selectable">True</property>
                   </object>
-                  <packing>
-                    <property name="name">printer_model_label</property>
-                  </packing>
                 </child>
                 <child>
-                  <object class="GtkBox">
+                  <object class="GtkBox" id="loading_box">
                     <property name="visible">True</property>
                     <property name="halign">start</property>
                     <property name="spacing">5</property>
@@ -166,9 +163,6 @@
                       </object>
                     </child>
                   </object>
-                  <packing>
-                    <property name="name">loading</property>
-                  </packing>
                 </child>
               </object>
               <packing>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]