[goffice] Don't emit a critical for invalid series in Logarithmic fit. [#49]



commit 2331dc3e7fda891028318e0bebd75882472db32d
Author: Jean Brefort <jean brefort normalesup org>
Date:   Wed May 27 10:23:08 2020 +0200

    Don't emit a critical for invalid series in Logarithmic fit. [#49]

 ChangeLog                       | 5 +++++
 NEWS                            | 1 +
 plugins/reg_logfit/gog-logfit.c | 3 ++-
 3 files changed, 8 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index 08ca5b83..e8a1b528 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2020-05-27  Jean Brefort  <jean brefort normalesup org>
+
+       * plugins/reg_logfit/gog-logfit.c (gog_log_fit_curve_update): don't emit a
+       critical if the series is not valid. [#49]
+
 2020-05-18  Jean Brefort  <jean brefort normalesup org>
 
        * plugins/plot_xy/gog-xy.c (gog_xy_view_render): keep clipping for data
diff --git a/NEWS b/NEWS
index 9f069b69..01a76d89 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ goffice 0.10.48:
 Jean:
        * Avoid serializing empty graph data. [#46]
        * Clip data labels in XY plots. [#47]
+       * Don't emit a critical for invalid series in Logarithmic fit. [#49]
 
 --------------------------------------------------------------------------
 goffice 0.10.47:
diff --git a/plugins/reg_logfit/gog-logfit.c b/plugins/reg_logfit/gog-logfit.c
index 7230b453..ffe6a2cf 100644
--- a/plugins/reg_logfit/gog-logfit.c
+++ b/plugins/reg_logfit/gog-logfit.c
@@ -42,7 +42,8 @@ gog_log_fit_curve_update (GogObject *obj)
        int i, used = 0, nb;
        double xmin, xmax;
 
-       g_return_if_fail (gog_series_is_valid (series));
+       if (!gog_series_is_valid (series))
+               return;
 
        nb = gog_series_get_xy_data (series, &x_vals, &y_vals);
        if (nb > 0) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]