[orca/gnome-42] Web: Don't return early when generating ancestors for table descendants
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca/gnome-42] Web: Don't return early when generating ancestors for table descendants
- Date: Thu, 30 Jun 2022 11:27:12 +0000 (UTC)
commit c0485afbf54eeb7199960a8ab1e46573362b0d57
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Thu Jun 30 13:20:27 2022 +0200
Web: Don't return early when generating ancestors for table descendants
If a user is tabbing among links inside an ARIA grid, we were not
speaking the headers and positions of column headers. In order to fix
this completely, we need to do two things: 1) Generate ancestors and
2) Adjust what information gets generated for the cell information.
The second might have undesired side effects, so the changes are being
split. This commit only addresses the first.
See issue #253
src/orca/scripts/web/speech_generator.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/scripts/web/speech_generator.py b/src/orca/scripts/web/speech_generator.py
index 4c6b2f961..4c8b0e745 100644
--- a/src/orca/scripts/web/speech_generator.py
+++ b/src/orca/scripts/web/speech_generator.py
@@ -81,10 +81,11 @@ class SpeechGenerator(speech_generator.SpeechGenerator):
if priorDoc != doc and not self._script.utilities.getDocumentForObject(doc):
result = [super()._generateName(doc)]
- if self._script.utilities.isLink(obj) \
- or self._script.utilities.isLandmark(obj) \
- or self._script.utilities.isMath(obj) \
- or obj.getRole() in [pyatspi.ROLE_TOOL_TIP, pyatspi.ROLE_STATUS_BAR]:
+ if not self._script.utilities.getTable(obj) \
+ and (self._script.utilities.isLink(obj) \
+ or self._script.utilities.isLandmark(obj) \
+ or self._script.utilities.isMath(obj) \
+ or obj.getRole() in [pyatspi.ROLE_TOOL_TIP, pyatspi.ROLE_STATUS_BAR]):
return result
args['stopAtRoles'] = [pyatspi.ROLE_DOCUMENT_WEB,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]