[librsvg/attribute-parsers-737: 3/26] Path: update comment about parsing paths with errors




commit 186aba6f132db0bf87abd0676985699a5a86598d
Author: Federico Mena Quintero <federico gnome org>
Date:   Wed Oct 19 19:23:16 2022 -0500

    Path: update comment about parsing paths with errors
    
    In set_attributes() functions, we no longer have the intention of
    propagating errors upstream - so the old comment is obsolete now.

 src/shapes.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/shapes.rs b/src/shapes.rs
index ad8e3259c..0213524dd 100644
--- a/src/shapes.rs
+++ b/src/shapes.rs
@@ -260,8 +260,8 @@ impl SetAttributes for Path {
             if attr.expanded() == expanded_name!("", "d") {
                 let mut builder = PathBuilder::default();
                 if let Err(e) = builder.parse(value) {
-                    // FIXME: we don't propagate errors upstream, but creating a partial
-                    // path is OK per the spec
+                    // Creating a partial path is OK per the spec; we don't throw away the partial
+                    // result in case of an error.
 
                     rsvg_log!(session, "could not parse path: {}", e);
                 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]