[evolution-data-server] I#416 - LDAP: Possible memory leak in build_mods_from_contacts()



commit 5e34a607e1db369371e1767c103cd9061ce39438
Author: Milan Crha <mcrha redhat com>
Date:   Tue Sep 27 10:00:23 2022 +0200

    I#416 - LDAP: Possible memory leak in build_mods_from_contacts()
    
    Closes https://gitlab.gnome.org/GNOME/evolution-data-server/-/issues/416

 src/addressbook/backends/ldap/e-book-backend-ldap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/addressbook/backends/ldap/e-book-backend-ldap.c 
b/src/addressbook/backends/ldap/e-book-backend-ldap.c
index 957063ee4..1d9455047 100644
--- a/src/addressbook/backends/ldap/e-book-backend-ldap.c
+++ b/src/addressbook/backends/ldap/e-book-backend-ldap.c
@@ -1277,9 +1277,9 @@ build_mods_from_contacts (EBookBackendLDAP *bl,
 
        /* add LDAP uid attribute, if given */
        if (ldap_uid) {
-               LDAPMod *mod = g_new (LDAPMod, 1);
                gchar *ldap_uid_value = strchr (ldap_uid, '=');
                if (ldap_uid_value) {
+                       LDAPMod *mod = g_new (LDAPMod, 1);
                        mod->mod_op = LDAP_MOD_ADD;
                        mod->mod_type = g_strdup ("uid");
                        mod->mod_values = g_new (gchar *, 2);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]