Re: [Ekiga-list] ekiga 3.0.1 compile fails

[Eugen Dedu <Eugen Dedu pu-pm univ-fcomte fr>]

Hi,

Please apply the following patch to ekiga stable branch (gnome-2-24) and 
to trunk, which removes some spaces and the comment character.

Eugen

Shawn Adams wrote:
> Eugen,
>
> Brilliant, thanks. I presume this means the "#" is not the correct
> comment character ?
>
> I also saw what i think is the same issue in:
> lib/pixops/composite_line_22_4a4_mmx.
>
> line 192 and 193
>
> I fixed both, and lib/pixops now compiles all successfully.
>
> moving on to the next hurdles.
>
> thanks !
>
>
>
>
>
>
> Eugen Dedu wrote:
> > Shawn Adams wrote:
> > > Eugen,
> > >
> > > thanks for the reply.
> > >
> > > cd pixmaps
> > > make clean
> > > make
> > >
> > > - compiles cleanly
> > >
> > > I then went back, did "make clean" in the root directory of the source:
> > > make clean
> > > ./configure
> > > make
> > >
> > > Appears upgrading libs, and fresh reboot cured the issue. now I have
> > > this:
> > > /bin/sh ../../libtool   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H
> > > -I. -I../.. -I../.. -I../..   -DGDK_PIXBUF_DISABLE_DEPRECATED -pthread
> > > -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include      -g
> > > -O2 -Wall -Wextra -Winit-self -Wswitch-default -Wswitch-enum
> > > -Wstrict-aliasing=2 -Wfloat-equal -Wshadow -MT have_mmx.lo -MD -MP -MF
> > > .deps/have_mmx.Tpo -c -o have_mmx.lo have_mmx.S
> > >  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../..
> > > -DGDK_PIXBUF_DISABLE_DEPRECATED -pthread -I/opt/gnome/include/glib-2.0
> > > -I/opt/gnome/lib/glib-2.0/include -g -O2 -Wall -Wextra -Winit-self
> > > -Wswitch-default -Wswitch-enum -Wstrict-aliasing=2 -Wfloat-equal
> > > -Wshadow -MT have_mmx.lo -MD -MP -MF .deps/have_mmx.Tpo -c have_mmx.S
> > > -fPIC -DPIC -o .libs/have_mmx.o
> > > have_mmx.S:45:3: error: invalid preprocessing directive #Check
> > > have_mmx.S:60:3: error: invalid preprocessing directive #OK
> > > make[4]: *** [have_mmx.lo] Error 1
> > > make[4]: Leaving directory `/opt1/images/ekiga-3.0.1/lib/pixops'
> > >
> > >
> > > can't seem to locate anything clear & relevant on the Internet.
> > >
> > > Best regards,
> > >
> > >
> > > Eugen Dedu wrote:
> > > > Shawn Adams wrote:
> > > > > All,
> > > > >
> > > > > Using opensuse 10.2
> > > > > Linux tau 2.6.18.2-34-default #1 SMP Mon Nov 27 11:46:27 UTC 2006 i686
> > > > > i686 i386 GNU/Linux
> > > > >
> > > > > Ekiga 2.0.12 runs fine.
> > > > > Believe I have updated all pre-reqs, opal and ptlib as delivered with
> > > > > Ekiga 3.0.1
> > > > >
> > > > > don't use Gnome, most of it is not installed on this PC - suspect I
> > > > > might have something missing there...
> > > > >
> > > > > Compiling ekiga 3.0.1, receive following error:
> > > > > ./configure - runs fine.
> > > > > ./make:
> > > > >
> > > > >  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I../../lib/gmconf
> > > > > -I../../lib -I../../lib/engine/protocol/skel -I../.. -I../..
> > > > > -I../../lib/pixops -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
> > > > > -I/usr/include/cairo -I/usr/include/freetype2 -I/usr/include/libpng12
> > > > > -I/opt/gnome/include/atk-1.0 -I/opt/gnome/include/pango-1.0
> > > > > -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include
> > > > > -pthread
> > > > > -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -g -O2
> > > > > -Wall -Wextra -Winit-self -Wswitch-default -Wswitch-enum
> > > > > -Wstrict-aliasing=2 -Wfloat-equal -Wshadow -MT gmstockicons.lo -MD -MP
> > > > > -MF .deps/gmstockicons.Tpo -c gmstockicons.c  -fPIC -DPIC -o
> > > > > .libs/gmstockicons.o
> > > > > gmstockicons.c: In function ‘gnomemeeting_stock_icons_init’:
> > > > > gmstockicons.c:62: error: ‘gm_color_brightness_contrast_stock_data’
> > > > > undeclared (first use in this function)
> > > > > gmstockicons.c:62: error: (Each undeclared identifier is reported only
> > > > > once
> > > > > ...
> > > > > etc...
> > > > > ...
> > > > > gmstockicons.c:112: warning: (near initialization for
> > > > > ‘theme_builtins[15].data’)
> > > > > make[5]: *** [gmstockicons.lo] Error 1
> > > > >
> > > > >
> > > > > Hope this is sufficient for someone to point me in the right direction.
> > Could you replace the '#' at the beginning of lines 45 and 60 in file
> > lib/pixops/have_mmx.S with '//' (without the ') and recompile?

Index: lib/pixops/have_mmx.S
===================================================================
--- lib/pixops/have_mmx.S	(revision 7329)
+++ lib/pixops/have_mmx.S	(working copy)
@@ -28,7 +28,7 @@
 #if !defined __powerpc64__ && !defined __ia64__
 .section .note.GNU-stack;  .previous
 #endif
-	
+
 .globl  pixops_have_mmx
 	.type	  pixops_have_mmx,@function
  pixops_have_mmx:
@@ -39,12 +39,12 @@
 _ pixops_have_mmx:
 
 #endif
-	
+
 	push	%ebx
 
-# Check if bit 21 in flags word is writeable
+/* Check if bit 21 in flags word is writable */
 
-	pushfl	
+	pushfl
 	popl	%eax
 	movl	%eax,%ebx
 	xorl	$0x00200000, %eax
@@ -57,11 +57,11 @@
 
 	je .notfound
 
-# OK, we have CPUID
+/* OK, we have CPUID */
 
 	movl	$1, %eax
 	cpuid
-	
+
 	test	$0x00800000, %edx
 	jz	.notfound
 
@@ -70,7 +70,6 @@
 
 .notfound:
 	movl  	$0, %eax
-.out:	
+.out:
 	popl	%ebx
 	ret
-