[Evolution-hackers] A bug for todo conduit.



Just take a look at evolution/calendar/conduits/todo/todo-conduit.c, found a bug.
http://cvs.gnome.org/viewcvs/evolution/calendar/conduits/todo/todo-conduit.c?rev=1.97&view=markup
The code below:
	if (start_calendar_server (ctxt) != 0) {
		WARN(_("Could not start evolution-data-server"));
		gnome_pilot_conduit_error (conduit, _("Could not start evolution-data-server"));
		return -1;
	}

	/* Get the timezone */
	ctxt->timezone = get_default_timezone ();
	if (ctxt->timezone == NULL)
		return -1;
	LOG (g_message ( "  Using timezone: %s", icaltimezone_get_tzid (ctxt->timezone) ));
should be:
	/* Get the timezone */
	ctxt->timezone = get_default_timezone ();
	if (ctxt->timezone == NULL)
		return -1;
	LOG (g_message ( "  Using timezone: %s", icaltimezone_get_tzid (ctxt->timezone) ));
	if (start_calendar_server (ctxt) != 0) {
		WARN(_("Could not start evolution-data-server"));
		gnome_pilot_conduit_error (conduit, _("Could not start evolution-data-server"));
		return -1;
	}

Otherwise, the ctxt->timezone will be an empty pointer.

Well, there's some other bugs so the todo conduits doesn't work now. Other conduits work well. May someone take a look at this?

Thanks.
Calvin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]