On Thursday 13 of December 2012 06:43:15 Matthew Barnes wrote: > On Thu, 2012-12-13 at 08:59 +0100, Milan Crha wrote: > > I didn't understand from the initial announcement that you'll not only > > merge those above in one .so, but that you'll also move all the files > > into one folder. This makes it quite messy to find anything, the > > previous file layout was better from my point of view. I guess making > > > > eutil/menus > > eutil/table > > ... > > > > as static libraries, linked into one libeutil.so would work pretty well > > too, with an advantage of sorted code. > > The old partitioning is still reflected in the API documentation. I > don't see anything messy about having the source files in a flat list. > GTK+ is able to manage its widgets well enough with a similar layout. Hi, firstly, sorry for speaking up so late, I didn't have much time for Evo before Christmas. I'm with Milan on this - I'd much more prefer to have several subfolders rather then one folder with ~500 files. When working on the editor for instance, it's much easier for me to move in a folder with fewer files. I'd very like see larger "submodules" having their own folders. /e-util /activity - EActivity* classes /alert - EAlert* classes /attachments - EAttachment* classes /categories - ECategory* and ECategories* classes /editor - EEditor* classes /emoticons - EEmoticon* classes /filter - EFilter* classes /gal - Gal* classes /name-selector - ENameSelector* classes /signature - EMailSignature* classes /table - ETable* classes /cell - ECell* classes Just because they don't do it in GTK+ does not mean we should follow them blindly. Honestly, digging around in 500+ files slows me down and just annoys me. There is _absolutely_ no pain in using subfolders, there's only gain in developers' comfort. And from personal experience, it's also less scary for new potential contributors. Secondly, I don't understand why almost every class in Evolution should include the complete EEditor headers and ETable headers etc, when they are really needed only in a very few places. This impacts build time, because all the headers have to be preprocessed and compiled every time for every single class that includes e-util.h. I'm all for group headers - it's a good idea, but let's be a bit more reasonable here - why not having e-table.h for ETable stuff, e-editor.h for EEditor stuff etc...? Bye and Merry Christmas :) Dan > > Matt > > _______________________________________________ > evolution-hackers mailing list > evolution-hackers gnome org > To change your list options or unsubscribe, visit ... > https://mail.gnome.org/mailman/listinfo/evolution-hackers
Attachment:
signature.asc
Description: This is a digitally signed message part.