Re: [evolution-patches] bug fix for 41843, csv exporting file should have consistent english field name

[Gilbert Fang <gilbert fang sun com>]

Hi, Toshok
 Oh,  well. 
The main reason is I am afraid the staroffice group may take long time
for changing the field name. But they just told me they can accept such
changes. 

Now the patch is following your suggestion. 
Could you please review and check it quickly? so that I can tell the
staroffice group the new field mapping ASAP. They are nearly code
freezing. :-(

Gilbert 
 

On Fri, 2003-04-25 at 14:50, Chris Toshok wrote:
> Why not just change the use e_card_simple_get_name to
> e_card_simple_get_ecard_field?  It offers a unique "name" for each field
> that isn't localized.
> 
> It's not as pretty as the names you included here but it's just meant
> for consumption by tools anyway.
> 
> Chris
> 
> On Thu, 2003-04-24 at 20:51, Gilbert Fang wrote:
> > On Fri, 2003-04-25 at 09:26, Chris Toshok wrote:
> > > On Thu, 2003-04-24 at 04:52, Gilbert Fang wrote:
> > > > Hi, toshok
> > > >  Please review it . 
> > > > patch41843_20030424:  e_card_simple_get_name should return a
> > > > non-localized name
> > > 
> > > This is not true - it must return a localized name because it's used
> > > elsewhere in the UI (specifically in the minicard view.  it's used to
> > > create the minicard field names.)
> > > 
> > > use e_card_simple_get_ecard_field instead.  unfortunately that'll return
> > > strings that will be different than what you're checking against now.
> > > 
> > 
> > Thanks.
> > 
> > Maybe my previous patch is not right.But this is really a trouble for
> > data exchanging  with staroffice. 
> > 
> > I wrote  a new patch, which  only puts all the csv field names in the
> > export's code. Thus it will not affect evolution's other part,
> > I think  csv field name needs its own field name rationally, because
> > it has the difference in semantics with the e-card-simple-field. 
> > 
> > Could you please review it ?
> > 
> > Gilbert 
> > 
> > 
> > 

Index: evolution-addressbook-export-list-cards.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/tools/evolution-addressbook-export-list-cards.c,v
retrieving revision 1.1
diff -u -r1.1 evolution-addressbook-export-list-cards.c
--- evolution-addressbook-export-list-cards.c	7 Apr 2003 16:21:03 -0000	1.1
+++ evolution-addressbook-export-list-cards.c	25 Apr 2003 07:08:16 -0000
@@ -296,7 +296,7 @@
 
 	if (simple_field != NOMAP) {
 		a_simple_card = E_CARD_SIMPLE (g_object_new (E_TYPE_CARD_SIMPLE, NULL));
-		name = g_strdup (e_card_simple_get_name (a_simple_card, simple_field));
+		name = g_strdup (e_card_simple_get_ecard_field (a_simple_card, simple_field));
 		g_object_unref (G_OBJECT (a_simple_card));
 	} else {
 		name = g_strdup (csv_field_data[csv_field].csv_name);