Re: [evolution-patches] 42456, mailer spell checking enable button

[Jeffrey Stedfast <fejj ximian com>]

looks good

On Wed, 2003-05-07 at 05:00, Not Zed wrote:
> Untested, as spell checking isn't installed on my system, so i can't
> check it.
> 
> I also added a fixme, the way this code works is really pretty awful ...
> 
>  Z
> 
> 
> ______________________________________________________________________
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
> retrieving revision 1.2716
> diff -u -3 -r1.2716 ChangeLog
> --- ChangeLog	7 May 2003 00:53:39 -0000	1.2716
> +++ ChangeLog	7 May 2003 07:22:38 -0000
> @@ -1,3 +1,11 @@
> +2003-05-07  Not Zed  <NotZed Ximian com>
> +
> +	** See bug #42456
> +	
> +	* mail-composer-prefs.c (spell_language_button_press): set the
> +	enable/disable button to the right text when we toggle a column.
> +	Added a fixme about the weird code in the whole routine.
> +
>  2003-05-06  Not Zed  <NotZed Ximian com>
>  
>  	** See bug #42400
> Index: mail-composer-prefs.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/mail-composer-prefs.c,v
> retrieving revision 1.61
> diff -u -3 -r1.61 mail-composer-prefs.c
> --- mail-composer-prefs.c	21 Apr 2003 17:42:40 -0000	1.61
> +++ mail-composer-prefs.c	7 May 2003 07:22:38 -0000
> @@ -703,6 +703,9 @@
>  	GtkTreeViewColumn *column = NULL;
>  	gtk_tree_view_get_path_at_pos (tv, event->x, event->y, &path, &column, NULL, NULL);
>  
> +	/* FIXME: This routine should just be a "toggled" event handler on the checkbox cell renderer which
> +	   has "activatable" set. */
> +
>  	if (path != NULL && column != NULL && !strcmp (gtk_tree_view_column_get_title (column), _("Enabled"))) {
>  		GtkTreeIter iter;
>  		GtkTreeModel *model;
> @@ -712,6 +715,7 @@
>  		gtk_tree_model_get_iter (model, &iter, path);
>  		gtk_tree_model_get (model, &iter, 0, &enabled, -1);
>  		gtk_list_store_set ((GtkListStore *) model, &iter, 0, !enabled, -1);
> +		gtk_button_set_label ((GtkButton *) prefs->spell_able_button, enabled ? _("Enable") : _("Disable"));
>  		spell_changed (prefs);
>  	}
>  
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com