From spamfrommailing@freax.org Sun May 1 02:39:57 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 4F39312418C; Sun, 1 May 2005 02:39:55 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id DD7CB124451; Sun, 1 May 2005 02:39:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id A4E4413941C9; Sun, 1 May 2005 12:40:23 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25278-02; Sun, 1 May 2005 12:40:16 +0200 (CEST) Received: from lort (dD576CB7F.access.telenet.be [213.118.203.127]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id E1FC51394170; Sun, 1 May 2005 12:40:15 +0200 (CEST) From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: evolution-hackers@lists.ximian.com Cc: Evolution Patches Content-Type: multipart/mixed; boundary="=-cHVLlHiiF/RPffJsKTLN" Date: Sun, 01 May 2005 12:40:13 +0200 Message-Id: <1114944013.1364.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-4.9 required=5.0 tests=HTML_10_20,HTML_MESSAGE,PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Fix for builderror in e-utils Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-cHVLlHiiF/RPffJsKTLN Content-Type: multipart/alternative; boundary="=-Jl4VPaP2HX8U2PLawJL2" --=-Jl4VPaP2HX8U2PLawJL2 Content-Type: text/plain Content-Transfer-Encoding: 7bit This one fixes a build-error in e-utils/. It removes a very wieerd macro that's already being handled correctly in the c-file, and that made the compilation stop working at some point (I can't find the reason why it should be like the macro) -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-Jl4VPaP2HX8U2PLawJL2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit This one fixes a build-error in e-utils/. It removes a very wieerd macro that's already being handled correctly in the c-file, and that made the compilation stop working at some point (I can't find the reason why it should be like the macro)

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-Jl4VPaP2HX8U2PLawJL2-- --=-cHVLlHiiF/RPffJsKTLN Content-Disposition: attachment; filename=fixes_evo_build.diff Content-Type: text/x-patch; name=fixes_evo_build.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: e-profile-event.h =================================================================== RCS file: /cvs/gnome/evolution/e-util/e-profile-event.h,v retrieving revision 1.1 diff -u -r1.1 e-profile-event.h --- e-profile-event.h 28 Apr 2005 09:59:50 -0000 1.1 +++ e-profile-event.h 1 May 2005 10:36:44 -0000 @@ -80,11 +80,6 @@ EProfileEventTarget *e_profile_event_target_new(EProfileEvent *emp, const char *id, const char *uid, guint32 flags); -#ifndef ENABLE_PROFILING -#define e_profile_event_emit(id, uid, flags) -#else -void e_profile_event_emit(const char *id, const char *uid, guint32 flags); -#endif /* ********************************************************************** */ --=-cHVLlHiiF/RPffJsKTLN-- From evolution-hackers-admin@lists.ximian.com Sun May 1 03:04:16 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 5D1CB12459B; Sun, 1 May 2005 03:04:16 -0400 (EDT) Received: from executivesontheweb.com (host217-37-162-197.in-addr.btopenworld.com [217.37.162.197]) by lists.ximian.com (Postfix) with ESMTP id CE65612459B for ; Sun, 1 May 2005 03:04:03 -0400 (EDT) Received: from mail pickup service by executivesontheweb.com with Microsoft SMTPSVC; Sun, 1 May 2005 12:16:00 +0100 Thread-Index: AcVOPycW19LD93DpTg6JanNkCnr7QA== From: "Philip Van Hoof" Reply-To: To: Cc: "Evolution Patches" Message-ID: <002601c54e3f$271682a0$0301a8c0@executivesontheweb.local> Content-Type: multipart/mixed; boundary="=-cHVLlHiiF/RPffJsKTLN" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-BeenThere: evolution-hackers@lists.ximian.com X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.181 X-Mailman-Version: 2.0.13 Content-Class: urn:content-classes:message Importance: normal Precedence: bulk Priority: normal Date: Sun, 1 May 2005 12:15:59 +0100 X-OriginalArrivalTime: 01 May 2005 11:16:00.0093 (UTC) FILETIME=[276788D0:01C54E3F] X-Spam-Status: No, hits=-4.0 required=5.0 tests=HTML_10_20,HTML_MESSAGE,MISSING_OUTLOOK_NAME, PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] [Evolution-hackers] Fix for builderror in e-utils Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: This is a multi-part message in MIME format. --=-cHVLlHiiF/RPffJsKTLN Content-Type: multipart/alternative; boundary="=-Jl4VPaP2HX8U2PLawJL2" --=-Jl4VPaP2HX8U2PLawJL2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit This one fixes a build-error in e-utils/. It removes a very wieerd macro that's already being handled correctly in the c-file, and that made the compilation stop working at some point (I can't find the reason why it should be like the macro) -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-Jl4VPaP2HX8U2PLawJL2 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit This one fixes a build-error in e-utils/. It removes a very wieerd macro that's already being handled correctly in the c-file, and that made the compilation stop working at some point (I can't find the reason why it should be like the macro)

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-Jl4VPaP2HX8U2PLawJL2-- --=-cHVLlHiiF/RPffJsKTLN Content-Disposition: attachment; filename="fixes_evo_build.diff" Content-Type: text/x-patch; charset="utf-8"; name="fixes_evo_build.diff" Content-Transfer-Encoding: 7bit Index: e-profile-event.h =================================================================== RCS file: /cvs/gnome/evolution/e-util/e-profile-event.h,v retrieving revision 1.1 diff -u -r1.1 e-profile-event.h --- e-profile-event.h 28 Apr 2005 09:59:50 -0000 1.1 +++ e-profile-event.h 1 May 2005 10:36:44 -0000 @@ -80,11 +80,6 @@ EProfileEventTarget *e_profile_event_target_new(EProfileEvent *emp, const char *id, const char *uid, guint32 flags); -#ifndef ENABLE_PROFILING -#define e_profile_event_emit(id, uid, flags) -#else -void e_profile_event_emit(const char *id, const char *uid, guint32 flags); -#endif /* ********************************************************************** */ --=-cHVLlHiiF/RPffJsKTLN-- From psankar@novell.com Mon May 2 00:54:38 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 789E41240F0; Mon, 2 May 2005 00:54:36 -0400 (EDT) Received: from nanclus.provo.novell.com (nanclus.provo.novell.com [137.65.81.53]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "nanclus.provo.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 8785C12423B for ; Mon, 2 May 2005 00:34:36 -0400 (EDT) Received: from PROVO4-MTA by nanclus.provo.novell.com with Novell_GroupWise; Mon, 02 May 2005 02:35:36 -0600 Message-Id: <20050502T140655Z_AD4F00150000@novell.com> X-Mailer: Novell GroupWise Internet Agent 6.7 Beta Date: Mon, 02 May 2005 02:35:28 -0600 From: "Pasupathilingam Sankarasivasubramanian" To: "Not Zed" Cc: , "Susarla Parthasarathi" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartF9DAC340.1__=" X-Spam-Status: No, hits=-5.3 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Updated Patch for GroupWise Sent Items Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__PartF9DAC340.1__= Content-Type: multipart/alternative; boundary="=__PartF9DAC340.2__=" --=__PartF9DAC340.2__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Michael,=20 =20 I have updated the code as per your review comments and updated the = ChangeLog also.=20 Please review the attached updated patches.=20 =20 Thanks,=20 Sankar =20 >>>Not Zed 04/29/05 4:49 am >>> HI Sankar, I think probably it isn't necessary to add the flag to the transport at = all really - the provider flag should be sufficient, and you can get it = from the transport easily anyway: ((CamelService *)xport)->provider->flags Rather than having to manage a separate copy of the flag in the transport = structure. The changelog missed the change to mail-ops.c too. Thanks, Michael On Thu, 2005-04-28 at 04:09 -0600, Pasupathilingam Sankarasivasubramanian = wrote: Hi,=20 =20 While using a GroupWise account with Evolution, the sent-items should not = be copied to any folder by evolution since the server does it. So = Evolution must disable the user from changing the Sent Items button.=20 =20 The patches for disabling the user to set any folder as Sent item folder = and prevent copying of sent mails is attached with this mail.=20 =20 Thanks & Regards,=20 Sankar P=20 --=__PartF9DAC340.2__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Hi Michael,
 
I have updated the code as per your review comments and updated = the ChangeLog also.=20
Please review the attached updated patches.
 
Thanks,
Sankar  

>>>Not Zed <notzed@ximian.com>= 04/29/05 4:49 am >>>

HI Sankar,

I think = probably it isn't necessary to add the flag to the transport at all = really - the provider flag should be sufficient, and you can get it = from the transport easily anyway:

((CamelService *)x= port)->provider->flags

Rather than having to manage a = separate copy of the flag in the transport structure.

The changelog = missed the change to mail-ops.c too.

Thanks,
Michael

O= n Thu, 2005-04-28 at 04:09 -0600, Pasupathilingam Sankarasivasubram= anian wrote:
Hi,
 
While using a = GroupWise account with Evolution, the sent-items should not be copied = to any folder by evolution since the server does it. So Evolution must = disable the user from changing the Sent Items button.
 
The patches for = disabling the user to set any folder as Sent item folder and prevent = copying of sent mails is attached with this mail.
 
Thanks & = Regards,
Sankar P =
--=__PartF9DAC340.2__=-- --=__PartF9DAC340.1__= Content-Type: application/octet-stream; name="camel.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="camel.patch" SW5kZXg6IGNhbWVsLXByb3ZpZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9l dm9sdXRpb24tZGF0YS1zZXJ2ZXIvY2FtZWwvY2FtZWwtcHJvdmlkZXIuaCx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS40NgpkaWZmIC11IC1wIC1yMS40NiBjYW1lbC1wcm92aWRlci5oCi0tLSBjYW1l bC1wcm92aWRlci5oCTMxIEphbiAyMDA1IDA0OjE1OjE5IC0wMDAwCTEuNDYKKysrIGNhbWVsLXBy b3ZpZGVyLmgJMiBNYXkgMjAwNSAwODozMDoxMSAtMDAwMApAQCAtNjksNiArNjksNyBAQCBleHRl cm4gY2hhciAqY2FtZWxfcHJvdmlkZXJfdHlwZV9uYW1lW0NBCiAjZGVmaW5lIENBTUVMX1BST1ZJ REVSX0lTX1NUT1JBR0UJKDEgPDwgNCkKICNkZWZpbmUgQ0FNRUxfUFJPVklERVJfU1VQUE9SVFNf U1NMCSgxIDw8IDUpCiAjZGVmaW5lIENBTUVMX1BST1ZJREVSX0hBU19MSUNFTlNFICAgICAgKDEg PDwgNikKKyNkZWZpbmUgQ0FNRUxfUFJPVklERVJfRElTQUJMRV9TRU5UX0ZPTERFUiAoMSA8PCA3 KQogCiAKIC8qIEZsYWdzIGZvciB1cmxfZmxhZ3MuICJBTExPVyIgbWVhbnMgdGhlIGNvbmZpZyBk aWFsb2cgd2lsbCBsZXQgdGhlCkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9nbm9tZS9ldm9sdXRpb24tZGF0YS1zZXJ2ZXIvY2FtZWwvQ2hhbmdlTG9nLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjI0NDYKZGlmZiAtdSAtcCAtcjEuMjQ0NiBDaGFuZ2VMb2cKLS0tIENo YW5nZUxvZwkyNyBBcHIgMjAwNSAwODoyODo1MCAtMDAwMAkxLjI0NDYKKysrIENoYW5nZUxvZwky IE1heSAyMDA1IDA4OjMwOjI0IC0wMDAwCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDUtMDUtMDIgIFNh bmthciBQICA8cHNhbmthckBub3ZlbGwuY29tPgorCisJKiBjYW1lbC1wcm92aWRlci5oCisJQWRk ZWQgYSBuZXcgZmxhZyBDQU1FTF9QUk9WSURFUl9ESVNBQkxFX1NFTlRfRk9MREVSIHNvIGFzIHRv IGZhY2lsaXRhdGUKKwlkaXNhYmxpbmcgc2VudCBidXR0b24gYW5kIHByZXZlbnQgY29weWluZyBz ZW50IGl0ZW1zLiAKKwlUaGlzIGZsYWcgaXMgaW50cm9kdWNlZCBmb3IgdGhlIEdyb3VwV2lzZSBw cm92aWRlciwgYnV0IGNhbiBiZSBtYWRlIHVzZSAKKwlvZiBieSBhbnkgb3RoZXIgdHlwZSBvZiBw cm92aWRlciwgaWYgbmVlZGVkLgorCiAyMDA1LTA0LTI2ICBSb3NzIEJ1cnRvbiAgPHJvc3NAYnVy dG9uaW5pLmNvbT4KIAogCSogY2FtZWwvYnJva2VuLWRhdGUtcGFyc2VyLmM6Cg== --=__PartF9DAC340.1__= Content-Type: application/octet-stream; name="gw_provider.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gw_provider.patch" SW5kZXg6IGNhbWVsLWdyb3Vwd2lzZS1wcm92aWRlci5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvZ25vbWUvZXZvbHV0aW9uLWRhdGEtc2VydmVyL2NhbWVsL3Byb3ZpZGVycy9ncm91cHdpc2Uv Y2FtZWwtZ3JvdXB3aXNlLXByb3ZpZGVyLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjcKZGlm ZiAtdSAtcCAtcjEuMjcgY2FtZWwtZ3JvdXB3aXNlLXByb3ZpZGVyLmMKLS0tIGNhbWVsLWdyb3Vw d2lzZS1wcm92aWRlci5jCTIyIEFwciAyMDA1IDE3OjQ3OjEwIC0wMDAwCTEuMjcKKysrIGNhbWVs LWdyb3Vwd2lzZS1wcm92aWRlci5jCTIgTWF5IDIwMDUgMDg6MjY6MDAgLTAwMDAKQEAgLTg5LDcg Kzg5LDcgQEAgc3RhdGljIENhbWVsUHJvdmlkZXIgZ3JvdXB3aXNlX3Byb3ZpZGVyIAogCSJtYWls IiwKIAogCUNBTUVMX1BST1ZJREVSX0lTX1JFTU9URSB8IENBTUVMX1BST1ZJREVSX0lTX1NPVVJD RSB8Ci0JQ0FNRUxfUFJPVklERVJfSVNfU1RPUkFHRSB8IENBTUVMX1BST1ZJREVSX1NVUFBPUlRT X1NTTCwKKwlDQU1FTF9QUk9WSURFUl9JU19TVE9SQUdFIHwgQ0FNRUxfUFJPVklERVJfU1VQUE9S VFNfU1NMIHwgQ0FNRUxfUFJPVklERVJfRElTQUJMRV9TRU5UX0ZPTERFUiwKIAogCUNBTUVMX1VS TF9ORUVEX1VTRVIgfCBDQU1FTF9VUkxfTkVFRF9IT1NUIHwgQ0FNRUxfVVJMX0FMTE9XX0FVVEgs CiAKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1 dGlvbi1kYXRhLXNlcnZlci9jYW1lbC9wcm92aWRlcnMvZ3JvdXB3aXNlL0NoYW5nZUxvZyx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS41MQpkaWZmIC11IC1wIC1yMS41MSBDaGFuZ2VMb2cKLS0tIENo YW5nZUxvZwkyOCBBcHIgMjAwNSAwNToxMDo1OCAtMDAwMAkxLjUxCisrKyBDaGFuZ2VMb2cJMiBN YXkgMjAwNSAwODoyNjowMSAtMDAwMApAQCAtMSwzICsxLDkgQEAKKzIwMDUtMDQtMDIgIFNhbmth ciBQICA8cHNhbmthckBub3ZlbGwuY29tPgorCisJKiBjYW1lbC1ncm91cHdpc2UtcHJvdmlkZXIu YyAKKwlBZGRlZCBjb2RlIHNvIGFzIHRvIGRpc2FibGUgc2VudCBpdGVtcyBidXR0b24gYW5kIHBy ZXZlbnQKKwljb3B5aW5nIG9mIHNlbnQgaXRlbXMgdG8gYW55IGZvbGRlciwgZm9yIGEgR3JvdXBX aXNlIGFjY291bnQuCisJCiAyMDA1LTA0LTI3ICBQYXJ0aGFzYXJhdGhpIFN1c2FybGEgPHNwYXJ0 aGFzYXJhdGhpQG5vdmVsbC5jb20+CiAJCiAJKiBjYW1lbC1ncm91cHdpc2UtZm9sZGVyLmM6IAo= --=__PartF9DAC340.1__= Content-Type: application/octet-stream; name="mail.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="mail.patch" SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlv bi9tYWlsL0NoYW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNjE5CmRpZmYgLXUgLXAg LXIxLjM2MTkgQ2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMTMgQXByIDIwMDUgMDM6MzI6NTggLTAw MDAJMS4zNjE5CisrKyBDaGFuZ2VMb2cJMiBNYXkgMjAwNSAwODoyMjowNCAtMDAwMApAQCAtMSwz ICsxLDExIEBACisyMDA1LTA1LTAyICBTYW5rYXIgUCAgPHBzYW5rYXJAbm92ZWxsLmNvbT4KKwkK KwkqIG1haWwtb3BzLmMgKG1haWxfc2VuZF9tZXNzYWdlKQorCUFkZGVkIGNvZGUgdG8gcHJldmVu dCBjb3B5aW5nIG9mIHNlbnQgaXRlbXMsIGJhc2VkIG9uIHByb3ZpZGVyIHR5cGUKKworCSogZW0t YWNjb3VudC1lZGl0b3IuYyAoZW1hZV9kZWZhdWx0c19wYWdlKQorCUFkZGVkIGNvZGUgdG8gZGlz YWJsZSB0aGUgU2VudCBGb2xkZXJzIGJ1dHRvbgorCiAyMDA1LTA0LTEyICBOb3QgWmVkICA8Tm90 WmVkQFhpbWlhbi5jb20+CiAKIAkqKiBTZWUgYnVnICMyNzM3NTIKSW5kZXg6IG1haWwtb3BzLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9sdXRpb24vbWFpbC9tYWlsLW9wcy5j LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ0NQpkaWZmIC11IC1wIC1yMS40NDUgbWFpbC1vcHMu YwotLS0gbWFpbC1vcHMuYwk0IE1hciAyMDA1IDAzOjE1OjM3IC0wMDAwCTEuNDQ1CisrKyBtYWls LW9wcy5jCTIgTWF5IDIwMDUgMDg6MjI6MTcgLTAwMDAKQEAgLTU1MCwyMSArNTUwLDYgQEAgbWFp bF9zZW5kX21lc3NhZ2UoQ2FtZWxGb2xkZXIgKnF1ZXVlLCBjbwogCS8qIHBvc3QgcHJvY2VzcyAq LwogCW1haWxfdG9vbF9yZXN0b3JlX3hldm9sdXRpb25faGVhZGVycyAobWVzc2FnZSwgeGV2KTsK IAkKLQlpZiAoc2VudF9mb2xkZXJfdXJpKSB7Ci0JCWZvbGRlciA9IG1haWxfdG9vbF91cmlfdG9f Zm9sZGVyIChzZW50X2ZvbGRlcl91cmksIDAsIGV4KTsKLQkJaWYgKGNhbWVsX2V4Y2VwdGlvbl9p c19zZXQoZXgpKSB7Ci0JCQlnX3N0cmluZ19hcHBlbmRfcHJpbnRmIChlcnIsIF8oIkZhaWxlZCB0 byBhcHBlbmQgdG8gJXM6ICVzXG4iCi0JCQkJCQkgICAgICAgIkFwcGVuZGluZyB0byBsb2NhbCBg U2VudCcgZm9sZGVyIGluc3RlYWQuIiksCi0JCQkJCQlzZW50X2ZvbGRlcl91cmksIGNhbWVsX2V4 Y2VwdGlvbl9nZXRfZGVzY3JpcHRpb24gKGV4KSk7Ci0JCQljYW1lbF9leGNlcHRpb25fY2xlYXIg KGV4KTsKLQkJfQotCX0KLQkKLQlpZiAoIWZvbGRlcikgewotCQlmb2xkZXIgPSBtYWlsX2NvbXBv bmVudF9nZXRfZm9sZGVyKE5VTEwsIE1BSUxfQ09NUE9ORU5UX0ZPTERFUl9TRU5UKTsJCi0JCWNh bWVsX29iamVjdF9yZWYoZm9sZGVyKTsKLQl9Ci0JCiAJaWYgKGRyaXZlcikgewogCQljYW1lbF9m aWx0ZXJfZHJpdmVyX2ZpbHRlcl9tZXNzYWdlIChkcml2ZXIsIG1lc3NhZ2UsIGluZm8sCiAJCQkJ CQkgICAgTlVMTCwgTlVMTCwgTlVMTCwgIiIsIGV4KTsKQEAgLTU4MCw0NiArNTY1LDY1IEBAIG1h aWxfc2VuZF9tZXNzYWdlKENhbWVsRm9sZGVyICpxdWV1ZSwgY28KIAl9CiAJCiAJY2FtZWxfZXhj ZXB0aW9uX2NsZWFyIChleCk7Ci0JY2FtZWxfZm9sZGVyX2FwcGVuZF9tZXNzYWdlIChmb2xkZXIs IG1lc3NhZ2UsIGluZm8sIE5VTEwsIGV4KTsKLQlpZiAoY2FtZWxfZXhjZXB0aW9uX2lzX3NldCAo ZXgpKSB7Ci0JCUNhbWVsRm9sZGVyICpzZW50X2ZvbGRlcjsKIAotCQlpZiAoY2FtZWxfZXhjZXB0 aW9uX2dldF9pZCAoZXgpID09IENBTUVMX0VYQ0VQVElPTl9VU0VSX0NBTkNFTCkKLQkJCWdvdG8g ZXhpdDsKKwlpZiAoISggKChDYW1lbFNlcnZpY2UgKil4cG9ydCktPnByb3ZpZGVyLT5mbGFncyAm IENBTUVMX1BST1ZJREVSX0RJU0FCTEVfU0VOVF9GT0xERVIpKSB7CQorCQlpZiAoc2VudF9mb2xk ZXJfdXJpKSB7CisJCQlmb2xkZXIgPSBtYWlsX3Rvb2xfdXJpX3RvX2ZvbGRlciAoc2VudF9mb2xk ZXJfdXJpLCAwLCBleCk7CisJCQlpZiAoY2FtZWxfZXhjZXB0aW9uX2lzX3NldChleCkpIHsKKwkJ CQlnX3N0cmluZ19hcHBlbmRfcHJpbnRmIChlcnIsIF8oIkZhaWxlZCB0byBhcHBlbmQgdG8gJXM6 ICVzXG4iCisJCQkJCQkJIkFwcGVuZGluZyB0byBsb2NhbCBgU2VudCcgZm9sZGVyIGluc3RlYWQu IiksCisJCQkJCQlzZW50X2ZvbGRlcl91cmksIGNhbWVsX2V4Y2VwdGlvbl9nZXRfZGVzY3JpcHRp b24gKGV4KSk7CisJCQkJY2FtZWxfZXhjZXB0aW9uX2NsZWFyIChleCk7CisJCQl9CisJCX0KIAot CQlzZW50X2ZvbGRlciA9IG1haWxfY29tcG9uZW50X2dldF9mb2xkZXIoTlVMTCwgTUFJTF9DT01Q T05FTlRfRk9MREVSX1NFTlQpOworCQlpZiAoIWZvbGRlcikgeworCQkJZm9sZGVyID0gbWFpbF9j b21wb25lbnRfZ2V0X2ZvbGRlcihOVUxMLCBNQUlMX0NPTVBPTkVOVF9GT0xERVJfU0VOVCk7CQor CQkJY2FtZWxfb2JqZWN0X3JlZihmb2xkZXIpOworCQl9CiAKLQkJaWYgKGZvbGRlciAhPSBzZW50 X2ZvbGRlcikgewotCQkJY29uc3QgY2hhciAqbmFtZTsKLQkJCQotCQkJY2FtZWxfb2JqZWN0X2dl dCAoZm9sZGVyLCBOVUxMLCBDQU1FTF9PQkpFQ1RfREVTQ1JJUFRJT04sIChjaGFyICoqKSAmbmFt ZSwgMCk7Ci0JCQlpZiAoZXJyLT5sZW4pCi0JCQkJZ19zdHJpbmdfYXBwZW5kKGVyciwgIlxuXG4i KTsKLQkJCWdfc3RyaW5nX2FwcGVuZF9wcmludGYgKGVyciwgXygiRmFpbGVkIHRvIGFwcGVuZCB0 byAlczogJXNcbiIKLQkJCQkJCSJBcHBlbmRpbmcgdG8gbG9jYWwgYFNlbnQnIGZvbGRlciBpbnN0 ZWFkLiIpLAotCQkJCQkJbmFtZSwgY2FtZWxfZXhjZXB0aW9uX2dldF9kZXNjcmlwdGlvbiAoZXgp KTsKLQkJCWNhbWVsX29iamVjdF9yZWYgKHNlbnRfZm9sZGVyKTsKLQkJCWNhbWVsX29iamVjdF91 bnJlZiAoZm9sZGVyKTsKLQkJCWZvbGRlciA9IHNlbnRfZm9sZGVyOwogCi0JCQljYW1lbF9leGNl cHRpb25fY2xlYXIgKGV4KTsKLQkJCWNhbWVsX2ZvbGRlcl9hcHBlbmRfbWVzc2FnZSAoZm9sZGVy LCBtZXNzYWdlLCBpbmZvLCBOVUxMLCBleCk7Ci0JCX0KIAorCQljYW1lbF9mb2xkZXJfYXBwZW5k X21lc3NhZ2UgKGZvbGRlciwgbWVzc2FnZSwgaW5mbywgTlVMTCwgZXgpOwogCQlpZiAoY2FtZWxf ZXhjZXB0aW9uX2lzX3NldCAoZXgpKSB7CisJCQlDYW1lbEZvbGRlciAqc2VudF9mb2xkZXI7CisK IAkJCWlmIChjYW1lbF9leGNlcHRpb25fZ2V0X2lkIChleCkgPT0gQ0FNRUxfRVhDRVBUSU9OX1VT RVJfQ0FOQ0VMKQogCQkJCWdvdG8gZXhpdDsKIAotCQkJaWYgKGVyci0+bGVuKQotCQkJCWdfc3Ry aW5nX2FwcGVuZChlcnIsICJcblxuIik7Ci0JCQlnX3N0cmluZ19hcHBlbmRfcHJpbnRmIChlcnIs IF8oIkZhaWxlZCB0byBhcHBlbmQgdG8gbG9jYWwgYFNlbnQnIGZvbGRlcjogJXMiKSwKKwkJCXNl bnRfZm9sZGVyID0gbWFpbF9jb21wb25lbnRfZ2V0X2ZvbGRlcihOVUxMLCBNQUlMX0NPTVBPTkVO VF9GT0xERVJfU0VOVCk7CisKKwkJCWlmIChmb2xkZXIgIT0gc2VudF9mb2xkZXIpIHsKKwkJCQlj b25zdCBjaGFyICpuYW1lOworCisJCQkJY2FtZWxfb2JqZWN0X2dldCAoZm9sZGVyLCBOVUxMLCBD QU1FTF9PQkpFQ1RfREVTQ1JJUFRJT04sIChjaGFyICoqKSAmbmFtZSwgMCk7CisJCQkJaWYgKGVy ci0+bGVuKQorCQkJCQlnX3N0cmluZ19hcHBlbmQoZXJyLCAiXG5cbiIpOworCQkJCWdfc3RyaW5n X2FwcGVuZF9wcmludGYgKGVyciwgXygiRmFpbGVkIHRvIGFwcGVuZCB0byAlczogJXNcbiIKKwkJ CQkJCQkiQXBwZW5kaW5nIHRvIGxvY2FsIGBTZW50JyBmb2xkZXIgaW5zdGVhZC4iKSwKKwkJCQkJ CW5hbWUsIGNhbWVsX2V4Y2VwdGlvbl9nZXRfZGVzY3JpcHRpb24gKGV4KSk7CisJCQkJY2FtZWxf b2JqZWN0X3JlZiAoc2VudF9mb2xkZXIpOworCQkJCWNhbWVsX29iamVjdF91bnJlZiAoZm9sZGVy KTsKKwkJCQlmb2xkZXIgPSBzZW50X2ZvbGRlcjsKKworCQkJCWNhbWVsX2V4Y2VwdGlvbl9jbGVh ciAoZXgpOworCQkJCWNhbWVsX2ZvbGRlcl9hcHBlbmRfbWVzc2FnZSAoZm9sZGVyLCBtZXNzYWdl LCBpbmZvLCBOVUxMLCBleCk7CisJCQl9CisKKwkJCWlmIChjYW1lbF9leGNlcHRpb25faXNfc2V0 IChleCkpIHsKKwkJCQlpZiAoY2FtZWxfZXhjZXB0aW9uX2dldF9pZCAoZXgpID09IENBTUVMX0VY Q0VQVElPTl9VU0VSX0NBTkNFTCkKKwkJCQkJZ290byBleGl0OworCisJCQkJaWYgKGVyci0+bGVu KQorCQkJCQlnX3N0cmluZ19hcHBlbmQoZXJyLCAiXG5cbiIpOworCQkJCWdfc3RyaW5nX2FwcGVu ZF9wcmludGYgKGVyciwgXygiRmFpbGVkIHRvIGFwcGVuZCB0byBsb2NhbCBgU2VudCcgZm9sZGVy OiAlcyIpLAogCQkJCQkJY2FtZWxfZXhjZXB0aW9uX2dldF9kZXNjcmlwdGlvbiAoZXgpKTsKKwkJ CX0KIAkJfQogCX0KLQogCWlmICghY2FtZWxfZXhjZXB0aW9uX2lzX3NldChleCkpCiAJCWNhbWVs X2ZvbGRlcl9zZXRfbWVzc2FnZV9mbGFncyAocXVldWUsIHVpZCwgQ0FNRUxfTUVTU0FHRV9ERUxF VEVEfENBTUVMX01FU1NBR0VfU0VFTiwgfjApOwotCQorCiAJaWYgKGVyci0+bGVuKSB7CiAJCS8q IHNldCB0aGUgY3VsbXVsYXRpdmUgZXhjZXB0aW9uIHJlcG9ydCAqLwogCQljYW1lbF9leGNlcHRp b25fc2V0IChleCwgQ0FNRUxfRVhDRVBUSU9OX1NZU1RFTSwgZXJyLT5zdHIpOwpJbmRleDogZW0t YWNjb3VudC1lZGl0b3IuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlv bi9tYWlsL2VtLWFjY291bnQtZWRpdG9yLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjUKZGlm ZiAtdSAtcCAtcjEuMjUgZW0tYWNjb3VudC1lZGl0b3IuYwotLS0gZW0tYWNjb3VudC1lZGl0b3Iu Ywk4IEFwciAyMDA1IDA0OjM0OjI1IC0wMDAwCTEuMjUKKysrIGVtLWFjY291bnQtZWRpdG9yLmMJ MiBNYXkgMjAwNSAwODoyMjoyMyAtMDAwMApAQCAtMjEzNSw5ICsyMTM1LDEwIEBAIGVtYWVfZGVm YXVsdHNfcGFnZShFQ29uZmlnICplYywgRUNvbmZpZ0kKIAllbWFlX2FjY291bnRfZW50cnkoZW1h ZSwgImJjY19hZGRycyIsIEVfQUNDT1VOVF9CQ0NfQUREUlMsIHhtbCk7CiAKIAlndGtfd2lkZ2V0 X3NldF9zZW5zaXRpdmUoKEd0a1dpZGdldCAqKWd1aS0+ZHJhZnRzX2ZvbGRlcl9idXR0b24sIGVf YWNjb3VudF93cml0YWJsZShlbWFlLT5hY2NvdW50LCBFX0FDQ09VTlRfRFJBRlRTX0ZPTERFUl9V UkkpKTsKLQlndGtfd2lkZ2V0X3NldF9zZW5zaXRpdmUoKEd0a1dpZGdldCAqKWd1aS0+c2VudF9m b2xkZXJfYnV0dG9uLCBlX2FjY291bnRfd3JpdGFibGUoZW1hZS0+YWNjb3VudCwgRV9BQ0NPVU5U X1NFTlRfRk9MREVSX1VSSSkpOworCWd0a193aWRnZXRfc2V0X3NlbnNpdGl2ZSgoR3RrV2lkZ2V0 ICopZ3VpLT5zZW50X2ZvbGRlcl9idXR0b24sIGVfYWNjb3VudF93cml0YWJsZShlbWFlLT5hY2Nv dW50LCBFX0FDQ09VTlRfU0VOVF9GT0xERVJfVVJJKSYmICEoZW1hZS0+cHJpdi0+c291cmNlLnBy b3ZpZGVyLT5mbGFncyAmIENBTUVMX1BST1ZJREVSX0RJU0FCTEVfU0VOVF9GT0xERVIpKTsKIAln dGtfd2lkZ2V0X3NldF9zZW5zaXRpdmUoKEd0a1dpZGdldCAqKWd1aS0+cmVzdG9yZV9mb2xkZXJz X2J1dHRvbiwKLQkJCQkgZV9hY2NvdW50X3dyaXRhYmxlKGVtYWUtPmFjY291bnQsIEVfQUNDT1VO VF9TRU5UX0ZPTERFUl9VUkkpCisJCQkJIChlX2FjY291bnRfd3JpdGFibGUoZW1hZS0+YWNjb3Vu dCwgRV9BQ0NPVU5UX1NFTlRfRk9MREVSX1VSSSkgJiYKKwkJCQkgICAhICggZW1hZS0+cHJpdi0+ c291cmNlLnByb3ZpZGVyLT5mbGFncyAmIENBTUVMX1BST1ZJREVSX0RJU0FCTEVfU0VOVF9GT0xE RVIpKQogCQkJCSB8fCBlX2FjY291bnRfd3JpdGFibGUoZW1hZS0+YWNjb3VudCwgRV9BQ0NPVU5U X0RSQUZUU19GT0xERVJfVVJJKSk7CiAKIAkvKiBSZWNlaXB0IHBvbGljeSAqLwo= --=__PartF9DAC340.1__=-- From manojtemkar@gmail.com Mon May 2 01:02:22 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id B813812401E; Mon, 2 May 2005 01:02:21 -0400 (EDT) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.197]) by lists.ximian.com (Postfix) with ESMTP id C700812407F for ; Mon, 2 May 2005 00:50:52 -0400 (EDT) Received: by zproxy.gmail.com with SMTP id 34so2240543nzf for ; Mon, 02 May 2005 01:51:52 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type; b=hOUlSedzUElFnGijuwOV2wN80EyHv7AZBi4GyMuW9lxi98+F7WHMdpm31QbClJLsql1kAvf/jY+jfrQ86SLlL0hg9nM0mW/pQ/1YapLdtjqyGe6G94dqKYUQXMVfHD9/xEEizlbPekQZ76j5+l9pUo3Jlu9nC/C/k1Wr/VARCZ4= Received: by 10.36.8.17 with SMTP id 17mr499133nzh; Mon, 02 May 2005 01:51:52 -0700 (PDT) Received: by 10.36.3.8 with HTTP; Mon, 2 May 2005 01:51:52 -0700 (PDT) Message-ID: <9979b0e6050502015153a765f4@mail.gmail.com> Date: Mon, 2 May 2005 01:51:52 -0700 From: MANOJ T V Reply-To: MANOJ T V To: pchenthill@novell.com, evolution-patches@lists.ximian.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16500_18196175.1115023912351" X-Spam-Status: No, hits=-6.0 required=5.0 tests=PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Patch for bug # 274402 {evolution-calender component) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: ------=_Part_16500_18196175.1115023912351 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline hello, im sending patch on bug # 274402 . pls review this patch thanks, Manoj ------=_Part_16500_18196175.1115023912351 Content-Type: text/x-patch; name=274402.diff; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="274402.diff" Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v retrieving revision 1.2680.2.14 diff -u -p -r1.2680.2.14 ChangeLog --- ChangeLog=0928 Mar 2005 11:28:53 -0000=091.2680.2.14 +++ ChangeLog=092 May 2005 08:44:01 -0000 @@ -1,3 +1,10 @@ +2005-04-27 Manoj T V + +=09Fixes #274402 + +=09* event-page.c(New Appointments): Grabbed the focus to toplevel widget = by using functions: +=09 gtk_widget_get_toplevel(), and gtk_window_set_focus().=20 + 2005-03-28 Rodrigo Moya =20 =09Fixes #44719 Index: gui/dialogs/event-page.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/event-page.c,v retrieving revision 1.79.2.1 diff -u -p -r1.79.2.1 event-page.c --- gui/dialogs/event-page.c=0915 Mar 2005 02:33:55 -0000=091.79.2.1 +++ gui/dialogs/event-page.c=092 May 2005 08:44:41 -0000 @@ -49,7 +49,6 @@ #include "event-page.h" #include "e-send-options-utils.h" =20 -=0C =20 /* Private part of the EventPage structure */ struct _EventPagePrivate { @@ -57,14 +56,12 @@ struct _EventPagePrivate { =09GladeXML *xml; =20 =09/* Widgets from the Glade file */ - +=09/*GtkWindow *event-toplevel;*/=09 =09GtkWidget *main; - =09GtkWidget *summary; =09GtkWidget *summary_label; =09GtkWidget *location; =09GtkWidget *location_label; - =09GtkWidget *start_time; =09GtkWidget *end_time; =09GtkWidget *start_timezone; @@ -90,6 +87,7 @@ struct _EventPagePrivate { =09GtkWidget *sendoptions_frame; =09GtkWidget *sendoptions_button; =20 + =09EAlarmList *alarm_list_store; =09 =09gboolean updating; @@ -107,7 +105,7 @@ struct _EventPagePrivate { =09gboolean is_meeting; }; =20 -=0C + =20 static void event_page_finalize (GObject *object); =20 @@ -606,19 +604,22 @@ sensitize_widgets (EventPage *epage) { =09gboolean read_only, custom, alarm; =09EventPagePrivate *priv; -=09 +=09GtkWidget *toplevel; =09priv =3D epage->priv; =20 =09if (!e_cal_is_read_only (COMP_EDITOR_PAGE (epage)->client, &read_only, = NULL)) =09=09read_only =3D TRUE; =20 =09custom =3D is_custom_alarm_store (priv->alarm_list_store, priv->old_sum= mary, priv->alarm_units, priv->alarm_interval, NULL); +=09toplevel =3D gtk_widget_get_toplevel (priv->main); +=09if (GTK_WIDGET_TOPLEVEL (toplevel)){ + =09 gtk_window_set_focus(toplevel,NULL); +=09} =09alarm =3D e_dialog_toggle_get (priv->alarm); -=09 =09gtk_widget_set_sensitive (priv->summary_label, !read_only); =09gtk_entry_set_editable (GTK_ENTRY (priv->summary), !read_only); =09gtk_widget_set_sensitive (priv->location_label, !read_only); -=09gtk_entry_set_editable (GTK_ENTRY (priv->location), !read_only); +=09gtk_entry_set_editable (GTK_ENTRY (priv->location),!read_only); =09gtk_widget_set_sensitive (priv->start_time, !read_only); =09gtk_widget_set_sensitive (priv->start_timezone, !read_only); =09gtk_widget_set_sensitive (priv->end_time, !read_only); @@ -630,11 +631,12 @@ sensitize_widgets (EventPage *epage) =09gtk_widget_set_sensitive (priv->alarm, !read_only); =09gtk_widget_set_sensitive (priv->alarm_time, !read_only && !custom && al= arm); =09gtk_widget_set_sensitive (priv->alarm_custom, alarm); +=09=20 =09if (custom) =09=09gtk_widget_show (priv->alarm_warning); =09else =09=09gtk_widget_hide (priv->alarm_warning); -=09gtk_widget_set_sensitive (priv->categories_btn, !read_only); + =09gtk_widget_set_sensitive (priv->sendoptions_button, !read_only); =09gtk_entry_set_editable (GTK_ENTRY (priv->categories), !read_only); } @@ -1137,7 +1139,7 @@ get_widgets (EventPage *epage) =09/* Get the GtkAccelGroup from the toplevel window, so we can install =09 it when the notebook page is mapped. */ =09toplevel =3D gtk_widget_get_toplevel (priv->main); -=09accel_groups =3D gtk_accel_groups_from_object (G_OBJECT (toplevel)); + =09accel_groups =3D gtk_accel_groups_from_object (G_OBJECT (toplevel)); =09if (accel_groups) { =09=09page->accel_group =3D accel_groups->data; =09=09gtk_accel_group_ref (page->accel_group); ------=_Part_16500_18196175.1115023912351-- From rodrigo@novell.com Mon May 2 01:12:28 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id ED40D124014; Mon, 2 May 2005 01:12:25 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 7C6C912400E for ; Mon, 2 May 2005 01:11:01 -0400 (EDT) Received: (qmail 9644 invoked from network); 2 May 2005 09:12:01 -0000 Received: from localhost (HELO ?164.99.152.118?) (127.0.0.1) by localhost with SMTP; 2 May 2005 09:12:01 -0000 Subject: Re: [evolution-patches] [Evolution-hackers] Fix for builderror in e-utils From: Rodrigo Moya To: spamfrommailing@pvanhoof.be Cc: ls@listsmx.ximian.com, Evolution Patches In-Reply-To: <002601c54e3f$271682a0$0301a8c0@executivesontheweb.local> References: <002601c54e3f$271682a0$0301a8c0@executivesontheweb.local> Content-Type: text/plain Date: Mon, 02 May 2005 11:10:51 +0200 Message-Id: <1115025051.4522.23.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Sun, 2005-05-01 at 12:15 +0100, Philip Van Hoof wrote: > This one fixes a build-error in e-utils/. It removes a very wieerd > macro that's already being handled correctly in the c-file, and that > made the compilation stop working at some point (I can't find the > reason why it should be like the macro) > looks good to me (although you need Michael's approval for this), but I think you don't want to remove the e_profile_event_emit prototype, just the other lines. -- Rodrigo Moya From notzed@ximian.com Mon May 2 01:23:26 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 164BD124055; Mon, 2 May 2005 01:23:23 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 26E80124053 for ; Mon, 2 May 2005 01:23:07 -0400 (EDT) Received: (qmail 9677 invoked from network); 2 May 2005 09:24:07 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 2 May 2005 09:24:07 -0000 From: Not Zed To: spamfrommailing@pvanhoof.be Cc: evolution-hackers@lists.ximian.com, Evolution Patches In-Reply-To: <1114944013.1364.1.camel@localhost.localdomain> References: <1114944013.1364.1.camel@localhost.localdomain> Content-Type: multipart/alternative; boundary="=-+A1VD9WMtokuILPnTZLx" Date: Mon, 02 May 2005 14:56:55 +0530 Message-Id: <1115026015.30876.16.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-30.7 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES, SIGNATURE_LONG_SPARSE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Re: [Evolution-hackers] Fix for builderror in e-utils Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-+A1VD9WMtokuILPnTZLx Content-Type: text/plain Content-Transfer-Encoding: 7bit Hmm, why does this not build? It is like that very speficially so that all of the profiling code can be completely removed from the compilation, rather than just calling a dummy function. Any fix should maintain this behaviour, so this one isn't suitable. On Sun, 2005-05-01 at 12:40 +0200, Philip Van Hoof wrote: > This one fixes a build-error in e-utils/. It removes a very wieerd > macro that's already being handled correctly in the c-file, and that > made the compilation stop working at some point (I can't find the > reason why it should be like the macro) > > -- > Philip Van Hoof, Software Developer @ Cronos > home: me at pvanhoof dot be > gnome: pvanhoof at gnome dot org > work: philip dot vanhoof at cronos dot be > junk: philip dot vanhoof at gmail dot com > http://www.pvanhoof.be/ --=-+A1VD9WMtokuILPnTZLx Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Hmm, why does this not  build?

It is like that very speficially so that all of the profiling code can be completely removed from the compilation, rather than just calling a dummy function.

Any fix should maintain this behaviour, so this one isn't suitable.


On Sun, 2005-05-01 at 12:40 +0200, Philip Van Hoof wrote:
This one fixes a build-error in e-utils/. It removes a very wieerd macro that's already being handled correctly in the c-file, and that made the compilation stop working at some point (I can't find the reason why it should be like the macro)

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-+A1VD9WMtokuILPnTZLx-- From hpj@novell.com Sun May 1 18:22:46 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 68BA51264E5; Sun, 1 May 2005 18:22:46 -0400 (EDT) Received: from lubyanka.copyleft.no (unknown [82.117.37.14]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id D32581264E8 for ; Sun, 1 May 2005 18:22:26 -0400 (EDT) Received: from localhost ([82.117.37.14]) by lubyanka.copyleft.no (8.13.1/8.13.1) with ESMTP id j422NI2S015219 for ; Mon, 2 May 2005 04:23:24 +0200 (CEST) (envelope-from hpj@novell.com) From: Hans Petter Jansson To: evolution-patches@lists.ximian.com Content-Type: multipart/mixed; boundary="=-X6Q6zl7Elt+xuO4ebKzM" Organization: Novell, Inc. Date: Sun, 01 May 2005 21:24:23 -0500 Message-Id: <1115000663.444.100.camel@avarice.monx> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 X-Spam-Status: No, hits=0.0 required=5.0 tests=none version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] [PATCH] Name selector limits (again) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-X6Q6zl7Elt+xuO4ebKzM Content-Type: text/plain Content-Transfer-Encoding: 7bit I'm seeking approval for HEAD for this patch, which was not considered before 2.2 on the grounds that it breaks ABI compatibility. I also suggest we (I) change the objects to use a separate private struct so it'll be easier to change things without ABI breakage in the future. I can send a separate patch for that. I'll write a changelog entry if this is approved. -- Hans Petter Jansson | Evolution Developer | http://hp.cl.no/ --=-X6Q6zl7Elt+xuO4ebKzM Content-Disposition: attachment; filename=eds-name-selector-limit.patch Content-Type: text/x-patch; name=eds-name-selector-limit.patch; charset=us-ascii Content-Transfer-Encoding: 7bit ? libedataserverui/cachegrind.out.31380 ? libedataserverui/cachegrind.out.31397 ? libedataserverui/cachegrind.out.31411 ? libedataserverui/e-name-selector-dialog.gladep ? libedataserverui/log.diff ? libedataserverui/new ? libedataserverui/old ? libedataserverui/out.diff ? libedataserverui/test-camel-address ? libedataserverui/test-camel-address.c ? libedataserverui/test-contact-store ? libedataserverui/test-name-selector Index: libedataserverui/e-destination-store.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-destination-store.c,v retrieving revision 1.4 diff -u -p -r1.4 e-destination-store.c --- libedataserverui/e-destination-store.c 3 Feb 2005 16:35:02 -0000 1.4 +++ libedataserverui/e-destination-store.c 25 Feb 2005 03:12:23 -0000 @@ -153,6 +153,7 @@ e_destination_store_tree_model_init (Gtk static void e_destination_store_init (EDestinationStore *destination_store) { + destination_store->accept_many = TRUE; destination_store->stamp = g_random_int (); destination_store->destinations = g_ptr_array_new (); } @@ -276,6 +277,38 @@ destination_changed (EDestinationStore * * EDestinationStore API * * --------------------- */ +gboolean +e_destination_store_get_accept_many (EDestinationStore *destination_store) +{ + g_return_val_if_fail (E_IS_DESTINATION_STORE (destination_store), FALSE); + + return destination_store->accept_many ? TRUE : FALSE; +} + +void +e_destination_store_set_accept_many (EDestinationStore *destination_store, gboolean accept_many) +{ + g_return_if_fail (E_IS_DESTINATION_STORE (destination_store)); + + if (destination_store->accept_many && !accept_many) { + GList *destinations; + GList *l; + + destinations = e_destination_store_list_destinations (destination_store); + + /* Leave the first destination alone */ + for (l = destinations; l && (l = g_list_next (l)); ) { + EDestination *destination = l->data; + + e_destination_store_remove_destination (destination_store, destination); + } + + g_list_free (destinations); + } + + destination_store->accept_many = accept_many; +} + EDestination * e_destination_store_get_destination (EDestinationStore *destination_store, GtkTreeIter *iter) { @@ -289,6 +322,14 @@ e_destination_store_get_destination (EDe return g_ptr_array_index (destination_store->destinations, index); } +gint +e_destination_store_get_n_destinations (EDestinationStore *destination_store) +{ + g_return_val_if_fail (E_IS_DESTINATION_STORE (destination_store), -1); + + return destination_store->destinations->len; +} + GList * e_destination_store_list_destinations (EDestinationStore *destination_store) { @@ -339,6 +380,11 @@ void e_destination_store_append_destination (EDestinationStore *destination_store, EDestination *destination) { g_return_if_fail (E_IS_DESTINATION_STORE (destination_store)); + + if (destination_store->destinations->len > 0 && !destination_store->accept_many) { + g_warning ("Tried to add multiple destinations to single-destination EDestinationStore!"); + return; + } if (find_destination_by_pointer (destination_store, destination) >= 0) { g_warning ("Same destination added more than once to EDestinationStore!"); Index: libedataserverui/e-destination-store.h =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-destination-store.h,v retrieving revision 1.2 diff -u -p -r1.2 e-destination-store.h --- libedataserverui/e-destination-store.h 20 Dec 2004 11:21:01 -0000 1.2 +++ libedataserverui/e-destination-store.h 25 Feb 2005 03:12:23 -0000 @@ -43,6 +43,8 @@ struct EDestinationStore { /* Private */ + guint accept_many : 1; + gint stamp; GPtrArray *destinations; }; @@ -63,6 +65,12 @@ EDestinationStoreColumnType; GtkType e_destination_store_get_type (void); EDestinationStore *e_destination_store_new (void); + +gboolean e_destination_store_get_accept_many (EDestinationStore *destination_store); +void e_destination_store_set_accept_many (EDestinationStore *destination_store, + gboolean accept_many); + +gint e_destination_store_get_n_destinations (EDestinationStore *destination_store); EDestination *e_destination_store_get_destination (EDestinationStore *destination_store, GtkTreeIter *iter); Index: libedataserverui/e-name-selector-dialog.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-name-selector-dialog.c,v retrieving revision 1.11 diff -u -p -r1.11 e-name-selector-dialog.c --- libedataserverui/e-name-selector-dialog.c 23 Feb 2005 18:52:12 -0000 1.11 +++ libedataserverui/e-name-selector-dialog.c 25 Feb 2005 03:12:24 -0000 @@ -585,8 +585,23 @@ contact_selection_changed (ENameSelector have_selection = gtk_tree_selection_get_selected (contact_selection, NULL, NULL); for (i = 0; i < name_selector_dialog->sections->len; i++) { - Section *section = &g_array_index (name_selector_dialog->sections, Section, i); - gtk_widget_set_sensitive (GTK_WIDGET (section->transfer_button), have_selection); + Section *section = &g_array_index (name_selector_dialog->sections, Section, i); + EDestinationStore *destination_store; + gboolean allow_add; + + if (!e_name_selector_model_peek_section (name_selector_dialog->name_selector_model, + section->name, NULL, &destination_store)) { + g_warning ("ENameSelectorDialog has a section unknown to the model!"); + continue; + } + + if (e_destination_store_get_accept_many (destination_store) || + e_destination_store_get_n_destinations (destination_store) == 0) + allow_add = have_selection; + else + allow_add = FALSE; + + gtk_widget_set_sensitive (GTK_WIDGET (section->transfer_button), allow_add); } } @@ -599,6 +614,7 @@ contact_activated (ENameSelectorDialog * GtkTreeIter iter; Section *section; gint email_n; + gint i; /* When a contact is activated, we transfer it to the first destination on our list */ @@ -623,10 +639,23 @@ contact_activated (ENameSelectorDialog * return; } - section = &g_array_index (name_selector_dialog->sections, Section, 0); - if (!e_name_selector_model_peek_section (name_selector_dialog->name_selector_model, - section->name, NULL, &destination_store)) { - g_warning ("ENameSelectorDialog has a section unknown to the model!"); + /* Find the first destination store that can accept a contact */ + + for (i = 0; i < name_selector_dialog->sections->len; i++) { + section = &g_array_index (name_selector_dialog->sections, Section, i); + if (!e_name_selector_model_peek_section (name_selector_dialog->name_selector_model, + section->name, NULL, &destination_store)) { + g_warning ("ENameSelectorDialog has a section unknown to the model!"); + continue; + } + + if (e_destination_store_get_accept_many (destination_store) || + e_destination_store_get_n_destinations (destination_store) == 0) + break; + } + + if (i >= name_selector_dialog->sections->len) { + /* No suitable destination store */ return; } Index: libedataserverui/e-name-selector-entry.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-name-selector-entry.c,v retrieving revision 1.15 diff -u -p -r1.15 e-name-selector-entry.c --- libedataserverui/e-name-selector-entry.c 23 Feb 2005 18:52:12 -0000 1.15 +++ libedataserverui/e-name-selector-entry.c 25 Feb 2005 03:12:24 -0000 @@ -980,6 +980,9 @@ insert_unichar (ENameSelectorEntry *name gboolean at_start = FALSE; gboolean at_end = FALSE; + if (!e_destination_store_get_accept_many (name_selector_entry->destination_store)) + return 0; + if (str_context [1] == ',' || str_context [1] == '\0') return 0; Index: libedataserverui/e-name-selector-model.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-name-selector-model.c,v retrieving revision 1.5 diff -u -p -r1.5 e-name-selector-model.c --- libedataserverui/e-name-selector-model.c 3 Feb 2005 16:35:02 -0000 1.5 +++ libedataserverui/e-name-selector-model.c 25 Feb 2005 03:12:24 -0000 @@ -63,6 +63,7 @@ G_DEFINE_TYPE (ENameSelectorModel, e_nam static void e_name_selector_model_init (ENameSelectorModel *name_selector_model) { + name_selector_model->accept_many = TRUE; name_selector_model->sections = g_array_new (FALSE, FALSE, sizeof (Section)); name_selector_model->contact_store = e_contact_store_new (); @@ -335,6 +336,23 @@ find_section_by_name (ENameSelectorModel * ENameSelectorModel API * * ---------------------- */ +void +e_name_selector_model_set_accept_many (ENameSelectorModel *name_selector_model, + gboolean accept_many) +{ + gint i; + + g_return_if_fail (E_IS_NAME_SELECTOR_MODEL (name_selector_model)); + + name_selector_model->accept_many = accept_many; + + for (i = 0; i < name_selector_model->sections->len; i++) { + Section *section = &g_array_index (name_selector_model->sections, Section, i); + + e_destination_store_set_accept_many (section->destination_store, accept_many); + } +} + EContactStore * e_name_selector_model_peek_contact_store (ENameSelectorModel *name_selector_model) { @@ -396,6 +414,9 @@ e_name_selector_model_add_section (EName section.destination_store = g_object_ref (destination_store); else section.destination_store = e_destination_store_new (); + + e_destination_store_set_accept_many (section.destination_store, + name_selector_model->accept_many); g_signal_connect_swapped (section.destination_store, "row-changed", G_CALLBACK (destinations_changed), name_selector_model); Index: libedataserverui/e-name-selector-model.h =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-name-selector-model.h,v retrieving revision 1.3 diff -u -p -r1.3 e-name-selector-model.h --- libedataserverui/e-name-selector-model.h 22 Jan 2005 09:59:42 -0000 1.3 +++ libedataserverui/e-name-selector-model.h 25 Feb 2005 03:12:24 -0000 @@ -44,6 +44,8 @@ struct ENameSelectorModel { /* Private */ + guint accept_many : 1; + GArray *sections; EContactStore *contact_store; ETreeModelGenerator *contact_filter; @@ -61,6 +63,9 @@ struct ENameSelectorModelClass { GType e_name_selector_model_get_type (void); ENameSelectorModel *e_name_selector_model_new (void); + +void e_name_selector_model_set_accept_many (ENameSelectorModel *name_selector_model, + gboolean accept_many); EContactStore *e_name_selector_model_peek_contact_store (ENameSelectorModel *name_selector_model); ETreeModelGenerator *e_name_selector_model_peek_contact_filter (ENameSelectorModel *name_selector_model); Index: libedataserverui/test-name-selector.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/libedataserverui/test-name-selector.c,v retrieving revision 1.5 diff -u -p -r1.5 test-name-selector.c --- libedataserverui/test-name-selector.c 20 Dec 2004 15:31:29 -0000 1.5 +++ libedataserverui/test-name-selector.c 25 Feb 2005 03:12:24 -0000 @@ -54,6 +54,7 @@ start_test (void) destination_store = e_destination_store_new (); name_selector_model = e_name_selector_model_new (); + e_name_selector_model_set_accept_many (name_selector_model, FALSE); e_name_selector_model_add_section (name_selector_model, "to", "To", destination_store); e_name_selector_model_add_section (name_selector_model, "cc", "Cc", NULL); e_name_selector_model_add_section (name_selector_model, "bcc", "Bcc", NULL); --=-X6Q6zl7Elt+xuO4ebKzM-- From spamfrommailing@freax.org Mon May 2 01:42:15 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 7EF6C12409C; Mon, 2 May 2005 01:42:15 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id C7DCD1240A8; Mon, 2 May 2005 01:42:03 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id 2652F1394205; Mon, 2 May 2005 11:43:01 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15119-07; Mon, 2 May 2005 11:42:53 +0200 (CEST) Received: from [192.168.0.129] (cvs.maia-scientific.com [213.193.139.10]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id 96A911394202; Mon, 2 May 2005 11:42:53 +0200 (CEST) Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix for builderror in e-utils From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: Not Zed Cc: spamfrommailing@pvanhoof.be, evolution-hackers@lists.ximian.com, Evolution Patches In-Reply-To: <1115026015.30876.16.camel@lostzed.mmc.com.au> References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> Content-Type: text/plain Date: Mon, 02 May 2005 11:42:53 +0200 Message-Id: <1115026973.9672.3.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > Hmm, why does this not build? > It is like that very speficially so that all of the profiling code can > be completely removed from the compilation, rather than just calling a > dummy function. > > Any fix should maintain this behaviour, so this one isn't suitable. As a gcc 4.0 user the line in the c-file is giving me a syntax error. In the c-file it isn't showing an incorrect syntax whatsoever. Wouldn't it then be better to wrap the entire function in the #ifdef- #endif clause and wrap the line where the function is called with it too? In which case the function isn't compiled if profiling isn't enabled. As will the calls to that function also not be compiled. -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ From evolution-hackers-admin@lists.ximian.com Mon May 2 02:04:14 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 5EA07124108; Mon, 2 May 2005 02:04:12 -0400 (EDT) Received: from executivesontheweb.com (host217-37-162-197.in-addr.btopenworld.com [217.37.162.197]) by lists.ximian.com (Postfix) with ESMTP id F3F0B1240DE; Mon, 2 May 2005 02:03:59 -0400 (EDT) Received: from mail pickup service by executivesontheweb.com with Microsoft SMTPSVC; Mon, 2 May 2005 11:15:58 +0100 thread-index: AcVO/+8j/mvkeKUlT66QibfAXOcGrw== Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix for builderrorin e-utils From: "Philip Van Hoof" Reply-To: To: Cc: , , "Evolution Patches" Message-ID: <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> In-Reply-To: <1115026015.30876.16.camel@lostzed.mmc.com.au> References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-BeenThere: evolution-hackers@lists.ximian.com Content-Class: urn:content-classes:message Importance: normal X-Mailman-Version: 2.0.13 Priority: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.181 Precedence: bulk Date: Mon, 2 May 2005 11:15:58 +0100 X-OriginalArrivalTime: 02 May 2005 10:15:58.0828 (UTC) FILETIME=[EF4BDAC0:01C54EFF] X-Spam-Status: No, hits=-30.1 required=5.0 tests=DATE_IN_FUTURE_03_06,EMAIL_ATTRIBUTION,IN_REP_TO, MISSING_OUTLOOK_NAME,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,SIGNATURE_LONG_SPARSE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > Hmm, why does this not build? > It is like that very speficially so that all of the profiling code can > be completely removed from the compilation, rather than just calling a > dummy function. > > Any fix should maintain this behaviour, so this one isn't suitable. As a gcc 4.0 user the line in the c-file is giving me a syntax error. In the c-file it isn't showing an incorrect syntax whatsoever. Wouldn't it then be better to wrap the entire function in the #ifdef- #endif clause and wrap the line where the function is called with it too? In which case the function isn't compiled if profiling isn't enabled. As will the calls to that function also not be compiled. -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ _______________________________________________ evolution-hackers maillist - evolution-hackers@lists.ximian.com http://lists.ximian.com/mailman/listinfo/evolution-hackers From rodo@novell.com Mon May 2 03:21:45 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id D82D01240B6; Mon, 2 May 2005 03:21:44 -0400 (EDT) Received: from skeptopotamus.ximian.com (skeptopotamus.ximian.com [130.57.169.16]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "mail.cam.novell.com", Issuer "Equifax Secure Global eBusiness CA-1" (not verified)) by lists.ximian.com (Postfix) with ESMTP id AAB4F124127 for ; Mon, 2 May 2005 03:21:33 -0400 (EDT) Received: by skeptopotamus.ximian.com (Postfix) id B83CE632D2; Mon, 2 May 2005 07:19:04 -0400 (EDT) Delivered-To: evolution-patches@ximian.com Received: from jericho.provo.novell.com (jericho.provo.novell.com [137.65.81.173]) by skeptopotamus.ximian.com (Postfix) with ESMTP id 893F4632D1 for ; Mon, 2 May 2005 07:19:04 -0400 (EDT) Received: from [164.99.152.100] ([164.99.152.100]) by jericho.provo.novell.com; Mon, 02 May 2005 05:18:53 -0600 From: Radek Doulik To: Rodney Dawes Cc: Patches , Rodrigo Moya In-Reply-To: <1114799930.28158.5.camel@blackbox.cam.novell.com> References: <1114757232.27883.2.camel@localhost.localdomain> <1114799930.28158.5.camel@blackbox.cam.novell.com> Content-Type: text/plain Date: Mon, 02 May 2005 16:46:19 +0530 Message-Id: <1115032579.8122.15.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-9.9 required=5.0 tests=IN_REP_TO,REFERENCES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Re: [gtkhtml] another leak fix Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: committed From alessandro@nnva.org Mon May 2 05:23:18 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id AA1CE1241BC; Mon, 2 May 2005 05:23:18 -0400 (EDT) Received: from mail.sadlands.org (host66-185.pool82191.interbusiness.it [82.191.185.66]) by lists.ximian.com (Postfix) with SMTP id 9D2B61241AF for ; Mon, 2 May 2005 05:23:10 -0400 (EDT) Received: (qmail 30271 invoked from network); 2 May 2005 13:18:50 -0000 Received: from unknown (HELO ?192.168.1.13?) (alessandro@nnva.org@81.75.183.128) by 217.59.188.234 with SMTP; 2 May 2005 13:18:50 -0000 From: Alessandro Decina To: evolution-patches Content-Type: multipart/mixed; boundary="=-b+Dwi7BKKztxBP0k2vWI" Organization: NNVA Date: Mon, 02 May 2005 15:23:14 +0200 Message-Id: <1115040194.5430.7.camel@homeless.home.sadlands.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 X-Spam-Status: No, hits=-6.0 required=5.0 tests=PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] fix usenet folder flags Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-b+Dwi7BKKztxBP0k2vWI Content-Type: text/plain Content-Transfer-Encoding: 7bit Hello, one-line patch to fix usenet folder flags. I noticed this bug since the folder subscriptions dialog always displays all the folders as unsubscribed for usenet accounts. Bye -- Alessandro Decina NNVA --=-b+Dwi7BKKztxBP0k2vWI Content-Description: Content-Disposition: attachment; filename=camel-nntp-store-fixflags.diff Content-Type: text/x-patch; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Index: camel/providers/nntp/ChangeLog =================================================================== RCS file: /cvs/gnome/evolution-data-server/camel/providers/nntp/ChangeLog,v retrieving revision 1.2 diff -u -p -r1.2 ChangeLog --- camel/providers/nntp/ChangeLog 22 Apr 2005 02:57:50 -0000 1.2 +++ camel/providers/nntp/ChangeLog 30 Apr 2005 10:02:54 -0000 @@ -1,3 +1,8 @@ +2005-04-30 Alessandro Decina + + * camel-nntp-store.c (nntp_folder_info_from_store_info): Copy the + flags field when converting from CamelStoreInfo to CamelFolderInfo. + 2005-04-22 Not Zed * camel-nntp-store.c (nntp_store_get_folder_info_all): don't set Index: camel/providers/nntp/camel-nntp-store.c =================================================================== RCS file: /cvs/gnome/evolution-data-server/camel/providers/nntp/camel-nntp-store.c,v retrieving revision 1.79 diff -u -p -r1.79 camel-nntp-store.c --- camel/providers/nntp/camel-nntp-store.c 22 Apr 2005 02:57:50 -0000 1.79 +++ camel/providers/nntp/camel-nntp-store.c 30 Apr 2005 10:02:55 -0000 @@ -498,6 +498,7 @@ nntp_folder_info_from_store_info (CamelN fi->unread = si->unread; fi->total = si->total; + fi->flags = si->flags; path = alloca(strlen(fi->full_name)+2); sprintf(path, "/%s", fi->full_name); url = camel_url_new_with_base (base_url, path); --=-b+Dwi7BKKztxBP0k2vWI-- From pchenthill@novell.com Mon May 2 07:35:37 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 58976124208; Mon, 2 May 2005 07:35:37 -0400 (EDT) Received: from nanclus.provo.novell.com (nanclus.provo.novell.com [137.65.81.53]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "nanclus.provo.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id DCEB012416B for ; Mon, 2 May 2005 07:35:24 -0400 (EDT) Received: from PROVO4-MTA by nanclus.provo.novell.com with Novell_GroupWise; Mon, 02 May 2005 09:36:24 -0600 Message-Id: <427610B30200000C000265B6@nanclus.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 6.7 Beta Date: Mon, 02 May 2005 09:36:19 -0600 From: "P Chenthill" To: Cc: Subject: Re: [evolution-patches] fix for the bug #274406 [calendar] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Spam-Status: No, hits=-9.7 required=5.0 tests=EMAIL_ATTRIBUTION,QUOTED_EMAIL_TEXT version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Wed, 2005-04-27 at 09:34 +0000, Rodrigo Moya wrote: > On Wed, 2005-04-27 at 08:15 +0530, chenthill wrote: > > This occurs if the status of the received in cal_opened_cb is not OK. = So > > i think we can then remove the extra unref present there. This causes > > the problem. As soon as the signal is emitted the cal_opened_cb is > > called which does an additional unref and thus causes a crash in > > async_signal_idle_cb. Have attached the modified patch. > >=20 > right, this one looks ok. The extra _unref call was not needed, since we > are creating the hash table with g_hash_table_new_full, which means > g_object_unref is called when you remove an item from the hash table. >=20 > I guess this should go to both HEAD and 2.2 branch. Committed to gnome-2-10 branch and head. thanks, chenthill. From spamfrommailing@freax.org Mon May 2 11:23:52 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 3A4F912403A; Mon, 2 May 2005 11:23:52 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 42163124273 for ; Mon, 2 May 2005 11:23:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id 94EBE139420B; Mon, 2 May 2005 21:24:38 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25638-08; Mon, 2 May 2005 21:24:31 +0200 (CEST) Received: from lort (dD576CB7F.access.telenet.be [213.118.203.127]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id 208291394202; Mon, 2 May 2005 21:24:31 +0200 (CEST) Subject: Re: [evolution-patches] Some generated files that are in CVS From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: Rodney Dawes , Rodrigo Moya Cc: spamfrommailing@pvanhoof.be, Evolution Patches In-Reply-To: <1114613505.20422.0.camel@cerler.home> References: <1114613024.1502.98.camel@localhost.localdomain> <1114613505.20422.0.camel@cerler.home> Content-Type: text/plain Date: Mon, 02 May 2005 21:24:29 +0200 Message-Id: <1115061869.8671.6.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: I still need approval for this one ;-) On Wed, 2005-04-27 at 16:51 +0200, Rodrigo Moya wrote: > On Wed, 2005-04-27 at 16:43 +0200, Philip Van Hoof wrote: > > > > This patch adds some files to some .cvsignore files. > > > > They should also be cvs rm'ed > > > > Can somebody approve this action? I'll commit the .cvsignore files and > > cvs rm the INSTALL and by-bison created .h files > > > this looks good to me, although please wait for Rodney's approval, since > he'll know if this affects the builds somewhat. -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ From spamfrommailing@freax.org Mon May 2 11:35:45 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 4E65912427A; Mon, 2 May 2005 11:35:45 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 8ADF812425C for ; Mon, 2 May 2005 11:35:33 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id AD051139420B for ; Mon, 2 May 2005 21:36:32 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25826-05 for ; Mon, 2 May 2005 21:36:25 +0200 (CEST) Received: from lort (dD576CB7F.access.telenet.be [213.118.203.127]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id EE25B1394202 for ; Mon, 2 May 2005 21:36:24 +0200 (CEST) From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: Evolution Patches Content-Type: multipart/mixed; boundary="=-7SfBsDD8CTJJPKXPDBdg" Date: Mon, 02 May 2005 21:36:23 +0200 Message-Id: <1115062584.8671.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-4.7 required=5.0 tests=HTML_00_10,HTML_MESSAGE,PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] This patch removes some compiler warnings (on gcc 4.0) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-7SfBsDD8CTJJPKXPDBdg Content-Type: multipart/alternative; boundary="=-aIY4ie6sj+o4idkAMcLD" --=-aIY4ie6sj+o4idkAMcLD Content-Type: text/plain Content-Transfer-Encoding: 7bit Mainly (xmlChar*) casting for libxml . . . -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-aIY4ie6sj+o4idkAMcLD Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Mainly (xmlChar*) casting for libxml  . . .


-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-aIY4ie6sj+o4idkAMcLD-- --=-7SfBsDD8CTJJPKXPDBdg Content-Disposition: attachment; filename=evo_gcc4_compiler_warnings_calendar_gui.diff Content-Type: text/x-patch; name=evo_gcc4_compiler_warnings_calendar_gui.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: e-pub-utils.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-pub-utils.c,v retrieving revision 1.7 diff -u -r1.7 e-pub-utils.c --- e-pub-utils.c 23 Feb 2005 18:56:56 -0000 1.7 +++ e-pub-utils.c 2 May 2005 19:33:43 -0000 @@ -44,39 +44,39 @@ GSList *l = NULL; uri->location = NULL; - doc = xmlParseDoc ((char *)xml); + doc = xmlParseDoc ((xmlChar *)xml); if (doc == NULL) { uri->location = NULL; return; } root = doc->children; - if (strcmp (root->name, "uri") != 0) { + if (strcmp ((const char*)root->name, "uri") != 0) { return; } - location = xmlGetProp (root, "location"); - enabled = xmlGetProp (root, "enabled"); - frequency = xmlGetProp (root, "frequency"); - username = xmlGetProp (root, "username"); - publish_time = xmlGetProp (root, "publish_time"); + location = xmlGetProp (root, (xmlChar*)"location"); + enabled = xmlGetProp (root, (xmlChar*)"enabled"); + frequency = xmlGetProp (root, (xmlChar*)"frequency"); + username = xmlGetProp (root, (xmlChar*)"username"); + publish_time = xmlGetProp (root, (xmlChar*)"publish_time"); if (location != NULL) - uri->location = g_strdup (location); + uri->location = g_strdup ((const gchar*)location); if (enabled != NULL) - uri->enabled = atoi (enabled); + uri->enabled = atoi ((const char*)enabled); if (frequency != NULL) - uri->publish_freq = atoi (frequency); + uri->publish_freq = atoi ((const char*)frequency); if (username != NULL) - uri->username = g_strdup (username); + uri->username = g_strdup ((const gchar*)username); if (publish_time != NULL) - uri->last_pub_time = g_strdup (publish_time); + uri->last_pub_time = g_strdup ((const gchar*)publish_time); uri->password = g_strdup (""); for (p = root->children; p != NULL; p = p->next) { - xmlChar *uid = xmlGetProp (p, "uid"); + xmlChar *uid = xmlGetProp (p, (xmlChar*)"uid"); - l = g_slist_append (l, uid); + l = g_slist_append (l, (xmlChar*)uid); } uri->calendars = l; @@ -100,22 +100,22 @@ g_return_val_if_fail (uri != NULL, NULL); g_return_val_if_fail (uri->location != NULL, NULL); - doc = xmlNewDoc ("1.0"); + doc = xmlNewDoc ((xmlChar*)"1.0"); - root = xmlNewDocNode (doc, NULL, "uri", NULL); + root = xmlNewDocNode (doc, NULL, (xmlChar*)"uri", NULL); enabled = g_strdup_printf ("%d", uri->enabled); frequency = g_strdup_printf ("%d", uri->publish_freq); - xmlSetProp (root, "location", uri->location); - xmlSetProp (root, "enabled", enabled); - xmlSetProp (root, "frequency", frequency); - xmlSetProp (root, "username", uri->username); - xmlSetProp (root, "publish_time", uri->last_pub_time); + xmlSetProp (root, (xmlChar*)"location", (xmlChar*)uri->location); + xmlSetProp (root, (xmlChar*)"enabled", (xmlChar*)enabled); + xmlSetProp (root, (xmlChar*)"frequency", (xmlChar*)frequency); + xmlSetProp (root, (xmlChar*)"username", (xmlChar*)uri->username); + xmlSetProp (root, (xmlChar*)"publish_time", (xmlChar*)uri->last_pub_time); for (cals = uri->calendars; cals != NULL; cals = cals->next) { xmlNodePtr node; - node = xmlNewChild (root, NULL, "source", NULL); - xmlSetProp (node, "uid", cals->data); + node = xmlNewChild (root, NULL, (xmlChar*)"source", NULL); + xmlSetProp (node, (xmlChar*)"uid", cals->data); } xmlDocSetRootElement (doc, root); --=-7SfBsDD8CTJJPKXPDBdg-- From spamfrommailing@freax.org Mon May 2 12:06:06 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id A90FA1242FB; Mon, 2 May 2005 12:06:06 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 21D301242EC for ; Mon, 2 May 2005 12:05:54 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id 4B565139420B; Mon, 2 May 2005 22:06:51 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26816-07; Mon, 2 May 2005 22:06:43 +0200 (CEST) Received: from lort (dD576CB7F.access.telenet.be [213.118.203.127]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id 4656E139420D; Mon, 2 May 2005 22:06:42 +0200 (CEST) Subject: Re: [evolution-patches] This patch removes some compiler warnings (on gcc 4.0) From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: spamfrommailing@pvanhoof.be Cc: Evolution Patches In-Reply-To: <1115062584.8671.9.camel@localhost.localdomain> References: <1115062584.8671.9.camel@localhost.localdomain> Content-Type: multipart/mixed; boundary="=-PiZ1avZXUF61W0BmJ5dd" Date: Mon, 02 May 2005 22:06:41 +0200 Message-Id: <1115064401.8671.12.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-27.6 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_00_10,HTML_MESSAGE,IN_REP_TO, PATCH_UNIFIED_DIFF,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-PiZ1avZXUF61W0BmJ5dd Content-Type: multipart/alternative; boundary="=-kvBVxXAoAdzjbbCgKFxu" --=-kvBVxXAoAdzjbbCgKFxu Content-Type: text/plain Content-Transfer-Encoding: 7bit More compiler-warning fixes in the same directory ... btw: this one worries me: e_calendar_view_edit_appointment (cal_view, event->comp_data->client, event->comp_data->icalcomp, icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY)); The 4th argument of e_calendar_view_edit_appointment is a boolean. icalcomponent_get_first_property is returning a icalproperty pointer. (checkout my patch to see if what it should do is indeed correctly interpreted by me). On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote: > Mainly (xmlChar*) casting for libxml . . . > > > -- > Philip Van Hoof, Software Developer @ Cronos > home: me at pvanhoof dot be > gnome: pvanhoof at gnome dot org > work: philip dot vanhoof at cronos dot be > junk: philip dot vanhoof at gmail dot com > http://www.pvanhoof.be/ -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-kvBVxXAoAdzjbbCgKFxu Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
More compiler-warning fixes in the same directory ...


btw: this one worries me:

e_calendar_view_edit_appointment (cal_view, event->comp_data->client,
                                                     event->comp_data->icalcomp,
                                                    icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY));


The 4th argument of e_calendar_view_edit_appointment is a boolean. icalcomponent_get_first_property is returning a icalproperty pointer. (checkout my patch to see if what it should do is indeed correctly interpreted by me).


On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote:
Mainly (xmlChar*) casting for libxml  . . .


-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-kvBVxXAoAdzjbbCgKFxu-- --=-PiZ1avZXUF61W0BmJ5dd Content-Disposition: attachment; filename=evo_compiler_warnings_calendar_gui.diff Content-Type: text/x-patch; name=evo_compiler_warnings_calendar_gui.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: e-calendar-table.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-calendar-table.c,v retrieving revision 1.132 diff -u -r1.132 e-calendar-table.c --- e-calendar-table.c 25 Jan 2005 11:18:16 -0000 1.132 +++ e-calendar-table.c 2 May 2005 20:03:47 -0000 @@ -511,7 +511,7 @@ g_signal_connect (e_table, "key_press", G_CALLBACK (e_calendar_table_on_key_press), cal_table); g_signal_connect (e_table, "popup_menu", G_CALLBACK (e_calendar_table_on_popup_menu), cal_table); - a11y = gtk_widget_get_accessible (e_table); + a11y = gtk_widget_get_accessible (GTK_WIDGET(e_table)); if (a11y) atk_object_set_name (a11y, _("Task Table")); } Index: e-calendar-view.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-calendar-view.c,v retrieving revision 1.79 diff -u -r1.79 e-calendar-view.c --- e-calendar-view.c 18 Apr 2005 14:21:33 -0000 1.79 +++ e-calendar-view.c 2 May 2005 20:03:50 -0000 @@ -1008,10 +1008,14 @@ ECalendarViewEvent *event = (ECalendarViewEvent *) selected->data; if (event) + { + icalproperty *prop = icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY); + gboolean val = prop ? TRUE:FALSE; e_calendar_view_edit_appointment (cal_view, event->comp_data->client, event->comp_data->icalcomp, - icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY)); - + val); + } + g_list_free (selected); } } @@ -1169,7 +1173,7 @@ return; /* prompt the user for destination source */ - destination_source = select_source_dialog ((GtkWindow *) gtk_widget_get_toplevel (cal_view), E_CAL_SOURCE_TYPE_EVENT); + destination_source = select_source_dialog ((GtkWindow *) gtk_widget_get_toplevel (GTK_WIDGET(cal_view)), E_CAL_SOURCE_TYPE_EVENT); if (!destination_source) return; @@ -1493,9 +1497,14 @@ if (selected) { ECalendarViewEvent *event = (ECalendarViewEvent *) selected->data; if (event) + { + icalproperty *prop = icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY); + gboolean val = prop?TRUE:FALSE; + e_calendar_view_edit_appointment (cal_view, event->comp_data->client, - event->comp_data->icalcomp, icalcomponent_get_first_property(event->comp_data->icalcomp, ICAL_ATTENDEE_PROPERTY)); - + event->comp_data->icalcomp, val); + } + g_list_free (selected); } } Index: e-day-view.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-day-view.c,v retrieving revision 1.270 diff -u -r1.270 e-day-view.c --- e-day-view.c 21 Mar 2005 14:29:16 -0000 1.270 +++ e-day-view.c 2 May 2005 20:04:00 -0000 @@ -361,7 +361,8 @@ gboolean scroll_up); static gboolean e_day_view_auto_scroll_handler (gpointer data); -static EDayViewEvent* e_day_view_get_popup_menu_event (EDayView *day_view); +/* +static EDayViewEvent* e_day_view_get_popup_menu_event (EDayView *day_view);*/ static gboolean e_day_view_on_top_canvas_drag_motion (GtkWidget *widget, GdkDragContext *context, @@ -419,10 +420,12 @@ guint time, EDayView *day_view); +/* static gboolean e_day_view_update_event_cb (EDayView *day_view, gint day, gint event_num, - gpointer data); + gpointer data);*/ + static gboolean e_day_view_remove_event_cb (EDayView *day_view, gint day, gint event_num, @@ -507,8 +510,6 @@ static void process_component (EDayView *day_view, ECalModelComponent *comp_data) { - EDayViewEvent *event; - gint day, event_num; const char *uid, *rid; ECalComponent *comp; AddEventData add_event_data; @@ -1076,8 +1077,6 @@ { EDayView *day_view; GdkColormap *colormap; - gboolean success[E_DAY_VIEW_COLOR_LAST]; - gint nfailed; if (GTK_WIDGET_CLASS (e_day_view_parent_class)->realize) (*GTK_WIDGET_CLASS (e_day_view_parent_class)->realize)(widget); @@ -1161,6 +1160,11 @@ day_view->colors[E_DAY_VIEW_COLOR_EVENT_BORDER] = widget->style->dark[GTK_STATE_NORMAL]; day_view->colors[E_DAY_VIEW_COLOR_LONG_EVENT_BACKGROUND] = widget->style->bg[GTK_STATE_ACTIVE]; day_view->colors[E_DAY_VIEW_COLOR_LONG_EVENT_BORDER] = widget->style->dark[GTK_STATE_NORMAL]; + + /* Shouldn't this use some standard GTK colors? */ + day_view->colors[E_DAY_VIEW_COLOR_MARCUS_BAINS_LINE].red = 65535; + day_view->colors[E_DAY_VIEW_COLOR_MARCUS_BAINS_LINE].green = 0; + day_view->colors[E_DAY_VIEW_COLOR_MARCUS_BAINS_LINE].blue = 0; } static void @@ -1576,6 +1580,7 @@ return FALSE; } +/* Unused?! static gboolean e_day_view_update_event_cb (EDayView *day_view, gint day, @@ -1614,7 +1619,7 @@ return TRUE; } - +*/ /* This calls a given function for each event instance (in both views). If the callback returns FALSE the iteration is stopped. @@ -2468,6 +2473,28 @@ gtk_widget_queue_draw (day_view->main_canvas); } + +/* Whether we display the Marcus Bains Line in the main canvas and time canvas. */ +gboolean +e_day_view_get_show_marcus_bains_line (EDayView *day_view) +{ + g_return_val_if_fail (E_IS_DAY_VIEW (day_view), TRUE); + return day_view->show_marcus_bains_line; +} + +void +e_day_view_set_show_marcus_bains_line (EDayView *day_view, + gboolean show) +{ + g_return_if_fail (E_IS_DAY_VIEW (day_view)); + + if (day_view->show_marcus_bains_line != show) { + day_view->show_marcus_bains_line = show; + e_day_view_update_marcus_bains(day_view); + } +} + + /* Whether we display event end times in the main canvas. */ gboolean e_day_view_get_show_event_end_times (EDayView *day_view) @@ -3319,6 +3346,7 @@ day, event_num); } +/* Unused?! static EDayViewEvent* e_day_view_get_popup_menu_event (EDayView *day_view) { @@ -3334,7 +3362,7 @@ EDayViewEvent, day_view->popup_event_num); } - +*/ static gboolean e_day_view_on_top_canvas_button_release (GtkWidget *widget, @@ -3394,7 +3422,6 @@ e_day_view_update_calendar_selection_time (EDayView *day_view) { time_t start, end; - GnomeCalendar *calendar; e_day_view_get_selected_time_range ((ECalendarView *) day_view, &start, &end); @@ -4153,7 +4180,7 @@ e_day_view_layout_day_events (day_view->events[day], day_view->rows, day_view->mins_per_row, - day_view->cols_per_row[day]); + (gint8*)day_view->cols_per_row[day]); if (day_view->need_layout[day] || day_view->need_reshape[day]) { @@ -7004,7 +7031,7 @@ comp_str = icalcomponent_as_ical_string (vcal); if (comp_str) { gtk_selection_data_set (selection_data, selection_data->target, - 8, comp_str, strlen (comp_str)); + 8, (const guchar*)comp_str, strlen (comp_str)); } icalcomponent_free (vcal); @@ -7501,5 +7528,3 @@ return (day_view->editing_event_day != -1) ? 1 : 0; } - - Index: e-itip-control.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-itip-control.c,v retrieving revision 1.165 diff -u -r1.165 e-itip-control.c --- e-itip-control.c 8 Jan 2005 10:53:52 -0000 1.165 +++ e-itip-control.c 2 May 2005 20:04:03 -0000 @@ -19,7 +19,7 @@ * * Author: JP Rosevear */ - + #ifdef HAVE_CONFIG_H #include #endif @@ -361,8 +361,9 @@ } static void -cleanup_ecal (ECal *ecal) +cleanup_ecal (gpointer user_data) { + ECal *ecal = user_data; /* Clean up any signals */ g_signal_handlers_disconnect_matched (ecal, G_SIGNAL_MATCH_FUNC, 0, 0, NULL, cal_opened_cb, NULL); g_signal_handlers_disconnect_matched (ecal, G_SIGNAL_MATCH_FUNC, 0, 0, NULL, find_cal_opened_cb, NULL); @@ -1986,6 +1987,7 @@ gnome_dialog_run_and_close (GNOME_DIALOG (dialog)); } +/* Unused ?! static void remove_item (EItipControl *itip) { @@ -1996,7 +1998,7 @@ priv = itip->priv; - /* FIXME Is this check necessary? */ + /-* FIXME Is this check necessary? *-/ if (!priv->current_ecal) return; @@ -2011,6 +2013,8 @@ g_clear_error (&error); } +*/ + static void send_item (EItipControl *itip) @@ -2094,7 +2098,7 @@ } while ((len = read (fd, buffer, 4096)) > 0) { - gtk_html_write (html, handle, buffer, len); + gtk_html_write (html, handle, (const gchar*)buffer, len); } if (len < 0) { Index: e-meeting-store.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/e-meeting-store.c,v retrieving revision 1.10 diff -u -r1.10 e-meeting-store.c --- e-meeting-store.c 22 Dec 2004 20:02:26 -0000 1.10 +++ e-meeting-store.c 2 May 2005 20:04:04 -0000 @@ -516,7 +516,7 @@ break; } } - +/* Unused !? static gboolean is_cell_editable (EMeetingStore *etm, int col, int row) { @@ -551,6 +551,7 @@ return TRUE; } +*/ static void refresh_queue_remove (EMeetingStore *store, EMeetingAttendee *attendee) @@ -989,8 +990,9 @@ /* Process the callbacks in the main thread. Avoids widget redrawing issues. */ static gboolean -process_callbacks_main_thread (EMeetingStore *store) +process_callbacks_main_thread (gpointer user_data) { + EMeetingStore *store = user_data; EMeetingStorePrivate *priv; QueueCbData *aqueue_data; gboolean threads_done = FALSE; @@ -1434,7 +1436,8 @@ g_ptr_array_add (qdata->call_backs, call_back); g_ptr_array_add (qdata->data, data); - g_hash_table_insert (priv->refresh_data, itip_strip_mailto (e_meeting_attendee_get_address (attendee)), qdata); + + g_hash_table_insert (priv->refresh_data, (gpointer)itip_strip_mailto (e_meeting_attendee_get_address (attendee)), qdata); } else { if (e_meeting_time_compare_times (start, &qdata->start) == -1) qdata->start = *start; --=-PiZ1avZXUF61W0BmJ5dd-- From rodrigo@novell.com Mon May 2 19:56:13 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 1E6AC1242FD; Mon, 2 May 2005 19:56:13 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id AD7671240F3 for ; Mon, 2 May 2005 19:56:01 -0400 (EDT) Received: (qmail 11793 invoked from network); 3 May 2005 03:56:59 -0000 Received: from localhost (HELO ?164.99.152.137?) (127.0.0.1) by localhost with SMTP; 3 May 2005 03:56:59 -0000 Subject: Re: [evolution-patches] Patch for bug # 274402 {evolution-calender component) From: Rodrigo Moya To: MANOJ T V Cc: pchenthill@novell.com, evolution-patches@lists.ximian.com In-Reply-To: <9979b0e6050502015153a765f4@mail.gmail.com> References: <9979b0e6050502015153a765f4@mail.gmail.com> Content-Type: text/plain Date: Tue, 03 May 2005 05:55:41 +0200 Message-Id: <1115092541.3580.17.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-22.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Mon, 2005-05-02 at 01:51 -0700, MANOJ T V wrote: > hello, > im sending patch on bug # 274402 . > pls review this patch > as we talked yesterday on IRC, I think you just want to use the GTK_WIDGET_SET_FLAGS macro, with the GtkWidgetFlags enum, to enable/disable the focus on the widgets when the calendar is read-only, all in sensitize_widgets. -- Rodrigo Moya From jpr@novell.com Mon May 2 20:30:35 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id E07AD1240C3; Mon, 2 May 2005 20:30:35 -0400 (EDT) Received: from lyle.provo.novell.com (lyle.provo.novell.com [137.65.81.174]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "imap.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id F340D124085 for ; Mon, 2 May 2005 20:30:23 -0400 (EDT) Received: from bishop.blr.novell.com ([137.65.81.216]) by lyle.provo.novell.com; Mon, 02 May 2005 22:31:23 -0600 Subject: Re: [evolution-patches] Patch for shell/Makefile.am and e-shell.c From: JP Rosevear To: Ulrich Neumann Cc: evolution-patches@lists.ximian.com In-Reply-To: References: Content-Type: text/plain Organization: Novell, Inc. Date: Tue, 03 May 2005 10:01:06 +0530 Message-Id: <1115094666.24243.48.camel@bishop.rosevear.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Sat, 2005-04-30 at 17:24 -0400, Ulrich Neumann wrote: > Hello, > > first, i'm new to the evoltion hackers, but I hope that I can > contribute to this project in the futre. > I hope nobody worries if I ask "stupid" questions at the beginning or > submit patches that are not > perfect. > > However. > I've found that after the changes JP has made to /shell/Makefile.am > and /shell/e-shell.c Evolution > can't be build any more. > > Attached are two patches that "finish" the removals. Hmm, are you on anonymous cvs (one thats out of sync)? These cleanups were included in my commits on 4/29. -JP -- JP Rosevear Novell, Inc. From rodrigo@novell.com Mon May 2 21:17:11 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 7A69F124430; Mon, 2 May 2005 21:17:11 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 88D05124419 for ; Mon, 2 May 2005 21:16:59 -0400 (EDT) Received: (qmail 11946 invoked from network); 3 May 2005 05:17:59 -0000 Received: from localhost (HELO ?164.99.152.137?) (127.0.0.1) by localhost with SMTP; 3 May 2005 05:17:59 -0000 Subject: Re: [evolution-patches] fix for bug 273983 From: Rodrigo Moya To: Andre Klapper Cc: Evolution Patches In-Reply-To: <1114717753.7503.3.camel@embrace.local> References: <1114717753.7503.3.camel@embrace.local> Content-Type: text/plain Date: Tue, 03 May 2005 07:17:00 +0200 Message-Id: <1115097420.3580.52.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Thu, 2005-04-28 at 21:49 +0200, Andre Klapper wrote: > hi all, > > this patch fixes bug 273983 and should go into HEAD for 2.3. > please commit since i do not have cvs write access. > looks good, but as you say, only for HEAD. -- Rodrigo Moya From un@gwava.com Tue May 3 02:09:09 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 2AF5F1243D1; Tue, 3 May 2005 02:09:09 -0400 (EDT) Received: from BEG1.beginfinite.com (unknown [216.18.123.34]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "BEG1.beginfinite.com", Issuer "BEGINFINITETREE" (not verified)) by lists.ximian.com (Postfix) with ESMTP id AB89412446C for ; Tue, 3 May 2005 02:08:55 -0400 (EDT) Received: from beg2dom-MTA by BEG1.beginfinite.com with Novell_GroupWise; Tue, 03 May 2005 06:12:54 -0400 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Date: Tue, 03 May 2005 06:08:02 -0400 From: "Ulrich Neumann" To: Subject: Re: [evolution-patches] Patch for shell/Makefile.am and e-shell.c Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=__Part82A1BA92.0__=" X-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_20_30,HTML_MESSAGE,MSG_ID_ADDED_BY_MTA_3 version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__Part82A1BA92.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Yes,, i've used anon cvs to get the code.=20 =20 Now I see that there are changes from may 2nd that solve the issues.=20 =20 Uli >>>JP Rosevear 05/03/05 6:31 am >>> On Sat, 2005-04-30 at 17:24 -0400, Ulrich Neumann wrote: >Hello, >=20 >first, i'm new to the evoltion hackers, but I hope that I can >contribute to this project in the futre. >I hope nobody worries if I ask stupid questions at the beginning or >submit patches that are not >perfect. >=20 >However. >I've found that after the changes JP has made to /shell/Makefile.am >and /shell/e-shell.c Evolution >can't be build any more. >=20 >Attached are two patches that finish the removals. Hmm, are you on anonymous cvs (one thats out of sync)? These cleanups were included in my commits on 4/29. -JP -- JP Rosevear Novell, Inc. evolution-patches mailing list evolution-patches@lists.ximian.com http://lists.ximian.com/mailman/listinfo/evolution-patches --=__Part82A1BA92.0__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Yes,, i've used anon cvs to get the code.
 
Now I see that there are changes from may 2nd that solve the = issues.
 
Uli

>>>JP Rosevear <jpr@novell.com> = 05/03/05 6:31 am >>>
On Sat, 2005-04-30 at 17:24 -0400,= Ulrich Neumann wrote:
>Hello,
> 
>first, = i'm new to the evoltion hackers, but I hope that I can
>contr= ibute to this project in the futre.
>I hope nobody worries if I ask = "stupid" questions at the beginning or
>submit patches = that are not
>perfect.
> 
>However.
>I've = found that after the changes JP has made to /shell/Makefile.am
>and = /shell/e-shell.c Evolution
>can't be build any more.
> = ;
>Attached are two patches that "finish" the removals.
=
Hmm, are you on anonymous cvs (one thats out of sync)?&= #160; These cleanups
were included in my commits on 4/29.

-J= P
--
JP Rosevear <jpr@novell.com>
Novell, Inc.

evolution-patches mailing list
evolution-patches@lists.ximian.com
h= ttp://lists.ximian.com/mailman/listinfo/evolution-patches
--=__Part82A1BA92.0__=-- From notzed@ximian.com Tue May 3 02:39:22 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 496FE1240DD; Tue, 3 May 2005 02:39:22 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 39116124483 for ; Tue, 3 May 2005 02:39:10 -0400 (EDT) Received: (qmail 12285 invoked from network); 3 May 2005 10:40:10 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 3 May 2005 10:40:10 -0000 Subject: Re: [evolution-patches] fix usenet folder flags From: Not Zed To: Alessandro Decina Cc: evolution-patches In-Reply-To: <1115040194.5430.7.camel@homeless.home.sadlands.org> References: <1115040194.5430.7.camel@homeless.home.sadlands.org> Content-Type: multipart/alternative; boundary="=-S6LH4XejrhHznhEWldsB" Date: Tue, 03 May 2005 16:12:56 +0530 Message-Id: <1115116976.8439.0.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-25.2 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_30_40,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-S6LH4XejrhHznhEWldsB Content-Type: text/plain Content-Transfer-Encoding: 7bit looks good to me. must've got lost some time, 'cause it sure used to work fine. On Mon, 2005-05-02 at 15:23 +0200, Alessandro Decina wrote: > Hello, > one-line patch to fix usenet folder flags. > I noticed this bug since the folder subscriptions dialog always displays > all the folders as unsubscribed for usenet accounts. > > Bye > --=-S6LH4XejrhHznhEWldsB Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
looks good to me.

must've got lost some time, 'cause it sure used to work fine.


On Mon, 2005-05-02 at 15:23 +0200, Alessandro Decina wrote: 
Hello,
one-line patch to fix usenet folder flags.
I noticed this bug since the folder subscriptions dialog always displays
all the folders as unsubscribed for usenet accounts.

Bye
--=-S6LH4XejrhHznhEWldsB-- From notzed@ximian.com Tue May 3 02:41:46 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id EC9C3124474; Tue, 3 May 2005 02:41:46 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id A88D01240DD for ; Tue, 3 May 2005 02:41:35 -0400 (EDT) Received: (qmail 12296 invoked from network); 3 May 2005 10:42:35 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 3 May 2005 10:42:35 -0000 Subject: Re: [evolution-patches] This patch removes some compiler warnings (on gcc 4.0) From: Not Zed To: spamfrommailing@pvanhoof.be Cc: Evolution Patches In-Reply-To: <1115062584.8671.9.camel@localhost.localdomain> References: <1115062584.8671.9.camel@localhost.localdomain> Content-Type: multipart/alternative; boundary="=-YIf1Sr7FtTjKnc8hQvGw" Date: Tue, 03 May 2005 16:15:20 +0530 Message-Id: <1115117120.9083.4.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-27.5 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE,IN_REP_TO, REFERENCES,REPLY_WITH_QUOTES,SIGNATURE_LONG_SPARSE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-YIf1Sr7FtTjKnc8hQvGw Content-Type: text/plain Content-Transfer-Encoding: 7bit Any reason why you're getting warnings on those? I would've imagined it would only happen if libxml was compiled with 16 bit xmlChar, but that will break more than just a few warnings ? Or is it just an unsigned char vs signed issue? On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote: > Mainly (xmlChar*) casting for libxml . . . > > > -- > Philip Van Hoof, Software Developer @ Cronos > home: me at pvanhoof dot be > gnome: pvanhoof at gnome dot org > work: philip dot vanhoof at cronos dot be > junk: philip dot vanhoof at gmail dot com > http://www.pvanhoof.be/ --=-YIf1Sr7FtTjKnc8hQvGw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Any reason why you're getting warnings on those?  I would've imagined it would only happen if libxml was compiled with 16 bit xmlChar, but that will break more than just a few warnings ?

Or is it just an unsigned char vs signed issue?

On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote:
Mainly (xmlChar*) casting for libxml  . . .


-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-YIf1Sr7FtTjKnc8hQvGw-- From notzed@ximian.com Tue May 3 02:45:03 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id B95E0124102; Tue, 3 May 2005 02:45:03 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id E9E85124488 for ; Tue, 3 May 2005 02:44:51 -0400 (EDT) Received: (qmail 12301 invoked from network); 3 May 2005 10:45:51 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 3 May 2005 10:45:51 -0000 Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix for builderrorin e-utils From: Not Zed To: spamfrommailing@pvanhoof.be Cc: ls@listsmx.ximian.com, evolution-hackers@lists.ximian.com, Evolution Patches In-Reply-To: <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> Content-Type: multipart/alternative; boundary="=-PxeK0iWVoM9Vc5yYyuRC" Date: Tue, 03 May 2005 16:18:36 +0530 Message-Id: <1115117316.9083.6.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-24.9 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-PxeK0iWVoM9Vc5yYyuRC Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: > On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > > > Hmm, why does this not build? > > > It is like that very speficially so that all of the profiling code can > > be completely removed from the compilation, rather than just calling a > > dummy function. > > > > Any fix should maintain this behaviour, so this one isn't suitable. > > As a gcc 4.0 user the line in the c-file is giving me a syntax error. In > the c-file it isn't showing an incorrect syntax whatsoever. Any chance of dumping the whole error here? > Wouldn't it then be better to wrap the entire function in the #ifdef- > #endif clause and wrap the line where the function is called with it > too? > > In which case the function isn't compiled if profiling isn't enabled. As > will the calls to that function also not be compiled. This isn't acceptable. We plan to put in potentially hundreds of these calls, and wrapping every one in a #ifdef#endif is just not going to cut it! --=-PxeK0iWVoM9Vc5yYyuRC Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: 
On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote:

> Hmm, why does this not  build?

> It is like that very speficially so that all of the profiling code can
> be completely removed from the compilation, rather than just calling a
> dummy function.
> 
> Any fix should maintain this behaviour, so this one isn't suitable.

As a gcc 4.0 user the line in the c-file is giving me a syntax error. In
the c-file it isn't showing an incorrect syntax whatsoever.
Any chance of dumping the whole error here?

Wouldn't it then be better to wrap the entire function in the #ifdef-
#endif clause and wrap the line where the function is called with it
too?

In which case the function isn't compiled if profiling isn't enabled. As
will the calls to that function also not be compiled.
This isn't acceptable.  We plan to put in potentially hundreds of these calls, and wrapping every one in a #ifdef#endif is just not going to cut it!

--=-PxeK0iWVoM9Vc5yYyuRC-- From notzed@ximian.com Tue May 3 02:48:31 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id D456D124492; Tue, 3 May 2005 02:48:24 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id C02A3124481 for ; Tue, 3 May 2005 02:48:12 -0400 (EDT) Received: (qmail 12312 invoked from network); 3 May 2005 10:49:13 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 3 May 2005 10:49:13 -0000 Subject: Re: [evolution-patches] Updated Patch for GroupWise Sent Items From: Not Zed To: Pasupathilingam Sankarasivasubramanian Cc: evolution-patches@lists.ximian.com, Susarla Parthasarathi In-Reply-To: <20050502T140655Z_AD4F00150000@novell.com> References: <20050502T140655Z_AD4F00150000@novell.com> Content-Type: multipart/alternative; boundary="=-ZUSmcAgKRU8elVRFUH65" Date: Tue, 03 May 2005 16:21:59 +0530 Message-Id: <1115117519.8438.8.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-25.2 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_30_40,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-ZUSmcAgKRU8elVRFUH65 Content-Type: text/plain Content-Transfer-Encoding: 7bit looks great, thanks. please commit. Michael On Mon, 2005-05-02 at 02:35 -0600, Pasupathilingam Sankarasivasubramanian wrote: > Hi Michael, > > I have updated the code as per your review comments and updated the > ChangeLog also. > Please review the attached updated patches. > > Thanks, > Sankar > > >>>Not Zed 04/29/05 4:49 am >>> > > HI Sankar, > > I think probably it isn't necessary to add the flag to the transport > at all really - the provider flag should be sufficient, and you can > get it from the transport easily anyway: > > ((CamelService *)xport)->provider->flags > > Rather than having to manage a separate copy of the flag in the > transport structure. > > The changelog missed the change to mail-ops.c too. > > Thanks, > Michael > > On Thu, 2005-04-28 at 04:09 -0600, Pasupathilingam > Sankarasivasubramanian wrote: > > > Hi, > > > > While using a GroupWise account with Evolution, the sent-items > > should not be copied to any folder by evolution since the server > > does it. So Evolution must disable the user from changing the Sent > > Items button. > > > > The patches for disabling the user to set any folder as Sent item > > folder and prevent copying of sent mails is attached with this > > mail. > > > > Thanks & Regards, > > Sankar P --=-ZUSmcAgKRU8elVRFUH65 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
looks great, thanks.  please commit.

Michael

On Mon, 2005-05-02 at 02:35 -0600, Pasupathilingam Sankarasivasubramanian wrote:
Hi Michael,
 
I have updated the code as per your review comments and updated the ChangeLog also.
Please review the attached updated patches.
 
Thanks,
Sankar  

>>>Not Zed <notzed@ximian.com> 04/29/05 4:49 am >>>

HI Sankar,

I think probably it isn't necessary to add the flag to the transport at all really - the provider flag should be sufficient, and you can get it from the transport easily anyway:

((CamelService *)xport)->provider->flags

Rather than having to manage a separate copy of the flag in the transport structure.

The changelog missed the change to mail-ops.c too.

Thanks,
Michael

On Thu, 2005-04-28 at 04:09 -0600, Pasupathilingam Sankarasivasubramanian wrote:

Hi,
 
While using a GroupWise account with Evolution, the sent-items should not be copied to any folder by evolution since the server does it. So Evolution must disable the user from changing the Sent Items button.
 
The patches for disabling the user to set any folder as Sent item folder and prevent copying of sent mails is attached with this mail.
 
Thanks & Regards,
Sankar P
--=-ZUSmcAgKRU8elVRFUH65-- From evolution-hackers-admin@lists.ximian.com Tue May 3 02:48:50 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id F159D124474; Tue, 3 May 2005 02:48:49 -0400 (EDT) Received: from executivesontheweb.com (host217-37-162-197.in-addr.btopenworld.com [217.37.162.197]) by lists.ximian.com (Postfix) with ESMTP id 6F46E12448C; Tue, 3 May 2005 02:48:37 -0400 (EDT) Received: from mail pickup service by executivesontheweb.com with Microsoft SMTPSVC; Tue, 3 May 2005 12:00:36 +0100 thread-index: AcVPz1Wtq0AAZU5BS7+bqxtI4WsrNA== Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix forbuilderrorin e-utils From: "Not Zed" To: Cc: , , "Evolution Patches" Message-ID: <008901c54fcf$55addf50$0301a8c0@executivesontheweb.local> In-Reply-To: <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> Content-Transfer-Encoding: 7bit References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> Content-Type: multipart/alternative; boundary="=-PxeK0iWVoM9Vc5yYyuRC" MIME-Version: 1.0 X-Mailer: Evolution 2.3.1 X-BeenThere: evolution-hackers@lists.ximian.com Content-Class: urn:content-classes:message Importance: normal Priority: normal X-Mailman-Version: 2.0.13 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.181 Precedence: bulk Date: Tue, 3 May 2005 12:00:36 +0100 X-OriginalArrivalTime: 03 May 2005 11:00:36.0687 (UTC) FILETIME=[55D675F0:01C54FCF] X-Spam-Status: No, hits=-23.1 required=5.0 tests=DATE_IN_FUTURE_03_06,EMAIL_ATTRIBUTION,HTML_20_30, HTML_MESSAGE,IN_REP_TO,MISSING_OUTLOOK_NAME, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: This is a multi-part message in MIME format. --=-PxeK0iWVoM9Vc5yYyuRC Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: > On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > > > Hmm, why does this not build? > > > It is like that very speficially so that all of the profiling code can > > be completely removed from the compilation, rather than just calling a > > dummy function. > > > > Any fix should maintain this behaviour, so this one isn't suitable. > > As a gcc 4.0 user the line in the c-file is giving me a syntax error. In > the c-file it isn't showing an incorrect syntax whatsoever. Any chance of dumping the whole error here? > Wouldn't it then be better to wrap the entire function in the #ifdef- > #endif clause and wrap the line where the function is called with it > too? > > In which case the function isn't compiled if profiling isn't enabled. As > will the calls to that function also not be compiled. This isn't acceptable. We plan to put in potentially hundreds of these calls, and wrapping every one in a #ifdef#endif is just not going to cut it! --=-PxeK0iWVoM9Vc5yYyuRC Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: 
On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote:

> Hmm, why does this not  build?

> It is like that very speficially so that all of the profiling code can
> be completely removed from the compilation, rather than just calling a
> dummy function.
> 
> Any fix should maintain this behaviour, so this one isn't suitable.

As a gcc 4.0 user the line in the c-file is giving me a syntax error. In
the c-file it isn't showing an incorrect syntax whatsoever.
Any chance of dumping the whole error here?

Wouldn't it then be better to wrap the entire function in the #ifdef-
#endif clause and wrap the line where the function is called with it
too?

In which case the function isn't compiled if profiling isn't enabled. As
will the calls to that function also not be compiled.
This isn't acceptable.  We plan to put in potentially hundreds of these calls, and wrapping every one in a #ifdef#endif is just not going to cut it!

--=-PxeK0iWVoM9Vc5yYyuRC-- From spamfrommailing@freax.org Tue May 3 03:04:02 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 96787124102; Tue, 3 May 2005 03:04:02 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id A321B124102 for ; Tue, 3 May 2005 03:03:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id 59EDA1394237; Tue, 3 May 2005 13:04:47 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 11274-02; Tue, 3 May 2005 13:04:39 +0200 (CEST) Received: from [192.168.0.129] (cvs.maia-scientific.com [213.193.139.10]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id C171B139422B; Tue, 3 May 2005 13:04:39 +0200 (CEST) Subject: Re: [evolution-patches] This patch removes some compiler warnings (on gcc 4.0) From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: Not Zed Cc: spamfrommailing@pvanhoof.be, Evolution Patches In-Reply-To: <1115117120.9083.4.camel@lostzed.mmc.com.au> References: <1115062584.8671.9.camel@localhost.localdomain> <1115117120.9083.4.camel@lostzed.mmc.com.au> Content-Type: multipart/alternative; boundary="=-uGBbgvwalRv/0ldJX3KP" Date: Tue, 03 May 2005 13:04:39 +0200 Message-Id: <1115118279.10939.21.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-31.3 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES,SIGNATURE_LONG_SPARSE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-uGBbgvwalRv/0ldJX3KP Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 2005-05-03 at 16:15 +0530, Not Zed wrote: > > Any reason why you're getting warnings on those? I would've imagined > it would only happen if libxml was compiled with 16 bit xmlChar, but > that will break more than just a few warnings ? > > Or is it just an unsigned char vs signed issue? I think it's simple unsigned char vs singed issue. Gcc 4.0 is a little bit more pedantic about warning about it, I guess. > On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote: > > > Mainly (xmlChar*) casting for libxml . . . -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-uGBbgvwalRv/0ldJX3KP Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On Tue, 2005-05-03 at 16:15 +0530, Not Zed wrote:

Any reason why you're getting warnings on those?  I would've imagined it would only happen if libxml was compiled with 16 bit xmlChar, but that will break more than just a few warnings ?

Or is it just an unsigned char vs signed issue?

I think it's simple unsigned char vs singed issue. Gcc 4.0 is a little bit more pedantic about warning about it, I guess.

On Mon, 2005-05-02 at 21:36 +0200, Philip Van Hoof wrote:
Mainly (xmlChar*) casting for libxml  . . .


-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-uGBbgvwalRv/0ldJX3KP-- From notzed@ximian.com Tue May 3 03:04:56 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 9398612448D; Tue, 3 May 2005 03:04:56 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 7ABA1124481 for ; Tue, 3 May 2005 03:04:44 -0400 (EDT) Received: (qmail 12334 invoked from network); 3 May 2005 11:05:44 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 3 May 2005 11:05:44 -0000 Subject: Re: [evolution-patches] EDS camel-nntp-provider remove CAMEL_URL_ALLOW_PASSWORD From: Not Zed To: Alessandro Decina Cc: evolution-patches@lists.ximian.com In-Reply-To: <1114681611.12547.23.camel@homeless.home.sadlands.org> References: <1113501727.9083.13.camel@homeless.home.sadlands.org> <1114140003.4618.30.camel@lostzed.mmc.com.au> <1114165584.6647.15.camel@homeless.home.sadlands.org> <1114661517.5005.6.camel@lostzed.mmc.com.au> <1114667334.10234.11.camel@homeless.home.sadlands.org> <1114676943.308.3.camel@lostzed.mmc.com.au> <1114681611.12547.23.camel@homeless.home.sadlands.org> Content-Type: multipart/alternative; boundary="=-OoadqJDPsnU1gYWA+4yk" Date: Tue, 03 May 2005 16:38:30 +0530 Message-Id: <1115118510.9082.16.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-25.5 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_20_30,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-OoadqJDPsnU1gYWA+4yk Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, 2005-04-28 at 11:46 +0200, Alessandro Decina wrote: > On gio, 2005-04-28 at 13:59 +0530, Not Zed wrote: > > > /* if nessecary, prompt for the password */ > > > if (!service->url->passwd) { > > > [cut] > > > service->url->passwd = camel_session_get_password (session, service, > > > NULL, prompt, "password", CAMEL_SESSION_PASSWORD_SECRET, ex); > > > [cut] > > > > Oh. But that has zero to do with the CAMEL_URL_ALLOW_PASSWORD flag. > Yes, I repeat: that flag is used ONLY by the camel-nntp-provider, and I > see no point in this. All the other providers use the > camel_session_get_password function to store the passwords. > > > > With that box shown, service->url->passwd is always set (possibily to > > > "\0"). Without it, as it is required, the enter-password dialog is shown > > > and service->url->passwd is set accordingly. > > what "box" is it showing? The password requester popup is not a "box" > > and has nothing to do with setting the passwd. So, what "box" do you > > mean? > Well I was not clear. > When the CAMEL_URL_ALLOW_PASSWORD is set, the account editor, in the > Receiving Email tab, shows an input box to enter the password. That box > IMO sould not be there. Well it isn't there. What version of evolution are you patching? It definitely isn't here in 2.3.x. That is why there is confusion here ... I definitely do not see any such box. > ALL the other providers use the camel session's get_password callback to > ask the password. AFAIC in evolution that callback is hooked by the > password request popup, and it HAS to do with setting the password. > > What I am saying is this: I think that the camel-nntp-provider simply > should NOT show the password box in the account editor and only prompt > for the password when and if required, just like all the rest of the > providers do. > > Am I missing something? I dont know, but I am, that box! --=-OoadqJDPsnU1gYWA+4yk Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit On Thu, 2005-04-28 at 11:46 +0200, Alessandro Decina wrote: 
On gio, 2005-04-28 at 13:59 +0530, Not Zed wrote:
> > /* if nessecary, prompt for the password */
> > if (!service->url->passwd) {
> > [cut]
> > service->url->passwd = camel_session_get_password (session, service,
> > NULL, prompt, "password", CAMEL_SESSION_PASSWORD_SECRET, ex);
> > [cut]
> 
> Oh.  But that has zero to do with the CAMEL_URL_ALLOW_PASSWORD flag.
Yes, I repeat: that flag is used ONLY by the camel-nntp-provider, and I
see no point in this. All the other providers use the
camel_session_get_password function to store the passwords.

> > With that box shown, service->url->passwd is always set (possibily to
> > "\0"). Without it, as it is required, the enter-password dialog is shown
> > and service->url->passwd is set accordingly.
> what "box" is it showing?  The password requester popup is not a "box"
> and has nothing to do with setting the passwd. So, what "box" do you
> mean?
Well I was not clear.
When the CAMEL_URL_ALLOW_PASSWORD is set, the account editor, in the
Receiving Email tab, shows an input box to enter the password. That box
IMO sould not be there.

Well it isn't there.  What version of evolution are you patching?  It definitely isn't here in 2.3.x.

That is why there is confusion here ...

I definitely do not see any such box.

ALL the other providers use the camel session's get_password callback to
ask the password. AFAIC in evolution that callback is hooked by the
password request popup, and it HAS to do with setting the password.

What I am saying is this: I think that the camel-nntp-provider simply
should NOT show the password box in the account editor and only prompt
for the password when and if required, just like all the rest of the
providers do.

Am I missing something?

I dont know, but I am, that box!

--=-OoadqJDPsnU1gYWA+4yk-- From rodo@novell.com Tue May 3 03:07:28 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 9DCE812448A; Tue, 3 May 2005 03:07:28 -0400 (EDT) Received: from skeptopotamus.ximian.com (skeptopotamus.ximian.com [130.57.169.16]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "mail.cam.novell.com", Issuer "Equifax Secure Global eBusiness CA-1" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 6AB9E12448D for ; Tue, 3 May 2005 03:07:16 -0400 (EDT) Received: by skeptopotamus.ximian.com (Postfix) id 8F55F6396F; Tue, 3 May 2005 07:08:17 -0400 (EDT) Delivered-To: evolution-patches@ximian.com Received: from jericho.provo.novell.com (jericho.provo.novell.com [137.65.81.173]) by skeptopotamus.ximian.com (Postfix) with ESMTP id 412CD63964 for ; Tue, 3 May 2005 07:08:17 -0400 (EDT) Received: from [164.99.152.100] ([164.99.152.100]) by jericho.provo.novell.com; Tue, 03 May 2005 05:08:09 -0600 From: Radek Doulik To: Patches Cc: Rodrigo Moya , Rodney Dawes Content-Type: multipart/mixed; boundary="=-YEUk+gZLpRyN3BzykjEC" Date: Tue, 03 May 2005 16:31:49 +0530 Message-Id: <1115118109.12330.21.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1.1 X-Spam-Status: No, hits=-6.0 required=5.0 tests=PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] another small leak fix Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-YEUk+gZLpRyN3BzykjEC Content-Type: text/plain Content-Transfer-Encoding: 7bit --=-YEUk+gZLpRyN3BzykjEC Content-Disposition: attachment; filename=gtkhtml-leak-fix-2.patch Content-Type: text/x-patch; name=gtkhtml-leak-fix-2.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: ChangeLog =================================================================== RCS file: /cvs/gnome/gtkhtml/src/ChangeLog,v retrieving revision 1.2118 diff -p -u -r1.2118 ChangeLog --- ChangeLog 29 Apr 2005 06:51:14 -0000 1.2118 +++ ChangeLog 3 May 2005 11:06:18 -0000 @@ -1,3 +1,9 @@ +2005-05-03 Radek Doulik + + * gtkhtml.c (selection_get): free save buffer + + * htmlengine.c (element_parse_a): free target before leaving + 2005-04-29 Radek Doulik * htmlcluev.c (html_cluev_set_style): unref background color Index: gtkhtml.c =================================================================== RCS file: /cvs/gnome/gtkhtml/src/gtkhtml.c,v retrieving revision 1.597 diff -p -u -r1.597 gtkhtml.c --- gtkhtml.c 8 Apr 2005 14:37:37 -0000 1.597 +++ gtkhtml.c 3 May 2005 11:06:18 -0000 @@ -1987,7 +1987,7 @@ selection_get (GtkWidget *widget, selection_string, len); - //html_engine_save_buffer_free (state); + html_engine_save_buffer_free (state); } } else { if (selection_object) Index: htmlengine.c =================================================================== RCS file: /cvs/gnome/gtkhtml/src/htmlengine.c,v retrieving revision 1.635 diff -p -u -r1.635 htmlengine.c --- htmlengine.c 29 Apr 2005 06:51:14 -0000 1.635 +++ htmlengine.c 3 May 2005 11:06:19 -0000 @@ -1804,6 +1804,8 @@ element_parse_a (HTMLEngine *e, HTMLObje html_anchor_new (id)); g_free (id); } + + g_free (target); html_element_parse_coreattrs (element); --=-YEUk+gZLpRyN3BzykjEC-- From rodrigo@novell.com Tue May 3 03:32:20 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 9192112448F; Tue, 3 May 2005 03:32:19 -0400 (EDT) Received: from skeptopotamus.ximian.com (skeptopotamus.ximian.com [130.57.169.16]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "mail.cam.novell.com", Issuer "Equifax Secure Global eBusiness CA-1" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 344081244A9 for ; Tue, 3 May 2005 03:31:36 -0400 (EDT) Received: by skeptopotamus.ximian.com (Postfix) id 9D5F0639D0; Tue, 3 May 2005 07:31:08 -0400 (EDT) Delivered-To: evolution-patches@ximian.com Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by skeptopotamus.ximian.com (Postfix) with ESMTP id 97D0F639CE for ; Tue, 3 May 2005 07:31:08 -0400 (EDT) Received: (qmail 12388 invoked from network); 3 May 2005 11:31:07 -0000 Received: from localhost (HELO ?164.99.152.137?) (127.0.0.1) by localhost with SMTP; 3 May 2005 11:31:07 -0000 From: Rodrigo Moya To: Radek Doulik Cc: Patches , Rodney Dawes In-Reply-To: <1115118109.12330.21.camel@localhost.localdomain> References: <1115118109.12330.21.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 03 May 2005 13:30:00 +0200 Message-Id: <1115119801.31736.30.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-22.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Re: another small leak fix Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 16:31 +0530, Radek Doulik wrote: looks good to me -- Rodrigo Moya From jpr@novell.com Tue May 3 04:13:21 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id D28F41244BD; Tue, 3 May 2005 04:13:21 -0400 (EDT) Received: from lyle.provo.novell.com (lyle.provo.novell.com [137.65.81.174]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "imap.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id AC6CB1244BE for ; Tue, 3 May 2005 04:13:09 -0400 (EDT) Received: from bishop.blr.novell.com ([137.65.81.216]) by lyle.provo.novell.com; Tue, 03 May 2005 06:13:53 -0600 Subject: Re: [evolution-patches] [PATCH] Name selector limits (again) From: JP Rosevear To: Hans Petter Jansson Cc: evolution-patches@lists.ximian.com In-Reply-To: <1115000663.444.100.camel@avarice.monx> References: <1115000663.444.100.camel@avarice.monx> Content-Type: text/plain Organization: Novell, Inc. Date: Tue, 03 May 2005 17:44:16 +0530 Message-Id: <1115122456.9688.45.camel@bishop.rosevear.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Sun, 2005-05-01 at 21:24 -0500, Hans Petter Jansson wrote: > I'm seeking approval for HEAD for this patch, which was not considered > before 2.2 on the grounds that it breaks ABI compatibility. > > I also suggest we (I) change the objects to use a separate private > struct so it'll be easier to change things without ABI breakage in the > future. I can send a separate patch for that. We're trying to maintain abi/api compat with 1.2 in 1.4 as well. -JP -- JP Rosevear Novell, Inc. From rsushma@novell.com Tue May 3 04:42:24 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 990AF1244DB; Tue, 3 May 2005 04:42:24 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 8A8EF124494 for ; Tue, 3 May 2005 04:42:10 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 5E7D79D5DF; Tue, 3 May 2005 18:19:28 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-9MOfDIVFB5c13ctFaQX8" Date: Tue, 03 May 2005 18:19:27 +0530 Message-Id: <1115124567.1251.4.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_UNCONFIRMED_DSBL version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Address book: memory leak fixes Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-9MOfDIVFB5c13ctFaQX8 Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, Attached patch fixes memory leaks in address book cache handling. Please review. Thanks, Sushma. --=-9MOfDIVFB5c13ctFaQX8 Content-Disposition: inline; filename=cache-leak.diff Content-Transfer-Encoding: base64 Content-Type: text/plain; name=cache-leak.diff; charset=us-ascii SW5kZXg6IGFkZHJlc3Nib29rL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMv Z25vbWUvZXZvbHV0aW9uLWRhdGEtc2VydmVyL2FkZHJlc3Nib29rL0NoYW5nZUxvZyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMjY0DQpkaWZmIC11IC1wIC1yMS4yNjQgQ2hhbmdlTG9nDQotLS0g YWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTI3IEFwciAyMDA1IDEwOjE5OjQwIC0wMDAwCTEuMjY0DQor KysgYWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTIgTWF5IDIwMDUgMTA6Mjc6NDkgLTAwMDANCkBAIC0x LDMgKzEsMTEgQEANCisyMDA1LTA1LTAyICBTdXNobWEgUmFpICA8cnN1c2htYUBub3ZlbGwuY29t Pg0KKw0KKwkqIGxpYmVkYXRhLWJvb2svZS1ib29rLWJhY2tlbmQtY2FjaGUuYyANCisJKGVfYm9v a19iYWNrZW5kX2NhY2hlX2dldF9jb250YWN0cyk6IEZyZWVpbmcgbGlzdCBvZiBjYWNoZSBvYmpl Y3RzIGFuZA0KKwlzZXhwLg0KKwkoZV9ib29rX2JhY2tlbmRfY2FjaGVfc2VhcmNoKTogRnJlZWlu ZyBsaXN0IG9mIGNvbnRhY3RzIG1hdGNoaW5nIHRoZSANCisJcXVlcnkuDQorDQogMjAwNS0wNC0y NyAgU3VzaG1hIFJhaSAgPHJzdXNobWFAbm92ZWxsLmNvbT4NCiANCiAJKiBsaWJlYm9vay9lLWJv b2suYyAoZV9ib29rX3Jlc3BvbnNlX2FkZF9jb250YWN0KTogU2V0dGluZyB0aGUgc3RhdHVzDQpJ bmRleDogYWRkcmVzc2Jvb2svbGliZWRhdGEtYm9vay9lLWJvb2stYmFja2VuZC1jYWNoZS5jDQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9sdXRpb24tZGF0YS1zZXJ2ZXIvYWRk cmVzc2Jvb2svbGliZWRhdGEtYm9vay9lLWJvb2stYmFja2VuZC1jYWNoZS5jLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS4zDQpkaWZmIC11IC1wIC1yMS4zIGUtYm9vay1iYWNrZW5kLWNhY2hlLmMN Ci0tLSBhZGRyZXNzYm9vay9saWJlZGF0YS1ib29rL2UtYm9vay1iYWNrZW5kLWNhY2hlLmMJMTAg SmFuIDIwMDUgMTE6NTI6MDMgLTAwMDAJMS4zDQorKysgYWRkcmVzc2Jvb2svbGliZWRhdGEtYm9v ay9lLWJvb2stYmFja2VuZC1jYWNoZS5jCTIgTWF5IDIwMDUgMTA6Mjg6MTAgLTAwMDANCkBAIC0z MzIsNiArMzMyLDcgQEAgZV9ib29rX2JhY2tlbmRfY2FjaGVfZ2V0X2NvbnRhY3RzIChFQm9vaw0K IAlFQ29udGFjdCAqY29udGFjdDsNCiAgICAgICAgIEVCb29rQmFja2VuZFNFeHAgKnNleHAgPSBO VUxMOw0KIAljb25zdCBjaGFyICp1aWQ7DQorDQogCWdfcmV0dXJuX3ZhbF9pZl9mYWlsIChFX0lT X0JPT0tfQkFDS0VORF9DQUNIRSAoY2FjaGUpLCBOVUxMKTsNCiAJaWYgKHF1ZXJ5KSB7DQogCQlz ZXhwID0gZV9ib29rX2JhY2tlbmRfc2V4cF9uZXcgKHF1ZXJ5KTsNCkBAIC0zNDEsOCArMzQyLDcg QEAgZV9ib29rX2JhY2tlbmRfY2FjaGVfZ2V0X2NvbnRhY3RzIChFQm9vaw0KICAgICAgICANCiAN CiAgICAgICAgIGwgPSBlX2ZpbGVfY2FjaGVfZ2V0X29iamVjdHMgKEVfRklMRV9DQUNIRSAoY2Fj aGUpKTsNCi0gICAgICAgIGlmICghbCkNCi0gICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7DQor DQogICAgICAgICBmb3IgKCA7IGwgIT0gTlVMTDsgbCA9IGdfc2xpc3RfbmV4dCAobCkpIHsNCiAg ICAgICAgICAgICAgICAgdmNhcmRfc3RyID0gbC0+ZGF0YTsNCiAgICAgICAgICAgICAgICAgaWYg KHZjYXJkX3N0ciAmJiAhc3RybmNtcCAodmNhcmRfc3RyLCAiQkVHSU46VkNBUkQiLCAxMSkpIHsN CkBAIC0zNTMsNiArMzUzLDEwIEBAIGVfYm9va19iYWNrZW5kX2NhY2hlX2dldF9jb250YWN0cyAo RUJvb2sNCiAgICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAgICANCiAgICAgICAgIH0N CisJaWYgKGwpDQorCQlnX3NsaXN0X2ZyZWUgKGwpOw0KKwlpZiAoc2V4cCkNCisJCWdfb2JqZWN0 X3VucmVmIChzZXhwKTsNCiANCiAgICAgICAgIHJldHVybiBsaXN0Ow0KIH0NCkBAIC0zNjcsMTIg KzM3MSwxMyBAQCBlX2Jvb2tfYmFja2VuZF9jYWNoZV9zZWFyY2ggKEVCb29rQmFja2VuDQogCXB0 cl9hcnJheSA9IGdfcHRyX2FycmF5X25ldyAoKTsNCiAJDQogCXRlbXAgPSBtYXRjaGluZ19jb250 YWN0czsNCi0JZm9yICg7IG1hdGNoaW5nX2NvbnRhY3RzICE9IE5VTEw7IG1hdGNoaW5nX2NvbnRh Y3RzID0gZ19saXN0X25leHQgKG1hdGNoaW5nX2NvbnRhY3RzKSkNCisJZm9yICg7IG1hdGNoaW5n X2NvbnRhY3RzICE9IE5VTEw7IG1hdGNoaW5nX2NvbnRhY3RzID0gZ19saXN0X25leHQgKG1hdGNo aW5nX2NvbnRhY3RzKSkgew0KIAkJZ19wdHJfYXJyYXlfYWRkIChwdHJfYXJyYXksIGVfY29udGFj dF9nZXQgKG1hdGNoaW5nX2NvbnRhY3RzLT5kYXRhLCBFX0NPTlRBQ1RfVUlEKSk7DQotCQkNCi0J cmV0dXJuIHB0cl9hcnJheTsNCisJCWdfb2JqZWN0X3VucmVmIChtYXRjaGluZ19jb250YWN0cy0+ ZGF0YSk7DQorCX0NCisJZ19saXN0X2ZyZWUgKHRlbXApOw0KIAkNCi0NCisJcmV0dXJuIHB0cl9h cnJheTsNCiB9DQogDQogZ2Jvb2xlYW4gDQo= --=-9MOfDIVFB5c13ctFaQX8-- From rsushma@novell.com Tue May 3 04:45:02 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id B91BE1244E5; Tue, 3 May 2005 04:45:02 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 02FDB1244E4 for ; Tue, 3 May 2005 04:44:49 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 19AAD9D7D5; Tue, 3 May 2005 18:22:09 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-XM9RZf1QDykeEHGXXVhL" Date: Tue, 03 May 2005 18:22:08 +0530 Message-Id: <1115124728.1275.7.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_UNCONFIRMED_DSBL version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Address book: REV field support for GW backend Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-XM9RZf1QDykeEHGXXVhL Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, This is the patch to handle last modified time for a contact in GW backend. Please review, -Sushma. --=-XM9RZf1QDykeEHGXXVhL Content-Disposition: inline; filename=gw_rev.diff Content-Transfer-Encoding: base64 Content-Type: text/plain; name=gw_rev.diff; charset=us-ascii SW5kZXg6IGFkZHJlc3Nib29rL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMv Z25vbWUvZXZvbHV0aW9uLWRhdGEtc2VydmVyL2FkZHJlc3Nib29rL0NoYW5nZUxvZyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMjY0DQpkaWZmIC11IC1wIC1yMS4yNjQgQ2hhbmdlTG9nDQotLS0g YWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTI3IEFwciAyMDA1IDEwOjE5OjQwIC0wMDAwCTEuMjY0DQor KysgYWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTIgTWF5IDIwMDUgMDk6MzQ6NDggLTAwMDANCkBAIC0x LDMgKzEsMTMgQEANCisyMDA1LTA1LTAyICBTdXNobWEgUmFpICA8cnN1c2htYUBub3ZlbGwuY29t Pg0KKw0KKwkqIGJhY2tlbmRzL2dyb3Vwd2lzZS9lLWJvb2stYmFja2VuZC1ncm91cHdpc2UuYzog QWRkZWQgRV9DT05UQUNUX1JFVg0KKwlmaWxlZC4NCisNCisJKiBzZXJ2ZXJzL2dyb3Vwd2lzZS9l LWd3LWl0ZW0uYyANCisJKHNldF9jb21tb25fYWRkcmVzc2Jvb2tfaXRlbV9maWVsZHNfZnJvbV9z b2FwX3BhcmFtZXRlcik6DQorCVJlYWRpbmcgYW5kIHNhdmluZyBtb2RpZmllZCB0aW1lIHBhcmFt ZXRlciB2YWx1ZSBmcm9tIHRoZSBzZXJ2ZXIgDQorCXJlc3BvbnNlLg0KKwkNCiAyMDA1LTA0LTI3 ICBTdXNobWEgUmFpICA8cnN1c2htYUBub3ZlbGwuY29tPg0KIA0KIAkqIGxpYmVib29rL2UtYm9v ay5jIChlX2Jvb2tfcmVzcG9uc2VfYWRkX2NvbnRhY3QpOiBTZXR0aW5nIHRoZSBzdGF0dXMNCklu ZGV4OiBhZGRyZXNzYm9vay9iYWNrZW5kcy9ncm91cHdpc2UvZS1ib29rLWJhY2tlbmQtZ3JvdXB3 aXNlLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1kYXRhLXNl cnZlci9hZGRyZXNzYm9vay9iYWNrZW5kcy9ncm91cHdpc2UvZS1ib29rLWJhY2tlbmQtZ3JvdXB3 aXNlLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjUxDQpkaWZmIC11IC1wIC1yMS41MSBlLWJv b2stYmFja2VuZC1ncm91cHdpc2UuYw0KLS0tIGFkZHJlc3Nib29rL2JhY2tlbmRzL2dyb3Vwd2lz ZS9lLWJvb2stYmFja2VuZC1ncm91cHdpc2UuYwk4IE1hciAyMDA1IDAxOjEzOjQxIC0wMDAwCTEu NTENCisrKyBhZGRyZXNzYm9vay9iYWNrZW5kcy9ncm91cHdpc2UvZS1ib29rLWJhY2tlbmQtZ3Jv dXB3aXNlLmMJMiBNYXkgMjAwNSAwOTozNToxNyAtMDAwMA0KQEAgLTExNiw3ICsxMTYsOCBAQCBz dHJ1Y3QgZmllbGRfZWxlbWVudF9tYXBwaW5nIHsNCiAJeyBFX0NPTlRBQ1RfQUREUkVTU19IT01F LCBFTEVNRU5UX1RZUEVfQ09NUExFWCwgIkhvbWUiLCBwb3B1bGF0ZV9hZGRyZXNzLCBzZXRfYWRk cmVzc19pbl9nd19pdGVtLCBzZXRfYWRkcmVzc19jaGFuZ2VzIH0sDQogCXsgRV9DT05UQUNUX0lN X0FJTSwgRUxFTUVOVF9UWVBFX0NPTVBMRVgsICJpbXMiLCBwb3B1bGF0ZV9pbXMsIHNldF9pbXNf aW5fZ3dfaXRlbSwgc2V0X2ltX2NoYW5nZXMgfSwNCiAJeyBFX0NPTlRBQ1RfQ0FURUdPUklFUywg RUxFTUVOVF9UWVBFX0NPTVBMRVgsICJjYXRlZ29yaWVzIiwgTlVMTCwgTlVMTCwgc2V0X2NhdGVn b3JpZXNfY2hhbmdlc30sDQotCXsgRV9DT05UQUNUX0VNQUlMXzEsIEVMRU1FTlRfVFlQRV9DT01Q TEVYLCAiZW1haWwiLCBwb3B1bGF0ZV9lbWFpbHMsIHNldF9lbWFpbHNfaW5fZ3dfaXRlbSwgc2V0 X2VtYWlsc19jaGFuZ2VzIH0NCisJeyBFX0NPTlRBQ1RfRU1BSUxfMSwgRUxFTUVOVF9UWVBFX0NP TVBMRVgsICJlbWFpbCIsIHBvcHVsYXRlX2VtYWlscywgc2V0X2VtYWlsc19pbl9nd19pdGVtLCBz ZXRfZW1haWxzX2NoYW5nZXMgfSwNCisJeyBFX0NPTlRBQ1RfUkVWLCBFTEVNRU5UX1RZUEVfU0lN UExFLCAibW9kaWZpZWRfdGltZSJ9DQogfTsgDQogDQogDQpJbmRleDogc2VydmVycy9ncm91cHdp c2UvZS1ndy1pdGVtLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlv bi1kYXRhLXNlcnZlci9zZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWl0ZW0uYyx2DQpyZXRyaWV2aW5n IHJldmlzaW9uIDEuNzcNCmRpZmYgLXUgLXAgLXIxLjc3IGUtZ3ctaXRlbS5jDQotLS0gc2VydmVy cy9ncm91cHdpc2UvZS1ndy1pdGVtLmMJMjYgQXByIDIwMDUgMTI6NDg6MjUgLTAwMDAJMS43Nw0K KysrIHNlcnZlcnMvZ3JvdXB3aXNlL2UtZ3ctaXRlbS5jCTIgTWF5IDIwMDUgMDk6MzU6NTMgLTAw MDANCkBAIC04NjgsNiArODY4LDEyIEBAIHNldF9jb21tb25fYWRkcmVzc2Jvb2tfaXRlbV9maWVs ZHNfZnJvbV8NCiAJCWl0ZW0tPnByaXYtPmlkID0gZ19zdHJkdXAgKHZhbHVlKTsNCiAJfQ0KIAl2 YWx1ZSA9IE5VTEw7DQorCXN1YnBhcmFtID0gc291cF9zb2FwX3BhcmFtZXRlcl9nZXRfZmlyc3Rf Y2hpbGRfYnlfbmFtZShwYXJhbSwgIm1vZGlmaWVkIik7DQorCWlmKHN1YnBhcmFtKSB7DQorCQl2 YWx1ZSA9IHNvdXBfc29hcF9wYXJhbWV0ZXJfZ2V0X3N0cmluZ192YWx1ZSAoc3VicGFyYW0pOw0K KwkJZ19oYXNoX3RhYmxlX2luc2VydCAoc2ltcGxlX2ZpZWxkcywgIm1vZGlmaWVkX3RpbWUiLCB2 YWx1ZSk7DQorCX0NCisJdmFsdWUgPSBOVUxMOw0KIAlzdWJwYXJhbSA9IHNvdXBfc29hcF9wYXJh bWV0ZXJfZ2V0X2ZpcnN0X2NoaWxkX2J5X25hbWUgKHBhcmFtLCAiY29tbWVudCIpOw0KIAlpZihz dWJwYXJhbSkgew0KIAkJdmFsdWUgPSBzb3VwX3NvYXBfcGFyYW1ldGVyX2dldF9zdHJpbmdfdmFs dWUgKHN1YnBhcmFtKTsNCg== --=-XM9RZf1QDykeEHGXXVhL-- From rsushma@novell.com Tue May 3 05:02:50 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 004981241E3; Tue, 3 May 2005 05:02:49 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 72ECE1240FB for ; Tue, 3 May 2005 05:02:37 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 00AEB9D7E3; Tue, 3 May 2005 18:39:51 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-mI1g3q9qOG9BPg+enb4S" Date: Tue, 03 May 2005 18:39:51 +0530 Message-Id: <1115125791.1274.12.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=2.4 required=5.0 tests=DATE_IN_FUTURE_03_06,RCVD_IN_UNCONFIRMED_DSBL, SUBJ_HAS_UNIQ_ID version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Address book: Fix for #268271 Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-mI1g3q9qOG9BPg+enb4S Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, Attached a patch to form the attribute FN from N, if vcard has only name attribute, and also handle BASE64 encoding. These are valid according to vcard 2.1 specification. Please review, Sushma. --=-mI1g3q9qOG9BPg+enb4S Content-Disposition: inline; filename=vcard_parse_268271.diff Content-Transfer-Encoding: base64 Content-Type: text/plain; name=vcard_parse_268271.diff; charset=us-ascii SW5kZXg6IGFkZHJlc3Nib29rL2xpYmVib29rL2UtdmNhcmQuYw0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9jdnMvZ25vbWUvZXZvbHV0aW9uLWRhdGEtc2VydmVyL2FkZHJlc3Nib29rL2xpYmVib29r L2UtdmNhcmQuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTkNCmRpZmYgLXUgLXAgLXIxLjE5 IGUtdmNhcmQuYw0KLS0tIGFkZHJlc3Nib29rL2xpYmVib29rL2UtdmNhcmQuYwkyMSBGZWIgMjAw NSAyMzozNzowNCAtMDAwMAkxLjE5DQorKysgYWRkcmVzc2Jvb2svbGliZWJvb2svZS12Y2FyZC5j CTI3IEFwciAyMDA1IDA2OjI3OjE2IC0wMDAwDQpAQCAtMTE2OCw3ICsxMTY4LDggQEAgZV92Y2Fy ZF9hdHRyaWJ1dGVfYWRkX3BhcmFtIChFVkNhcmRBdHRyaQ0KIAkJfQ0KIA0KIAkJaWYgKHBhcmFt LT52YWx1ZXMgJiYgcGFyYW0tPnZhbHVlcy0+ZGF0YSkgew0KLQkJCWlmICghZ19hc2NpaV9zdHJj YXNlY21wICgoY2hhciopcGFyYW0tPnZhbHVlcy0+ZGF0YSwgImIiKSkNCisJCQlpZiAoIWdfYXNj aWlfc3RyY2FzZWNtcCAoKGNoYXIqKXBhcmFtLT52YWx1ZXMtPmRhdGEsICJiIikgfHwNCisJCQkg ICAgIWdfYXNjaWlfc3RyY2FzZWNtcCAoKGNoYXIqKXBhcmFtLT52YWx1ZXMtPmRhdGEsICJCQVNF NjQiKSkNCiAJCQkJYXR0ci0+ZW5jb2RpbmcgPSBFVkNfRU5DT0RJTkdfQkFTRTY0Ow0KIAkJCWVs c2UgaWYgKCFnX2FzY2lpX3N0cmNhc2VjbXAgKChjaGFyKilwYXJhbS0+dmFsdWVzLT5kYXRhLCBF VkNfUVVPVEVEUFJJTlRBQkxFKSkNCiAJCQkJYXR0ci0+ZW5jb2RpbmcgPSBFVkNfRU5DT0RJTkdf UVA7DQpJbmRleDogYWRkcmVzc2Jvb2svbGliZWJvb2svZS1jb250YWN0LmMNCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N ClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1kYXRhLXNlcnZlci9hZGRyZXNzYm9vay9s aWJlYm9vay9lLWNvbnRhY3QuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDINCmRpZmYgLXUg LXAgLXIxLjQyIGUtY29udGFjdC5jDQotLS0gYWRkcmVzc2Jvb2svbGliZWJvb2svZS1jb250YWN0 LmMJNiBGZWIgMjAwNSAxMjoyODo0MSAtMDAwMAkxLjQyDQorKysgYWRkcmVzc2Jvb2svbGliZWJv b2svZS1jb250YWN0LmMJMiBNYXkgMjAwNSAwODo0MjowMyAtMDAwMA0KQEAgLTQ2Myw2ICs0NjMs OSBAQCBzdGF0aWMgdm9pZCoNCiBuX2dldHRlciAoRUNvbnRhY3QgKmNvbnRhY3QsIEVWQ2FyZEF0 dHJpYnV0ZSAqYXR0cikNCiB7DQogCUVDb250YWN0TmFtZSAqbmFtZSA9IGdfbmV3MCAoRUNvbnRh Y3ROYW1lLCAxKTsNCisJRVZDYXJkQXR0cmlidXRlICpuZXdfYXR0cjsNCisJY2hhciAqbmFtZV9z dHI7DQorDQogCWlmIChhdHRyKSB7DQogCQlHTGlzdCAqcCA9IGVfdmNhcmRfYXR0cmlidXRlX2dl dF92YWx1ZXMgKGF0dHIpOw0KIA0KQEAgLTQ3MSw2ICs0NzQsMTUgQEAgbl9nZXR0ZXIgKEVDb250 YWN0ICpjb250YWN0LCBFVkNhcmRBdHRyaQ0KIAkJbmFtZS0+YWRkaXRpb25hbCA9IGdfc3RyZHVw IChwICYmIHAtPmRhdGEgPyBwLT5kYXRhIDogIiIpOyBpZiAocCkgcCA9IHAtPm5leHQ7DQogCQlu YW1lLT5wcmVmaXhlcyAgID0gZ19zdHJkdXAgKHAgJiYgcC0+ZGF0YSA/IHAtPmRhdGEgOiAiIik7 IGlmIChwKSBwID0gcC0+bmV4dDsNCiAJCW5hbWUtPnN1ZmZpeGVzICAgPSBnX3N0cmR1cCAocCAm JiBwLT5kYXRhID8gcC0+ZGF0YSA6ICIiKTsNCisJfQ0KKw0KKwluZXdfYXR0ciA9IGVfY29udGFj dF9nZXRfZmlyc3RfYXR0ciAoY29udGFjdCwgRVZDX0ZOKTsNCisJaWYgKCFuZXdfYXR0cikgew0K KwkJbmV3X2F0dHIgPSBlX3ZjYXJkX2F0dHJpYnV0ZV9uZXcgKE5VTEwsIEVWQ19GTik7DQorCQll X3ZjYXJkX2FkZF9hdHRyaWJ1dGUgKEVfVkNBUkQgKGNvbnRhY3QpLCBuZXdfYXR0cik7DQorCQlu YW1lX3N0ciA9IGVfY29udGFjdF9uYW1lX3RvX3N0cmluZyAobmFtZSk7DQorCQllX3ZjYXJkX2F0 dHJpYnV0ZV9hZGRfdmFsdWUgKG5ld19hdHRyLCBuYW1lX3N0cik7DQorCQlnX2ZyZWUgKG5hbWVf c3RyKTsNCiAJfQ0KIA0KIAlyZXR1cm4gbmFtZTsNCg== --=-mI1g3q9qOG9BPg+enb4S-- From dobey@novell.com Tue May 3 06:36:37 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id A1DDE124454; Tue, 3 May 2005 06:36:37 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id A87101244F1 for ; Tue, 3 May 2005 06:35:58 -0400 (EDT) Received: (qmail 12766 invoked from network); 3 May 2005 14:36:59 -0000 Received: from localhost (HELO blackbox.boston.ximian.com) (dobey@127.0.0.1) by localhost with SMTP; 3 May 2005 14:36:59 -0000 Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix for builderrorin e-utils From: Rodney Dawes To: Not Zed Cc: Evolution Patches , evolution-hackers@lists.ximian.com, ls@listsmx.ximian.com, spamfrommailing@pvanhoof.be In-Reply-To: <1115117316.9083.6.camel@lostzed.mmc.com.au> References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> <1115117316.9083.6.camel@lostzed.mmc.com.au> Content-Type: text/plain Organization: Novell, Inc. Date: Tue, 03 May 2005 10:36:59 -0400 Message-Id: <1115131019.30025.0.camel@blackbox.cam.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.1.5 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.7 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, QUOTE_TWICE_1,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 16:18 +0530, Not Zed wrote: > On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: > > On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > > > > > Hmm, why does this not build? > > > > > It is like that very speficially so that all of the profiling code can > > > be completely removed from the compilation, rather than just calling a > > > dummy function. > > > > > > Any fix should maintain this behaviour, so this one isn't suitable. > > > > As a gcc 4.0 user the line in the c-file is giving me a syntax error. In > > the c-file it isn't showing an incorrect syntax whatsoever. > Any chance of dumping the whole error here? It's not a GCC 4.x specific error. The problem is that the header is just wrong. If you are compiling without ENABLE_PROFILE defined, then the method becomes a macro in the header, rather than a symbol. However, the method in the C file still exists, though it is a no-op. > > Wouldn't it then be better to wrap the entire function in the #ifdef- > > #endif clause and wrap the line where the function is called with it > > too? > > > > In which case the function isn't compiled if profiling isn't enabled. As > > will the calls to that function also not be compiled. > This isn't acceptable. We plan to put in potentially hundreds of > these calls, and wrapping every one in a #ifdef#endif is just not > going to cut it! Right. Philip's patch removed the whole bit of the #ifdef section in the header, which also removes the prototype. We need to keep the prototype, but dump the macro, otherwise we will be changing ABI depending on compile-time options. I've already committed a fix for this to CVS, as it was preventing me from building Evolution. The prototype is still there, but the macro is gone. There's not reason to define a macro instead, really, unless there is some performance reason that I don't know about. If there is, feel free to re-introduce the macro, and move the #ifdef/#endif section in the actual code, to include the entire method, and not just the calls inside of it. -- dobey From evolution-hackers-admin@lists.ximian.com Tue May 3 06:50:27 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 357A31242C3; Tue, 3 May 2005 06:50:26 -0400 (EDT) Received: from executivesontheweb.com (host217-37-162-197.in-addr.btopenworld.com [217.37.162.197]) by lists.ximian.com (Postfix) with ESMTP id 1A68F12429C; Tue, 3 May 2005 06:50:11 -0400 (EDT) Received: from mail pickup service by executivesontheweb.com with Microsoft SMTPSVC; Tue, 3 May 2005 16:01:13 +0100 thread-index: AcVP8PENv+t8V3tvSuu5cfxE6ivSHQ== Subject: Re: [evolution-patches] Re: [Evolution-hackers] Fix forbuilderrorin e-utils From: "Rodney Dawes" To: Cc: "Evolution Patches" , , , In-Reply-To: <1115117316.9083.6.camel@lostzed.mmc.com.au> Message-ID: <002501c54ff0$f10d1940$0301a8c0@executivesontheweb.local> References: <1114944013.1364.1.camel@localhost.localdomain> <1115026015.30876.16.camel@lostzed.mmc.com.au> <001b01c54eff$ef25b520$0301a8c0@executivesontheweb.local> <1115117316.9083.6.camel@lostzed.mmc.com.au> Content-Type: text/plain; charset="iso-8859-1" Organization: Novell, Inc. MIME-Version: 1.0 X-Mailer: Evolution 2.1.5 Content-Transfer-Encoding: 7bit X-BeenThere: evolution-hackers@lists.ximian.com Content-Class: urn:content-classes:message Importance: normal X-Mailman-Version: 2.0.13 Priority: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.181 Precedence: bulk Date: Tue, 3 May 2005 16:01:10 +0100 X-OriginalArrivalTime: 03 May 2005 15:01:13.0515 (UTC) FILETIME=[F2DB97B0:01C54FF0] X-Spam-Status: No, hits=-23.8 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,MISSING_OUTLOOK_NAME, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES,SUSPICIOUS_RECIPS version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 16:18 +0530, Not Zed wrote: > On Mon, 2005-05-02 at 11:15 +0100, Philip Van Hoof wrote: > > On Mon, 2005-05-02 at 14:56 +0530, Not Zed wrote: > > > > > Hmm, why does this not build? > > > > > It is like that very speficially so that all of the profiling code can > > > be completely removed from the compilation, rather than just calling a > > > dummy function. > > > > > > Any fix should maintain this behaviour, so this one isn't suitable. > > > > As a gcc 4.0 user the line in the c-file is giving me a syntax error. In > > the c-file it isn't showing an incorrect syntax whatsoever. > Any chance of dumping the whole error here? It's not a GCC 4.x specific error. The problem is that the header is just wrong. If you are compiling without ENABLE_PROFILE defined, then the method becomes a macro in the header, rather than a symbol. However, the method in the C file still exists, though it is a no-op. > > Wouldn't it then be better to wrap the entire function in the #ifdef- > > #endif clause and wrap the line where the function is called with it > > too? > > > > In which case the function isn't compiled if profiling isn't enabled. As > > will the calls to that function also not be compiled. > This isn't acceptable. We plan to put in potentially hundreds of > these calls, and wrapping every one in a #ifdef#endif is just not > going to cut it! Right. Philip's patch removed the whole bit of the #ifdef section in the header, which also removes the prototype. We need to keep the prototype, but dump the macro, otherwise we will be changing ABI depending on compile-time options. I've already committed a fix for this to CVS, as it was preventing me from building Evolution. The prototype is still there, but the macro is gone. There's not reason to define a macro instead, really, unless there is some performance reason that I don't know about. If there is, feel free to re-introduce the macro, and move the #ifdef/#endif section in the actual code, to include the entire method, and not just the calls inside of it. -- dobey _______________________________________________ evolution-hackers maillist - evolution-hackers@lists.ximian.com http://lists.ximian.com/mailman/listinfo/evolution-hackers From rodo@novell.com Tue May 3 19:56:05 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 691F3124607; Tue, 3 May 2005 19:56:05 -0400 (EDT) Received: from skeptopotamus.ximian.com (skeptopotamus.ximian.com [130.57.169.16]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "mail.cam.novell.com", Issuer "Equifax Secure Global eBusiness CA-1" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 5D131124457 for ; Tue, 3 May 2005 19:55:35 -0400 (EDT) Received: by skeptopotamus.ximian.com (Postfix) id C2DBC63F39; Tue, 3 May 2005 23:53:25 -0400 (EDT) Delivered-To: evolution-patches@ximian.com Received: from jericho.provo.novell.com (jericho.provo.novell.com [137.65.81.173]) by skeptopotamus.ximian.com (Postfix) with ESMTP id 8D15C63F37 for ; Tue, 3 May 2005 23:53:25 -0400 (EDT) Received: from [164.99.152.100] ([164.99.152.100]) by jericho.provo.novell.com; Tue, 03 May 2005 21:53:10 -0600 Subject: Re: [evolution-patches] Re: another small leak fix From: Radek Doulik To: Rodrigo Moya Cc: Patches , Rodney Dawes In-Reply-To: <1115119801.31736.30.camel@localhost> References: <1115118109.12330.21.camel@localhost.localdomain> <1115119801.31736.30.camel@localhost> Content-Type: text/plain Date: Wed, 04 May 2005 09:15:15 +0530 Message-Id: <1115178315.12330.22.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-9.9 required=5.0 tests=IN_REP_TO,REFERENCES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: committed From rodrigo@novell.com Tue May 3 20:28:56 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id A068D1240C9; Tue, 3 May 2005 20:28:56 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 90DBE124457 for ; Tue, 3 May 2005 20:28:44 -0400 (EDT) Received: (qmail 14612 invoked from network); 4 May 2005 04:29:42 -0000 Received: from localhost (HELO ?164.99.152.227?) (127.0.0.1) by localhost with SMTP; 4 May 2005 04:29:42 -0000 Subject: Re: [evolution-patches] Some generated files that are in CVS From: Rodrigo Moya To: spamfrommailing@pvanhoof.be Cc: Rodney Dawes , Evolution Patches In-Reply-To: <1115061869.8671.6.camel@localhost.localdomain> References: <1114613024.1502.98.camel@localhost.localdomain> <1114613505.20422.0.camel@cerler.home> <1115061869.8671.6.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 04 May 2005 06:28:36 +0200 Message-Id: <1115180916.3589.41.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-22.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Mon, 2005-05-02 at 21:24 +0200, Philip Van Hoof wrote: > I still need approval for this one ;-) > I guess just commit to HEAD please -- Rodrigo Moya From notzed@ximian.com Tue May 3 21:35:29 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 5C793124625; Tue, 3 May 2005 21:35:29 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 707CB12463C for ; Tue, 3 May 2005 21:35:17 -0400 (EDT) Received: (qmail 14686 invoked from network); 4 May 2005 05:36:17 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 4 May 2005 05:36:17 -0000 Subject: Re: [evolution-patches] fix usenet folder flags From: Not Zed To: Alessandro Decina Cc: evolution-patches In-Reply-To: <1115040194.5430.7.camel@homeless.home.sadlands.org> References: <1115040194.5430.7.camel@homeless.home.sadlands.org> Content-Type: multipart/alternative; boundary="=-n3X1/znQgSrIQwymYQ2T" Date: Wed, 04 May 2005 11:09:02 +0530 Message-Id: <1115185142.25627.23.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-25.2 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_30_40,HTML_MESSAGE,IN_REP_TO, QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-n3X1/znQgSrIQwymYQ2T Content-Type: text/plain Content-Transfer-Encoding: 7bit i've commited this to head. On Mon, 2005-05-02 at 15:23 +0200, Alessandro Decina wrote: > Hello, > one-line patch to fix usenet folder flags. > I noticed this bug since the folder subscriptions dialog always displays > all the folders as unsubscribed for usenet accounts. > > Bye > --=-n3X1/znQgSrIQwymYQ2T Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
i've commited this to head.

On Mon, 2005-05-02 at 15:23 +0200, Alessandro Decina wrote: 
Hello,
one-line patch to fix usenet folder flags.
I noticed this bug since the folder subscriptions dialog always displays
all the folders as unsubscribed for usenet accounts.

Bye
--=-n3X1/znQgSrIQwymYQ2T-- From rodrigo@novell.com Tue May 3 22:45:36 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 56664124280; Tue, 3 May 2005 22:45:36 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 33C34124663 for ; Tue, 3 May 2005 22:45:25 -0400 (EDT) Received: (qmail 14768 invoked from network); 4 May 2005 06:46:24 -0000 Received: from localhost (HELO ?164.99.152.227?) (127.0.0.1) by localhost with SMTP; 4 May 2005 06:46:24 -0000 Subject: Re: [evolution-patches] patch for #300920 (calendar) From: Rodrigo Moya To: evolution-patches@lists.ximian.com In-Reply-To: <1113928002.21197.20.camel@cerler.home> References: <1113928002.21197.20.camel@cerler.home> Content-Type: text/plain Date: Wed, 04 May 2005 08:45:14 +0200 Message-Id: <1115189114.3589.53.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-22.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-04-19 at 18:26 +0200, Rodrigo Moya wrote: since nobody answered to this mail, just committed it to HEAD. If you find it interesting for 2.2.x, just speak. -- Rodrigo Moya From rodrigo@novell.com Tue May 3 22:46:45 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id C4B45124663; Tue, 3 May 2005 22:46:45 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 73496124280 for ; Tue, 3 May 2005 22:46:34 -0400 (EDT) Received: (qmail 14774 invoked from network); 4 May 2005 06:47:34 -0000 Received: from localhost (HELO ?164.99.152.227?) (127.0.0.1) by localhost with SMTP; 4 May 2005 06:47:34 -0000 Subject: Re: [evolution-patches] patch for migration From: Rodrigo Moya To: evolution-patches@lists.ximian.com In-Reply-To: <1113917381.5380.43.camel@cerler.home> References: <1113917381.5380.43.camel@cerler.home> Content-Type: text/plain Date: Wed, 04 May 2005 08:46:23 +0200 Message-Id: <1115189183.3589.55.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-04-19 at 15:29 +0200, Rodrigo Moya wrote: > Some people have reported the migration code failing when migrating 1.4 > calendar folders with no calendar.ics/tasks.ics files on them. This > fixes it. this needs to be applied to 2.2.x, since City of Largo were reporting it, and I think it's important enough. Could someone review it? -- Rodrigo Moya From spamfrommailing@freax.org Tue May 3 23:57:03 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 78163124688; Tue, 3 May 2005 23:57:03 -0400 (EDT) Received: from erebus.freax.org (erebus.freax.org [217.22.59.35]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 34A5F1246A3 for ; Tue, 3 May 2005 23:55:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by erebus.freax.org (Postfix) with ESMTP id 7B2DD139422B; Wed, 4 May 2005 09:56:27 +0200 (CEST) Received: from erebus.freax.org ([127.0.0.1]) by localhost (erebus [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02144-03; Wed, 4 May 2005 09:56:20 +0200 (CEST) Received: from [192.168.0.129] (cvs.maia-scientific.com [213.193.139.10]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by erebus.freax.org (Postfix) with ESMTP id 0C4C01394182; Wed, 4 May 2005 09:56:20 +0200 (CEST) Subject: Re: [evolution-patches] Some generated files that are in CVS From: Philip Van Hoof Reply-To: spamfrommailing@pvanhoof.be To: Rodrigo Moya Cc: spamfrommailing@pvanhoof.be, Rodney Dawes , Evolution Patches In-Reply-To: <1115180916.3589.41.camel@localhost> References: <1114613024.1502.98.camel@localhost.localdomain> <1114613505.20422.0.camel@cerler.home> <1115061869.8671.6.camel@localhost.localdomain> <1115180916.3589.41.camel@localhost> Content-Type: multipart/alternative; boundary="=-LzSiSyPN+1wRvPcaMP5q" Date: Wed, 04 May 2005 09:56:19 +0200 Message-Id: <1115193380.10358.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at erebus.freax.org X-Spam-Status: No, hits=-27.8 required=5.0 tests=EMAIL_ATTRIBUTION,HTML_30_40,HTML_MESSAGE,IN_REP_TO, REFERENCES,REPLY_WITH_QUOTES,SIGNATURE_LONG_SPARSE version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-LzSiSyPN+1wRvPcaMP5q Content-Type: text/plain Content-Transfer-Encoding: 7bit Done On Wed, 2005-05-04 at 06:28 +0200, Rodrigo Moya wrote: > On Mon, 2005-05-02 at 21:24 +0200, Philip Van Hoof wrote: > > I still need approval for this one ;-) > > > I guess just commit to HEAD please -- Philip Van Hoof, Software Developer @ Cronos home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org work: philip dot vanhoof at cronos dot be junk: philip dot vanhoof at gmail dot com http://www.pvanhoof.be/ --=-LzSiSyPN+1wRvPcaMP5q Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Done

On Wed, 2005-05-04 at 06:28 +0200, Rodrigo Moya wrote: 
On Mon, 2005-05-02 at 21:24 +0200, Philip Van Hoof wrote:
> I still need approval for this one ;-)
> 
I guess just commit to HEAD please

-- 
Philip Van Hoof, Software Developer @ Cronos
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
work: philip dot vanhoof at cronos dot be
junk: philip dot vanhoof at gmail dot com
http://www.pvanhoof.be/
--=-LzSiSyPN+1wRvPcaMP5q-- From kharish@novell.com Wed May 4 03:26:29 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 441FC1246DD; Wed, 4 May 2005 03:26:23 -0400 (EDT) Received: from stillness.blr.novell.com (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id A56D81246DD for ; Wed, 4 May 2005 03:26:10 -0400 (EDT) Received: by stillness.blr.novell.com (Postfix, from userid 1000) id 6C00AA6204; Wed, 4 May 2005 16:56:53 +0530 (IST) Subject: Re: [evolution-patches] evolution patch for hardcoded GAL version. From: Harish Krishnaswamy To: lists@munshi.biz Cc: evolution-patches@lists.ximian.com In-Reply-To: <4165.203.199.91.210.1114786511.squirrel@munshi.biz> References: <4165.203.199.91.210.1114786511.squirrel@munshi.biz> Content-Type: multipart/alternative; boundary="=-A7XQGo9rmYb8XI+w4a/3" Date: Wed, 04 May 2005 16:56:53 +0530 Message-Id: <1115206013.13157.1.camel@stillness.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.0 X-Spam-Status: No, hits=-23.3 required=5.0 tests=DATE_IN_FUTURE_03_06,EMAIL_ATTRIBUTION,HTML_20_30, HTML_MESSAGE,IN_REP_TO,QUOTED_EMAIL_TEXT, RCVD_IN_UNCONFIRMED_DSBL,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-A7XQGo9rmYb8XI+w4a/3 Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi Amish, approved and committed your patch. Welcome to the community of evolution hackers !! We do look forward for more of your contributions. -Harish On Fri, 2005-04-29 at 07:55 -0700, lists@munshi.biz wrote: > Hello All, > > Please check the patch, hope it is include in the CVS. > gal-2.4 was hardcoded in evolution-shell.pc.in and evolution-plugin.pc.in > Replaced it with gal-@GAL_PACKAGE@. > > This is my first patch in life, feeling great about it. Hope to do > something more useful next time. :-) > > Thanks rodrigo, pvanhoof and jpr for their help for this patch. > > Amish. --=-A7XQGo9rmYb8XI+w4a/3 Content-Type: text/html; charset=utf-8 Hi Amish,

  approved and committed your patch. Welcome to the community of evolution hackers !!
We do look forward for more of your contributions.

-Harish

On Fri, 2005-04-29 at 07:55 -0700, lists@munshi.biz wrote: 
Hello All,

Please check the patch, hope it is include in the CVS.
gal-2.4 was hardcoded in evolution-shell.pc.in and evolution-plugin.pc.in
Replaced it with gal-@GAL_PACKAGE@.

This is my first patch in life, feeling great about it. Hope to do
something more useful next time. :-)

Thanks rodrigo, pvanhoof and jpr for their help for this patch.

Amish.
--=-A7XQGo9rmYb8XI+w4a/3-- From un@gwava.com Wed May 4 03:44:10 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 04A211246DD; Wed, 4 May 2005 03:44:09 -0400 (EDT) Received: from BEG1.beginfinite.com (unknown [216.18.123.34]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "BEG1.beginfinite.com", Issuer "BEGINFINITETREE" (not verified)) by lists.ximian.com (Postfix) with ESMTP id ACBCA1243DF for ; Wed, 4 May 2005 03:43:57 -0400 (EDT) Received: from beg2dom-MTA by BEG1.beginfinite.com with Novell_GroupWise; Wed, 04 May 2005 07:42:40 -0400 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Date: Tue, 03 May 2005 19:18:19 -0400 From: "Ulrich Neumann" To: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartFFDCC8AB.0__=" X-Spam-Status: No, hits=2.0 required=5.0 tests=DATE_IN_PAST_06_12,HTML_20_30,HTML_MESSAGE, MSG_ID_ADDED_BY_MTA_3 version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Contact-editor UI issue Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__PartFFDCC8AB.0__= Content-Type: multipart/alternative; boundary="=__PartFFDCC8AB.1__=" --=__PartFFDCC8AB.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello,=20 =20 the attached patch fixes an UI issue with the ZIP/Postal Code=20 in the contact editor.=20 The xalign was wrong and resulted in an ugly view especially in=20 languages like german, dutch etc. where the name is much shorter.=20 =20 Cheers=20 =20 Uli=20 --=__PartFFDCC8AB.1__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Hello,
 
the attached patch fixes an UI issue with the ZIP/Postal Code
in the contact editor.
The xalign was wrong and resulted in an ugly view especially in
languages like german, dutch etc. where the name is much = shorter.
 
Cheers
 
Uli
--=__PartFFDCC8AB.1__=-- --=__PartFFDCC8AB.0__= Content-Type: application/octet-stream; name="contact-editor.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="contact-editor.diff" LS0tIGV2b2x1dGlvbi9hZGRyZXNzYm9vay9DaGFuZ2VMb2cgCTIwMDUtMDQtMjIgMTA6MDg6MTEu MDAwMDAwMDAwICswMjAwCisrKyBldm9sdXRpb24vYWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTIwMDUt MDUtMDQgMDE6MTM6MjAuMDAwMDAwMDAwICswMjAwCkBAIC0xLDMgKzEsOSBAQAorMjAwNS0wNS0w NCAgVWxyaWNoIE5ldW1hbm4gIDx1bGlAbXl1bGkuY29tPgorCisJKiBndWkvY29udGFjdC1lZGl0 b3IvY29udGFjdC1lZGl0b3IuZ2xhZGU6CisJRml4ZWQgd3JvbmcgeGFsaWduIG9mIFppcC9Qb3N0 YWwgQ29kZS4gVGhpcworCXdhcyB2ZXJ5IHVnbHkgaW4gbGFuZ3VhZ2VzIGxpa2UgZ2VybWFuLCBk dXRjaCBldGMuCisKIDIwMDUtMDQtMjEgIE1lbmdqaWUgWXUgIDxtZW5nLWppZS55dUBzdW4uY29t PgogCiAJKiBndWkvd2lkZ2V0cy9lLW1pbmljYXJkLXZpZXctd2lkZ2V0LmM6Ci0tLSBldm9sdXRp b24vYWRkcmVzc2Jvb2svZ3VpL2NvbnRhY3QtZWRpdG9yL2NvbnRhY3QtZWRpdG9yLmdsYWRlIAky MDA1LTAxLTIwIDA2OjQ5OjUzLjAwMDAwMDAwMCArMDEwMAorKysgZXZvbHV0aW9uL2FkZHJlc3Ni b29rL2d1aS9jb250YWN0LWVkaXRvci9jb250YWN0LWVkaXRvci5nbGFkZQkyMDA1LTA1LTA0IDAw OjA4OjI1LjAwMDAwMDAwMCArMDIwMApAQCAtMjczOCw3ICsyNzM4LDcgQEAKIAkJCSAgPHByb3Bl cnR5IG5hbWU9Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJv cGVydHkgbmFtZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0i c2VsZWN0YWJsZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWdu Ij4wPC9wcm9wZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+ CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9w ZXJ0eSBuYW1lPSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQi PjA8L3Byb3BlcnR5PgpAQCAtMzE0Myw3ICszMTQzLDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9 Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFt ZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJs ZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9w ZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxw cm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1l PSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3Bl cnR5PgpAQCAtMzUyNCw3ICszNTI0LDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9Imp1c3RpZnki PkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0id3JhcCI+ RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJsZSI+RmFsc2U8 L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9wZXJ0eT4KKwkJ CSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBu YW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ4cGFkIj4w PC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3BlcnR5Pgo= --=__PartFFDCC8AB.0__=-- From un@gwava.com Wed May 4 03:44:18 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id CE8C61246F4; Wed, 4 May 2005 03:44:18 -0400 (EDT) Received: from BEG1.beginfinite.com (unknown [216.18.123.34]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "BEG1.beginfinite.com", Issuer "BEGINFINITETREE" (not verified)) by lists.ximian.com (Postfix) with ESMTP id CD4BD1245F2 for ; Wed, 4 May 2005 03:44:06 -0400 (EDT) Received: from beg2dom-MTA by BEG1.beginfinite.com with Novell_GroupWise; Wed, 04 May 2005 07:43:27 -0400 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Date: Tue, 03 May 2005 20:17:52 -0400 From: "Ulrich Neumann" To: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartE6C5D1A0.0__=" X-Spam-Status: No, hits=2.0 required=5.0 tests=DATE_IN_PAST_06_12,HTML_20_30,HTML_MESSAGE, MSG_ID_ADDED_BY_MTA_3 version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Contact-editor UI issue Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__PartE6C5D1A0.0__= Content-Type: multipart/alternative; boundary="=__PartE6C5D1A0.1__=" --=__PartE6C5D1A0.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello,=20 =20 the attached patch fixes an UI issue with the ZIP/Postal Code=20 in the contact editor.=20 The xalign was wrong and resulted in an ugly view especially in=20 languages like german, dutch etc. where the name is much shorter.=20 =20 Cheers=20 =20 Uli=20 --=__PartE6C5D1A0.1__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Hello,
 
the attached patch fixes an UI issue with the ZIP/Postal= Code
in the contact editor.
The xalign was wrong and resulted in an ugly view = especially in
languages like german, dutch etc. where the name is = much shorter.
 
Cheers
 
Uli
--=__PartE6C5D1A0.1__=-- --=__PartE6C5D1A0.0__= Content-Type: application/octet-stream; name="contact-editor.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="contact-editor.diff" LS0tIGV2b2x1dGlvbi9hZGRyZXNzYm9vay9DaGFuZ2VMb2cgCTIwMDUtMDQtMjIgMTA6MDg6MTEu MDAwMDAwMDAwICswMjAwCisrKyBldm9sdXRpb24vYWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTIwMDUt MDUtMDQgMDE6MTM6MjAuMDAwMDAwMDAwICswMjAwCkBAIC0xLDMgKzEsOSBAQAorMjAwNS0wNS0w NCAgVWxyaWNoIE5ldW1hbm4gIDx1bGlAbXl1bGkuY29tPgorCisJKiBndWkvY29udGFjdC1lZGl0 b3IvY29udGFjdC1lZGl0b3IuZ2xhZGU6CisJRml4ZWQgd3JvbmcgeGFsaWduIG9mIFppcC9Qb3N0 YWwgQ29kZS4gVGhpcworCXdhcyB2ZXJ5IHVnbHkgaW4gbGFuZ3VhZ2VzIGxpa2UgZ2VybWFuLCBk dXRjaCBldGMuCisKIDIwMDUtMDQtMjEgIE1lbmdqaWUgWXUgIDxtZW5nLWppZS55dUBzdW4uY29t PgogCiAJKiBndWkvd2lkZ2V0cy9lLW1pbmljYXJkLXZpZXctd2lkZ2V0LmM6Ci0tLSBldm9sdXRp b24vYWRkcmVzc2Jvb2svZ3VpL2NvbnRhY3QtZWRpdG9yL2NvbnRhY3QtZWRpdG9yLmdsYWRlIAky MDA1LTAxLTIwIDA2OjQ5OjUzLjAwMDAwMDAwMCArMDEwMAorKysgZXZvbHV0aW9uL2FkZHJlc3Ni b29rL2d1aS9jb250YWN0LWVkaXRvci9jb250YWN0LWVkaXRvci5nbGFkZQkyMDA1LTA1LTA0IDAw OjA4OjI1LjAwMDAwMDAwMCArMDIwMApAQCAtMjczOCw3ICsyNzM4LDcgQEAKIAkJCSAgPHByb3Bl cnR5IG5hbWU9Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJv cGVydHkgbmFtZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0i c2VsZWN0YWJsZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWdu Ij4wPC9wcm9wZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+ CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9w ZXJ0eSBuYW1lPSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQi PjA8L3Byb3BlcnR5PgpAQCAtMzE0Myw3ICszMTQzLDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9 Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFt ZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJs ZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9w ZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxw cm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1l PSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3Bl cnR5PgpAQCAtMzUyNCw3ICszNTI0LDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9Imp1c3RpZnki PkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0id3JhcCI+ RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJsZSI+RmFsc2U8 L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9wZXJ0eT4KKwkJ CSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBu YW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ4cGFkIj4w PC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3BlcnR5Pgo= --=__PartE6C5D1A0.0__=-- From asarfraaz@novell.com Wed May 4 09:59:48 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 207441240C0; Wed, 4 May 2005 09:59:48 -0400 (EDT) Received: from nanclus.provo.novell.com (nanclus.provo.novell.com [137.65.81.53]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "nanclus.provo.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 20B4612441B for ; Wed, 4 May 2005 09:59:36 -0400 (EDT) Received: from PROVO4-MTA by nanclus.provo.novell.com with Novell_GroupWise; Wed, 04 May 2005 12:00:36 -0600 Message-Id: <4278D57F0200001200027C33@nanclus.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 6.7 Beta Date: Wed, 04 May 2005 12:00:31 -0600 From: "Ahmed Sarfraaz" To: , "Jain Vivek" Subject: Re: [evolution-patches] Patches to fix #273975 (evolution-exchange/calendar and e-d-s/calendar/backe Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Spam-Status: No, hits=0.0 required=5.0 tests=none version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: Both the patches look good to be committed. Guess, they can even make it = to the 2.2 branch. -- Sarfraaz From asarfraaz@novell.com Wed May 4 10:31:24 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 2BF0F1242FB; Wed, 4 May 2005 10:31:24 -0400 (EDT) Received: from nanclus.provo.novell.com (nanclus.provo.novell.com [137.65.81.53]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "nanclus.provo.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id D4C041240AD for ; Wed, 4 May 2005 10:31:12 -0400 (EDT) Received: from PROVO4-MTA by nanclus.provo.novell.com with Novell_GroupWise; Wed, 04 May 2005 12:32:12 -0600 Message-Id: <4278DCE80200001200027C44@nanclus.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 6.7 Beta Date: Wed, 04 May 2005 12:32:08 -0600 From: "Ahmed Sarfraaz" To: , "Jain Vivek" Subject: Re: [evolution-patches] patch to fix #273846 and #273878 (connector-calendar) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Spam-Status: No, hits=0.0 required=5.0 tests=none version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: Looks good for both 2.2 and HEAD. -- Sarfraaz Regards Sarfraaz Ahmed From hpj@novell.com Wed May 4 13:09:54 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id E1A7A124513; Wed, 4 May 2005 13:09:54 -0400 (EDT) Received: from lubyanka.copyleft.no (unknown [82.117.37.14]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id D316E12405C for ; Wed, 4 May 2005 13:09:40 -0400 (EDT) Received: from localhost ([82.117.37.14]) by lubyanka.copyleft.no (8.13.1/8.13.1) with ESMTP id j44LAJlD038756; Wed, 4 May 2005 23:10:30 +0200 (CEST) (envelope-from hpj@novell.com) Subject: Re: [evolution-patches] Contact-editor UI issue From: Hans Petter Jansson To: Ulrich Neumann Cc: evolution-patches@lists.ximian.com In-Reply-To: References: Content-Type: text/plain Organization: Novell, Inc. Date: Wed, 04 May 2005 16:08:20 -0500 Message-Id: <1115240900.7727.1.camel@avarice.monx> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 20:17 -0400, Ulrich Neumann wrote: > the attached patch fixes an UI issue with the ZIP/Postal Code > in the contact editor. > The xalign was wrong and resulted in an ugly view especially in > languages like german, dutch etc. where the name is much shorter. Looks good for both HEAD and 2.2. Thanks! -- Hans Petter Jansson | Evolution Developer | http://hp.cl.no/ From hpj@novell.com Wed May 4 13:34:13 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 6962212405B; Wed, 4 May 2005 13:34:13 -0400 (EDT) Received: from lubyanka.copyleft.no (unknown [82.117.37.14]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id A70CF12405C for ; Wed, 4 May 2005 13:34:01 -0400 (EDT) Received: from localhost ([82.117.37.14]) by lubyanka.copyleft.no (8.13.1/8.13.1) with ESMTP id j44LYq7U046467; Wed, 4 May 2005 23:34:55 +0200 (CEST) (envelope-from hpj@novell.com) Subject: Re: [evolution-patches] Address book: Fix for #268271 From: Hans Petter Jansson To: Sushma Rai Cc: Evolution Patches List In-Reply-To: <1115125791.1274.12.camel@linux.local> References: <1115125791.1274.12.camel@linux.local> Content-Type: text/plain Organization: Novell, Inc. Date: Wed, 04 May 2005 16:35:59 -0500 Message-Id: <1115242559.7727.4.camel@avarice.monx> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-25.3 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,SUBJ_HAS_UNIQ_ID version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 18:39 +0530, Sushma Rai wrote: > Attached a patch to form the attribute FN from N, if vcard has only name > attribute, and also handle BASE64 encoding. > These are valid according to vcard 2.1 specification. Looks good for HEAD. I assume you'll add to ChangeLog. -- Hans Petter Jansson | Evolution Developer | http://hp.cl.no/ From hpj@novell.com Wed May 4 14:38:28 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id B7B971243D2; Wed, 4 May 2005 14:38:28 -0400 (EDT) Received: from lubyanka.copyleft.no (unknown [82.117.37.14]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 5BD261243D2 for ; Wed, 4 May 2005 14:38:16 -0400 (EDT) Received: from localhost ([82.117.37.14]) by lubyanka.copyleft.no (8.13.1/8.13.1) with ESMTP id j44Md37j064627; Thu, 5 May 2005 00:39:08 +0200 (CEST) (envelope-from hpj@novell.com) Subject: Re: [evolution-patches] Address book: memory leak fixes From: Hans Petter Jansson To: Sushma Rai Cc: Evolution Patches List In-Reply-To: <1115124567.1251.4.camel@linux.local> References: <1115124567.1251.4.camel@linux.local> Content-Type: text/plain Organization: Novell, Inc. Date: Wed, 04 May 2005 17:40:09 -0500 Message-Id: <1115246409.7727.6.camel@avarice.monx> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 18:19 +0530, Sushma Rai wrote: > Attached patch fixes memory leaks in address book cache handling. Looks good for HEAD. Needs changelog. -- Hans Petter Jansson | Evolution Developer | http://hp.cl.no/ From rsushma@novell.com Wed May 4 23:05:34 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 95C9E1240C7; Wed, 4 May 2005 23:05:34 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 3B856124182 for ; Wed, 4 May 2005 23:05:21 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 6B5839D84F; Thu, 5 May 2005 12:42:58 +0530 (IST) From: Sushma Rai To: Evolution Patches List Cc: Harish K Content-Type: multipart/mixed; boundary="=-D5wUXl6VSmPD2RvtwcFj" Date: Thu, 05 May 2005 12:42:57 +0530 Message-Id: <1115277177.10390.4.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_UNCONFIRMED_DSBL version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Patch for memory leaks : Groupwise backend, calendar and address book Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-D5wUXl6VSmPD2RvtwcFj Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, Based on the valgrind output during the scalability testing.. fixed a few issues. Please review, -Sushma. --=-D5wUXl6VSmPD2RvtwcFj Content-Disposition: inline; filename=eds-memleaks.diff Content-Type: text/plain; name=eds-memleaks.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvZ25vbWUvZXZvbHV0 aW9uLWRhdGEtc2VydmVyL0NoYW5nZUxvZyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjU0DQpk aWZmIC11IC1wIC1yMS4yNTQgQ2hhbmdlTG9nDQotLS0gQ2hhbmdlTG9nCTQgTWF5IDIwMDUgMTI6 NTk6MjcgLTAwMDAJMS4yNTQNCisrKyBDaGFuZ2VMb2cJNSBNYXkgMjAwNSAwNjo0OToyNCAtMDAw MA0KQEAgLTEsMyArMSwxMyBAQA0KKzIwMDUtMDUtMDQgIFN1c2htYSBSYWkgPHJzdXNobWFAbm92 ZWxsLmNvbT4NCisNCisJKiBzZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWl0ZW0uYyANCisJKHNldF9j b250YWN0X2ZpZWxkc19mcm9tX3NvYXBfcGFyYW1ldGVyKTogRnJlZWluZyB2YWx1ZSwgDQorCXBv c3RhbF9hZGRyZXNzLg0KKwkoZV9nd19pdGVtX25ld19mcm9tX3NvYXBfcGFyYW1ldGVyKTogRnJl ZWluZyAidG8iLCBwcmlvcml0eS4NCisNCisJKiBzZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWNvbm5l Y3Rpb24uYw0KKwkoZV9nd19jb25uZWN0aW9uX2dldF9xdWlja19tZXNzYWdlcyk6IENoZWNraW5n IGZvciBOVUxMIHN0YXJ0IGRhdGUuDQorDQogMjAwNS0wNS0wNCAgUm9kcmlnbyBNb3lhIDxyb2Ry aWdvQG5vdmVsbC5jb20+DQogDQogCSogY29uZmlndXJlLmluOg0KSW5kZXg6IHNlcnZlcnMvZ3Jv dXB3aXNlL2UtZ3ctaXRlbS5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9s dXRpb24tZGF0YS1zZXJ2ZXIvc2VydmVycy9ncm91cHdpc2UvZS1ndy1pdGVtLmMsdg0KcmV0cmll dmluZyByZXZpc2lvbiAxLjc3DQpkaWZmIC11IC1wIC1yMS43NyBlLWd3LWl0ZW0uYw0KLS0tIHNl cnZlcnMvZ3JvdXB3aXNlL2UtZ3ctaXRlbS5jCTI2IEFwciAyMDA1IDEyOjQ4OjI1IC0wMDAwCTEu NzcNCisrKyBzZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWl0ZW0uYwk1IE1heSAyMDA1IDA2OjUwOjAz IC0wMDAwDQpAQCAtMTAyMyw2ICsxMDIzLDggQEAgc2V0X2NvbnRhY3RfZmllbGRzX2Zyb21fc29h cF9wYXJhbWV0ZXIgKA0KIAkJCXZhbHVlID0gc291cF9zb2FwX3BhcmFtZXRlcl9nZXRfc3RyaW5n X3ZhbHVlICh0ZW1wKTsNCiAJCQlpZiAodmFsdWUgJiYgKCFwcmltYXJ5X2VtYWlsIHx8ICAhZ19z dHJfZXF1YWwgKHByaW1hcnlfZW1haWwsIHZhbHVlKSkpDQogCQkJCWl0ZW0tPnByaXYtPmVtYWls X2xpc3QgPSBnX2xpc3RfYXBwZW5kIChpdGVtLT5wcml2LT5lbWFpbF9saXN0LCB2YWx1ZSk7DQor CQkJZWxzZQ0KKwkJCQlnX2ZyZWUgKHZhbHVlKTsNCiAJCX0NCiAJCWdfZnJlZSAocHJpbWFyeV9l bWFpbCk7DQogCX0NCkBAIC0xMTE3LDggKzExMTksOCBAQCBzZXRfY29udGFjdF9maWVsZHNfZnJv bV9zb2FwX3BhcmFtZXRlciAoDQogCQkJdmFsdWUgPSBzb3VwX3NvYXBfcGFyYW1ldGVyX2dldF9w cm9wZXJ0eSh0ZW1wLCAidHlwZSIpOw0KIAkJCWlmICh2YWx1ZSkNCiAJCQkJZ19oYXNoX3RhYmxl X2luc2VydCAoaXRlbS0+cHJpdi0+YWRkcmVzc2VzLCB2YWx1ZSwgYWRkcmVzcyk7DQotCQkJIAkJ CQ0KLQkJCQ0KKwkJCWVsc2UNCisJCQkJZnJlZV9wb3N0YWxfYWRkcmVzcyAoYWRkcmVzcyk7DQog CQl9DQogCQkNCiAJfQ0KQEAgLTE3MzAsOCArMTczMiw4IEBAIGVfZ3dfaXRlbV9uZXdfZnJvbV9z b2FwX3BhcmFtZXRlciAoY29uc3QNCiAJCX0gZWxzZSBpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcCAo bmFtZSwgInRvIikpIHsNCiAJCQljaGFyICp0byA7DQogCQkJdG8gPSBzb3VwX3NvYXBfcGFyYW1l dGVyX2dldF9zdHJpbmdfdmFsdWUgKGNoaWxkKSA7DQotCQkJZV9nd19pdGVtX3NldF90byAoaXRl bSx0bykgOw0KLQ0KKwkJCWVfZ3dfaXRlbV9zZXRfdG8gKGl0ZW0sIHRvKTsNCisJCQlnX2ZyZWUg KHRvKTsNCiAJCX0gZWxzZSBpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcCAobmFtZSwgImlDYWxJZCIp KQ0KIAkJCWl0ZW0tPnByaXYtPmljYWxpZCA9IHNvdXBfc29hcF9wYXJhbWV0ZXJfZ2V0X3N0cmlu Z192YWx1ZSAoY2hpbGQpOw0KIA0KQEAgLTE4MTQsNyArMTgxNiwxMSBAQCBlX2d3X2l0ZW1fbmV3 X2Zyb21fc29hcF9wYXJhbWV0ZXIgKGNvbnN0DQogCQkJaXRlbS0+cHJpdi0+cGxhY2UgPSBzb3Vw X3NvYXBfcGFyYW1ldGVyX2dldF9zdHJpbmdfdmFsdWUgKGNoaWxkKTsNCiANCiAJCWVsc2UgaWYg KCFnX2FzY2lpX3N0cmNhc2VjbXAgKG5hbWUsICJ0YXNrUHJpb3JpdHkiKSkgew0KLQkJCWVfZ3df aXRlbV9zZXRfdGFza19wcmlvcml0eSAoaXRlbSwgc291cF9zb2FwX3BhcmFtZXRlcl9nZXRfc3Ry aW5nX3ZhbHVlIChjaGlsZCkpOw0KKwkJCWNoYXIgKnByaW9yaXR5Ow0KKw0KKwkJCXByaW9yaXR5 ID0gc291cF9zb2FwX3BhcmFtZXRlcl9nZXRfc3RyaW5nX3ZhbHVlIChjaGlsZCk7DQorCQkJZV9n d19pdGVtX3NldF90YXNrX3ByaW9yaXR5IChpdGVtLCBwcmlvcml0eSk7DQorCQkJZ19mcmVlIChw cmlvcml0eSk7DQogCQl9DQogDQogCQllbHNlIGlmICghZ19hc2NpaV9zdHJjYXNlY21wIChuYW1l LCAic3RhcnREYXRlIikpIHsNCkluZGV4OiBzZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWNvbm5lY3Rp b24uYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvZ25vbWUvZXZvbHV0aW9uLWRhdGEtc2Vy dmVyL3NlcnZlcnMvZ3JvdXB3aXNlL2UtZ3ctY29ubmVjdGlvbi5jLHYNCnJldHJpZXZpbmcgcmV2 aXNpb24gMS4xMTMNCmRpZmYgLXUgLXAgLXIxLjExMyBlLWd3LWNvbm5lY3Rpb24uYw0KLS0tIHNl cnZlcnMvZ3JvdXB3aXNlL2UtZ3ctY29ubmVjdGlvbi5jCTcgQXByIDIwMDUgMTU6NDk6NTkgLTAw MDAJMS4xMTMNCisrKyBzZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWNvbm5lY3Rpb24uYwk1IE1heSAy MDA1IDA2OjUwOjE1IC0wMDAwDQpAQCAtMjEzMiw3ICsyMTMyLDcgQEAgRUd3Q29ubmVjdGlvblN0 YXR1cyBlX2d3X2Nvbm5lY3Rpb25fZ2V0Xw0KIA0KIAltc2cgPSBlX2d3X21lc3NhZ2VfbmV3X3dp dGhfaGVhZGVyIChjbmMtPnByaXYtPnVyaSwgY25jLT5wcml2LT5zZXNzaW9uX2lkLCAiZ2V0UXVp Y2tNZXNzYWdlc1JlcXVlc3QiKTsNCiAJZV9nd19tZXNzYWdlX3dyaXRlX3N0cmluZ19wYXJhbWV0 ZXIgKG1zZywgImxpc3QiLCBOVUxMLCBtZXNzYWdlX2xpc3QpOw0KLQlpZiAoc3RhcnRfZGF0ZSkN CisJaWYgKHN0YXJ0X2RhdGUgJiYgKnN0YXJ0X2RhdGUpDQogCQllX2d3X21lc3NhZ2Vfd3JpdGVf c3RyaW5nX3BhcmFtZXRlciAobXNnLCAic3RhcnREYXRlIiwgTlVMTCwgKnN0YXJ0X2RhdGUpOw0K IAlpZiAoY29udGFpbmVyKQ0KIAkJZV9nd19tZXNzYWdlX3dyaXRlX3N0cmluZ19wYXJhbWV0ZXIg KG1zZywgImNvbnRhaW5lciIsIE5VTEwsIGNvbnRhaW5lcik7DQpJbmRleDogYWRkcmVzc2Jvb2sv Q2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9sdXRpb24tZGF0 YS1zZXJ2ZXIvYWRkcmVzc2Jvb2svQ2hhbmdlTG9nLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4y NjUNCmRpZmYgLXUgLXAgLXIxLjI2NSBDaGFuZ2VMb2cNCi0tLSBhZGRyZXNzYm9vay9DaGFuZ2VM b2cJNCBNYXkgMjAwNSAwODo0NjoxMSAtMDAwMAkxLjI2NQ0KKysrIGFkZHJlc3Nib29rL0NoYW5n ZUxvZwk1IE1heSAyMDA1IDA2OjUwOjMzIC0wMDAwDQpAQCAtMSwzICsxLDggQEANCisyMDA1LTA1 LTA0ICBTdXNobWEgUmFpIDxyc3VzaG1hQG5vdmVsbC5jb20+DQorDQorCSogbGliZWRhdGEtYm9v ay9lLWJvb2stYmFja2VuZC1jYWNoZS5jIA0KKwkoZV9ib29rX2JhY2tlbmRfY2FjaGVfY29uc3Ry dWN0b3IpOiBGcmVlaW5nIGNhY2hlIGZpbGUgbmFtZS4NCisNCiAyMDA1LTA1LTA0ICBIYW5zIFBl dHRlciBKYW5zc29uICA8aHBqQG5vdmVsbC5jb20+DQogDQogCSogbGliZWJvb2svZS1hZGRyZXNz LXdlc3Rlcm4uYzoNCkluZGV4OiBhZGRyZXNzYm9vay9saWJlZGF0YS1ib29rL2UtYm9vay1iYWNr ZW5kLWNhY2hlLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1k YXRhLXNlcnZlci9hZGRyZXNzYm9vay9saWJlZGF0YS1ib29rL2UtYm9vay1iYWNrZW5kLWNhY2hl LmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjMNCmRpZmYgLXUgLXAgLXIxLjMgZS1ib29rLWJh Y2tlbmQtY2FjaGUuYw0KLS0tIGFkZHJlc3Nib29rL2xpYmVkYXRhLWJvb2svZS1ib29rLWJhY2tl bmQtY2FjaGUuYwkxMCBKYW4gMjAwNSAxMTo1MjowMyAtMDAwMAkxLjMNCisrKyBhZGRyZXNzYm9v ay9saWJlZGF0YS1ib29rL2UtYm9vay1iYWNrZW5kLWNhY2hlLmMJNSBNYXkgMjAwNSAwNjo1MDo1 NSAtMDAwMA0KQEAgLTE0Miw2ICsxNDIsNyBAQCBlX2Jvb2tfYmFja2VuZF9jYWNoZV9jb25zdHJ1 Y3RvciAoR1R5cGUgDQogew0KIAlHT2JqZWN0ICpvYmo7DQogCWNvbnN0IGNoYXIgKnVyaTsNCisJ Y2hhciAqY2FjaGVfZmlsZTsNCiAJRUJvb2tCYWNrZW5kQ2FjaGVDbGFzcyAqa2xhc3M7DQogCUdP YmplY3RDbGFzcyAqcGFyZW50X2NsYXNzOw0KIA0KQEAgLTE1NSw3ICsxNTYsMTAgQEAgZV9ib29r X2JhY2tlbmRfY2FjaGVfY29uc3RydWN0b3IgKEdUeXBlIA0KIAkvKiBleHRyYWN0IHVpZCAqLw0K IAlpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcCAoIGdfcGFyYW1fc3BlY19nZXRfbmFtZSAoY29uc3Ry dWN0X3Byb3BlcnRpZXMtPnBzcGVjKSwgInVyaSIpKSB7DQogCQl1cmkgPSBnX3ZhbHVlX2dldF9z dHJpbmcgKGNvbnN0cnVjdF9wcm9wZXJ0aWVzLT52YWx1ZSk7DQotCQlnX29iamVjdF9zZXQgKG9i aiwgImZpbGVuYW1lIiwgZ2V0X2ZpbGVuYW1lX2Zyb21fdXJpICh1cmkpLCBOVUxMKTsNCisJCWNh Y2hlX2ZpbGUgPSBnZXRfZmlsZW5hbWVfZnJvbV91cmkgKHVyaSk7DQorCQlpZiAoY2FjaGVfZmls ZSkNCisJCQlnX29iamVjdF9zZXQgKG9iaiwgImZpbGVuYW1lIiwgY2FjaGVfZmlsZSwgTlVMTCk7 DQorCQlnX2ZyZWUgKGNhY2hlX2ZpbGUpOw0KIAl9DQogDQogCXJldHVybiBvYmo7DQpJbmRleDog Y2FsZW5kYXIvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9s dXRpb24tZGF0YS1zZXJ2ZXIvY2FsZW5kYXIvQ2hhbmdlTG9nLHYNCnJldHJpZXZpbmcgcmV2aXNp b24gMS40NTMNCmRpZmYgLXUgLXAgLXIxLjQ1MyBDaGFuZ2VMb2cNCi0tLSBjYWxlbmRhci9DaGFu Z2VMb2cJNCBNYXkgMjAwNSAwNjo0NDozNiAtMDAwMAkxLjQ1Mw0KKysrIGNhbGVuZGFyL0NoYW5n ZUxvZwk1IE1heSAyMDA1IDA2OjUxOjE4IC0wMDAwDQpAQCAtMSwzICsxLDE1IEBADQorMjAwNS0w NS0wNCAgU3VzaG1hIFJhaSA8cnN1c2htYUBub3ZlbGwuY29tPg0KKw0KKwkqIGxpYmVkYXRhLWNh bC9lLWNhbC1iYWNrZW5kLWNhY2hlLmMgKGVfY2FsX2JhY2tlbmRfY2FjaGVfY29uc3RydWN0b3Ip Og0KKwlGcmVlaW5nIGNhY2hlIGZpbGUgbmFtZS4NCisNCisJKiBjYWxlbmRhci9iYWNrZW5kcy9n cm91cHdpc2UvZS1jYWwtYmFja2VuZC1ncm91cHdpc2UuYyAoZ2V0X2RlbHRhcyk6DQorCUNoZWNr aW5nIGZvciBzZXJ2ZXIgdGltZSB2YWx1ZSwgdGhvdWdoIHR5cGljYWxseSB0aGlzIHNob3VsZCBu ZXZlciBiZSBOVUxMLg0KKwkoZV9jYWxfYmFja2VuZF9ncm91cHdpc2VfZ2V0X29iamVjdF9saXN0 KTogVW5yZWYgY2JzZXhwLg0KKw0KKwkqIGNhbGVuZGFyL2JhY2tlbmRzL2ZpbGUvZS1jYWwtYmFj a2VuZC1maWxlLmMgDQorCShlX2NhbF9iYWNrZW5kX2ZpbGVfZ2V0X29iamVjdF9saXN0KShjcmVh dGVfdXNlcl9mcmVlX2J1c3kpOiBVbnJlZiBzZXhwLg0KKw0KIDIwMDUtMDUtMDQgIFJvZHJpZ28g TW95YSA8cm9kcmlnb0Bub3ZlbGwuY29tPg0KIA0KIAlGaXhlcyAjMzAwOTIwDQpJbmRleDogY2Fs ZW5kYXIvbGliZWRhdGEtY2FsL2UtY2FsLWJhY2tlbmQtY2FjaGUuYw0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT IGZpbGU6IC9jdnMvZ25vbWUvZXZvbHV0aW9uLWRhdGEtc2VydmVyL2NhbGVuZGFyL2xpYmVkYXRh LWNhbC9lLWNhbC1iYWNrZW5kLWNhY2hlLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjIwDQpk aWZmIC11IC1wIC1yMS4yMCBlLWNhbC1iYWNrZW5kLWNhY2hlLmMNCi0tLSBjYWxlbmRhci9saWJl ZGF0YS1jYWwvZS1jYWwtYmFja2VuZC1jYWNoZS5jCTI1IEZlYiAyMDA1IDA2OjM2OjUxIC0wMDAw CTEuMjANCisrKyBjYWxlbmRhci9saWJlZGF0YS1jYWwvZS1jYWwtYmFja2VuZC1jYWNoZS5jCTUg TWF5IDIwMDUgMDY6NTk6NTIgLTAwMDANCkBAIC0xNjYsOCArMTY2LDEyIEBAIGVfY2FsX2JhY2tl bmRfY2FjaGVfY29uc3RydWN0b3IgKEdUeXBlIHQNCiAgIA0KIAkvKiBleHRyYWN0IHVpZCAqLw0K IAlpZiAoIWdfYXNjaWlfc3RyY2FzZWNtcCAoIGdfcGFyYW1fc3BlY19nZXRfbmFtZSAoY29uc3Ry dWN0X3Byb3BlcnRpZXMtPnBzcGVjKSwgInVyaSIpKSB7DQorCQljaGFyICpjYWNoZV9maWxlOw0K Kw0KIAkJdXJpID0gZ192YWx1ZV9nZXRfc3RyaW5nIChjb25zdHJ1Y3RfcHJvcGVydGllcy0+dmFs dWUpOw0KLQkJZ19vYmplY3Rfc2V0IChvYmosICJmaWxlbmFtZSIsIGdldF9maWxlbmFtZV9mcm9t X3VyaSAodXJpKSwgTlVMTCk7DQorCQljYWNoZV9maWxlID0gZ2V0X2ZpbGVuYW1lX2Zyb21fdXJp ICh1cmkpOw0KKwkJZ19vYmplY3Rfc2V0IChvYmosICJmaWxlbmFtZSIsIGNhY2hlX2ZpbGUsIE5V TEwpOw0KKwkJZ19mcmVlIChjYWNoZV9maWxlKTsNCiAJfQ0KIA0KIAlyZXR1cm4gb2JqOw0KSW5k ZXg6IGNhbGVuZGFyL2JhY2tlbmRzL2dyb3Vwd2lzZS9lLWNhbC1iYWNrZW5kLWdyb3Vwd2lzZS5j DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9ldm9sdXRpb24tZGF0YS1zZXJ2ZXIv Y2FsZW5kYXIvYmFja2VuZHMvZ3JvdXB3aXNlL2UtY2FsLWJhY2tlbmQtZ3JvdXB3aXNlLmMsdg0K cmV0cmlldmluZyByZXZpc2lvbiAxLjE0Mw0KZGlmZiAtdSAtcCAtcjEuMTQzIGUtY2FsLWJhY2tl bmQtZ3JvdXB3aXNlLmMNCi0tLSBjYWxlbmRhci9iYWNrZW5kcy9ncm91cHdpc2UvZS1jYWwtYmFj a2VuZC1ncm91cHdpc2UuYwkxOCBBcHIgMjAwNSAxMzo0Njo1MyAtMDAwMAkxLjE0Mw0KKysrIGNh bGVuZGFyL2JhY2tlbmRzL2dyb3Vwd2lzZS9lLWNhbC1iYWNrZW5kLWdyb3Vwd2lzZS5jCTUgTWF5 IDIwMDUgMDc6MDA6MjIgLTAwMDANCkBAIC0xOTYsNiArMTk2LDcgQEAgZ2V0X2RlbHRhcyAoZ3Bv aW50ZXIgaGFuZGxlKQ0KIAljaGFyICpjb21wX3N0cjsNCiAJY2hhciAqdGltZV9zdHJpbmcgPSBO VUxMOw0KIAljaGFyIHRfc3RyIFsxMDBdOyANCisJY29uc3QgY2hhciAqc2Vydl90aW1lOw0KIAlz dHJ1Y3Qgc3RhdCBidWY7DQogCXN0YXRpYyBHU3RhdGljTXV0ZXggY29ubmVjdGluZyA9IEdfU1RB VElDX01VVEVYX0lOSVQ7DQogICAgICAgICANCkBAIC0yMTMsMjAgKzIxNCwyMyBAQCBnZXRfZGVs dGFzIChncG9pbnRlciBoYW5kbGUpDQogDQogCWdfc3RhdGljX211dGV4X2xvY2sgKCZjb25uZWN0 aW5nKTsNCiANCi0JZ19zdHJsY3B5ICh0X3N0ciwgZV9jYWxfYmFja2VuZF9jYWNoZV9nZXRfc2Vy dmVyX3V0Y190aW1lIChjYWNoZSksIDEwMCk7DQotCWlmICghKnRfc3RyIHx8ICFzdHJjbXAgKHRf c3RyLCAiIikpIHsNCi0JCWljYWx0aW1ldHlwZSB0ZW1wOw0KLQkJdGltZV90IGN1cnJlbnRfdGlt ZTsNCi0JCWNvbnN0IHN0cnVjdCB0bSAqdG07DQotDQotCQlnX3dhcm5pbmcgKCIgQ291bGQgbm90 IGdldCB0aGUgY29ycmVjdCB0aW1lIHN0YW1wIGZvciB1c2luZyBpbiBnZXRRdWljayBNZXNzYWdl c1xuIik7DQotCQl0ZW1wID0gaWNhbHRpbWVfY3VycmVudF90aW1lX3dpdGhfem9uZSAoaWNhbHRp bWV6b25lX2dldF91dGNfdGltZXpvbmUgKCkpOw0KLQkJY3VycmVudF90aW1lID0gaWNhbHRpbWVf YXNfdGltZXRfd2l0aF96b25lICh0ZW1wLCBpY2FsdGltZXpvbmVfZ2V0X3V0Y190aW1lem9uZSAo KSk7DQotCQl0bSA9IGdtdGltZSAoJmN1cnJlbnRfdGltZSk7DQotCQlzdHJmdGltZSAodF9zdHIs IDEwMCwgIiVZLSVtLSVkVCVIOiVNOiVTWiIsIHRtKTsNCisJc2Vydl90aW1lID0gZV9jYWxfYmFj a2VuZF9jYWNoZV9nZXRfc2VydmVyX3V0Y190aW1lIChjYWNoZSk7DQorCWlmIChzZXJ2X3RpbWUp IHsNCisJCWdfc3RybGNweSAodF9zdHIsIGVfY2FsX2JhY2tlbmRfY2FjaGVfZ2V0X3NlcnZlcl91 dGNfdGltZSAoY2FjaGUpLCAxMDApOw0KKwkJaWYgKCEqdF9zdHIgfHwgIXN0cmNtcCAodF9zdHIs ICIiKSkgew0KKwkJCWljYWx0aW1ldHlwZSB0ZW1wOw0KKwkJCXRpbWVfdCBjdXJyZW50X3RpbWU7 DQorCQkJY29uc3Qgc3RydWN0IHRtICp0bTsNCisNCisJCQlnX3dhcm5pbmcgKCIgQ291bGQgbm90 IGdldCB0aGUgY29ycmVjdCB0aW1lIHN0YW1wIGZvciB1c2luZyBpbiBnZXRRdWljayBNZXNzYWdl c1xuIik7DQorCQkJdGVtcCA9IGljYWx0aW1lX2N1cnJlbnRfdGltZV93aXRoX3pvbmUgKGljYWx0 aW1lem9uZV9nZXRfdXRjX3RpbWV6b25lICgpKTsNCisJCQljdXJyZW50X3RpbWUgPSBpY2FsdGlt ZV9hc190aW1ldF93aXRoX3pvbmUgKHRlbXAsIGljYWx0aW1lem9uZV9nZXRfdXRjX3RpbWV6b25l ICgpKTsNCisJCQl0bSA9IGdtdGltZSAoJmN1cnJlbnRfdGltZSk7DQorCQkJc3RyZnRpbWUgKHRf c3RyLCAxMDAsICIlWS0lbS0lZFQlSDolTTolU1oiLCB0bSk7DQorCQl9DQorCQl0aW1lX3N0cmlu ZyA9IGdfc3RyZHVwICh0X3N0cik7DQogCX0NCiANCi0JdGltZV9zdHJpbmcgPSBnX3N0cmR1cCAo dF9zdHIpOw0KIAlzdGF0dXMgPSBlX2d3X2Nvbm5lY3Rpb25fZ2V0X3F1aWNrX21lc3NhZ2VzIChj bmMsIGNiZ3ctPnByaXYtPmNvbnRhaW5lcl9pZCwgImF0dGFjaG1lbnRzIHJlY2lwaWVudHMgbWVz c2FnZSByZWNpcGllbnRTdGF0dXMgZGVmYXVsdCBwZWVrIiwgJnRpbWVfc3RyaW5nLCAiTmV3Iiwg IkNhbGVuZGFySXRlbSIsIE5VTEwsICAtMSwgICZpdGVtX2xpc3QpOw0KIAkNCiAJaWYgKHN0YXR1 cyA9PSBFX0dXX0NPTk5FQ1RJT05fU1RBVFVTX0lOVkFMSURfQ09OTkVDVElPTikNCkBAIC0xMTY5 LDYgKzExNzMsNyBAQCBlX2NhbF9iYWNrZW5kX2dyb3Vwd2lzZV9nZXRfb2JqZWN0X2xpc3QgDQog CQl9DQogICAgICAgICB9DQogDQorCWdfb2JqZWN0X3VucmVmIChjYnNleHApOw0KIAlnX2xpc3Rf Zm9yZWFjaCAoY29tcG9uZW50cywgKEdGdW5jKSBnX29iamVjdF91bnJlZiwgTlVMTCk7DQogCWdf bGlzdF9mcmVlIChjb21wb25lbnRzKTsNCiANCkluZGV4OiBjYWxlbmRhci9iYWNrZW5kcy9maWxl L2UtY2FsLWJhY2tlbmQtZmlsZS5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9nbm9tZS9l dm9sdXRpb24tZGF0YS1zZXJ2ZXIvY2FsZW5kYXIvYmFja2VuZHMvZmlsZS9lLWNhbC1iYWNrZW5k LWZpbGUuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTMNCmRpZmYgLXUgLXAgLXIxLjUzIGUt Y2FsLWJhY2tlbmQtZmlsZS5jDQotLS0gY2FsZW5kYXIvYmFja2VuZHMvZmlsZS9lLWNhbC1iYWNr ZW5kLWZpbGUuYwkyNCBGZWIgMjAwNSAxMDo1ODo1NyAtMDAwMAkxLjUzDQorKysgY2FsZW5kYXIv YmFja2VuZHMvZmlsZS9lLWNhbC1iYWNrZW5kLWZpbGUuYwk1IE1heSAyMDA1IDA3OjAwOjQyIC0w MDAwDQpAQCAtMTI1Miw2ICsxMjUyLDggQEAgZV9jYWxfYmFja2VuZF9maWxlX2dldF9vYmplY3Rf bGlzdCAoRUNhbA0KIAlnX2hhc2hfdGFibGVfZm9yZWFjaCAocHJpdi0+Y29tcF91aWRfaGFzaCwg KEdIRnVuYykgbWF0Y2hfb2JqZWN0X3NleHAsICZtYXRjaF9kYXRhKTsNCiANCiAJKm9iamVjdHMg PSBtYXRjaF9kYXRhLm9ial9saXN0Ow0KKw0KKwlnX29iamVjdF91bnJlZiAobWF0Y2hfZGF0YS5v Ympfc2V4cCk7DQogCQ0KIAlyZXR1cm4gR05PTUVfRXZvbHV0aW9uX0NhbGVuZGFyX1N1Y2Nlc3M7 CQ0KIH0NCkBAIC0xMjk1LDYgKzEyOTcsNyBAQCBlX2NhbF9iYWNrZW5kX2ZpbGVfc3RhcnRfcXVl cnkgKEVDYWxCYWNrDQogCQlnX2xpc3RfZm9yZWFjaCAobWF0Y2hfZGF0YS5vYmpfbGlzdCwgKEdG dW5jKSBnX2ZyZWUsIE5VTEwpOw0KIAkJZ19saXN0X2ZyZWUgKG1hdGNoX2RhdGEub2JqX2xpc3Qp Ow0KIAl9DQorCWdfb2JqZWN0X3VucmVmIChtYXRjaF9kYXRhLm9ial9zZXhwKTsNCiANCiAJZV9k YXRhX2NhbF92aWV3X25vdGlmeV9kb25lIChxdWVyeSwgR05PTUVfRXZvbHV0aW9uX0NhbGVuZGFy X1N1Y2Nlc3MpOw0KIH0NCkBAIC0xNDAzLDYgKzE0MDYsNyBAQCBjcmVhdGVfdXNlcl9mcmVlX2J1 c3kgKEVDYWxCYWNrZW5kRmlsZSAqDQogCQkJCQkJdmNhbGVuZGFyX2NvbXAsDQogCQkJCQkJcHJp di0+ZGVmYXVsdF96b25lKTsNCiAJfQ0KKwlnX29iamVjdF91bnJlZiAob2JqX3NleHApOw0KIA0K IAlyZXR1cm4gdmZiOwkNCiB9DQo= --=-D5wUXl6VSmPD2RvtwcFj-- From hpj@ximian.com Wed May 4 23:20:41 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 4404F1240D6; Wed, 4 May 2005 23:20:41 -0400 (EDT) Received: from lubyanka.copyleft.no (unknown [82.117.37.14]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id BD44D124048 for ; Wed, 4 May 2005 23:20:28 -0400 (EDT) Received: from localhost ([82.117.37.14]) by lubyanka.copyleft.no (8.13.1/8.13.1) with ESMTP id j457LF5f008980; Thu, 5 May 2005 09:21:25 +0200 (CEST) (envelope-from hpj@ximian.com) Subject: Re: [evolution-patches] Contact-editor UI issue From: Hans Petter Jansson To: Ulrich Neumann Cc: evolution-patches@lists.ximian.com In-Reply-To: References: Content-Type: text/plain Organization: Novell, Inc. Date: Thu, 05 May 2005 02:22:22 -0500 Message-Id: <1115277742.7727.8.camel@avarice.monx> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Tue, 2005-05-03 at 20:17 -0400, Ulrich Neumann wrote: > the attached patch fixes an UI issue with the ZIP/Postal Code > in the contact editor. > The xalign was wrong and resulted in an ugly view especially in > languages like german, dutch etc. where the name is much shorter. Looks good for both HEAD and 2.2. Thanks! -- Hans Petter Jansson | Evolution Developer | http://hp.cl.no/ From rodrigo@novell.com Wed May 4 23:55:50 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 978BF1241C2; Wed, 4 May 2005 23:55:50 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 1EBCC124009 for ; Wed, 4 May 2005 23:55:39 -0400 (EDT) Received: (qmail 17309 invoked from network); 5 May 2005 07:56:39 -0000 Received: from localhost (HELO ?164.99.152.230?) (127.0.0.1) by localhost with SMTP; 5 May 2005 07:56:39 -0000 Subject: Re: [evolution-patches] Patch for memory leaks : Groupwise backend, calendar and address book From: Rodrigo Moya To: Sushma Rai Cc: Evolution Patches List , Harish K In-Reply-To: <1115277177.10390.4.camel@linux.local> References: <1115277177.10390.4.camel@linux.local> Content-Type: text/plain Date: Thu, 05 May 2005 09:55:29 +0200 Message-Id: <1115279730.27314.9.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-26.1 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Thu, 2005-05-05 at 12:42 +0530, Sushma Rai wrote: > > plain text document attachment (eds-memleaks.diff) > Index: ChangeLog > =================================================================== > RCS file: /cvs/gnome/evolution-data-server/ChangeLog,v > retrieving revision 1.254 > diff -u -p -r1.254 ChangeLog > --- ChangeLog 4 May 2005 12:59:27 -0000 1.254 > +++ ChangeLog 5 May 2005 06:49:24 -0000 > @@ -1,3 +1,13 @@ > +2005-05-04 Sushma Rai > + > + * servers/groupwise/e-gw-item.c > + (set_contact_fields_from_soap_parameter): Freeing value, > + postal_address. > + (e_gw_item_new_from_soap_parameter): Freeing "to", priority. > + > + * servers/groupwise/e-gw-connection.c > + (e_gw_connection_get_quick_messages): Checking for NULL start date. > + servers/groupwise has its own ChangeLog, so this should be added to that one, not to the top level one. > 2005-05-04 Rodrigo Moya > @@ -1023,6 +1023,8 @@ set_contact_fields_from_soap_parameter ( > value = soup_soap_parameter_get_string_value (temp); > if (value && (!primary_email || !g_str_equal (primary_email, value))) > item->priv->email_list = g_list_append (item->priv->email_list, value); > + else > + g_free (value); > } hmm, AFAICS, the g_free should be in the if statement block, or out of both if/else. the calendar part looks ok though, so that can be committed. -- Rodrigo Moya From lviren@novell.com Thu May 5 02:03:33 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 1993F1242CB; Thu, 5 May 2005 02:03:33 -0400 (EDT) Received: from lucius.provo.novell.com (lucius.provo.novell.com [137.65.81.172]) by lists.ximian.com (Postfix) with ESMTP id C3E97124009 for ; Thu, 5 May 2005 02:03:20 -0400 (EDT) Received: from INET-PRV1-MTA by lucius.provo.novell.com with Novell_GroupWise; Thu, 05 May 2005 04:04:22 -0600 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Beta Date: Thu, 05 May 2005 04:04:06 -0600 From: "Viren L" To: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part3A190C86.0__=" X-Spam-Status: No, hits=-6.0 required=5.0 tests=PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] patch for bug# 228832 [calendar] Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part3A190C86.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline --=__Part3A190C86.0__= Content-Type: text/plain; name="228832.diff" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="228832.diff" Index: ChangeLog =================================================================== RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v retrieving revision 1.2714 diff -u -p -r1.2714 ChangeLog --- ChangeLog 18 Apr 2005 14:32:16 -0000 1.2714 +++ ChangeLog 5 May 2005 09:56:02 -0000 @@ -1,3 +1,10 @@ +2005-05-02 Viren.l + + Fixes #228832 + * gui/gnome-cal.c: (gnome_calendar_new_task):set appropriate values + for start and due date by calling icalcomponent_set_dtstart and + icalcomponent_set_due methods. + 2005-04-18 Chenthill Palanisamy Fixes #274476 Index: gui/gnome-cal.c =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/gnome-cal.c,v retrieving revision 1.372 diff -u -p -r1.372 gnome-cal.c --- gui/gnome-cal.c 7 Apr 2005 18:12:50 -0000 1.372 +++ gui/gnome-cal.c 5 May 2005 09:56:03 -0000 @@ -2783,12 +2783,14 @@ gnome_calendar_new_task (GnomeCalendar ECalComponent *comp; icalcomponent *icalcomp; const char *category; + time_t dtstart, dtdue; + struct icaltimetype itime; g_return_if_fail (gcal != NULL); g_return_if_fail (GNOME_IS_CALENDAR (gcal)); priv = gcal->priv; - + gnome_calendar_get_current_time_range(gcal,&dtstart,&dtdue); model = e_calendar_table_get_model (E_CALENDAR_TABLE (priv->todo)); ecal = e_cal_model_get_default_client (model); if (!ecal) @@ -2797,6 +2799,11 @@ gnome_calendar_new_task (GnomeCalendar tedit = task_editor_new (ecal, FALSE); icalcomp = e_cal_model_create_component_with_defaults (model); + itime = icaltime_from_timet_with_zone (dtstart, FALSE, calendar_config_get_icaltimezone()) ; + icalcomponent_set_dtstart(icalcomp, itime); + itime = icaltime_from_timet_with_zone (dtdue, FALSE, calendar_config_get_icaltimezone()); + icalcomponent_set_due (icalcomp, itime); + comp = e_cal_component_new (); e_cal_component_set_icalcomponent (comp, icalcomp); --=__Part3A190C86.0__=-- From fejj@novell.com Thu May 5 09:59:10 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id E98D6124515; Thu, 5 May 2005 09:59:10 -0400 (EDT) Received: from skeptopotamus.ximian.com (skeptopotamus.ximian.com [130.57.169.16]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "mail.cam.novell.com", Issuer "Equifax Secure Global eBusiness CA-1" (not verified)) by lists.ximian.com (Postfix) with ESMTP id B083D12426F for ; Thu, 5 May 2005 09:58:58 -0400 (EDT) Received: by skeptopotamus.ximian.com (Postfix) id 2BEEC64720; Wed, 4 May 2005 13:46:27 -0400 (EDT) Delivered-To: evolution-patches@ximian.com Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by skeptopotamus.ximian.com (Postfix) with ESMTP id 1B14364681 for ; Wed, 4 May 2005 13:46:27 -0400 (EDT) Received: (qmail 16096 invoked from network); 4 May 2005 17:46:26 -0000 Received: from outbound.ximian.com (HELO 164-99-120-36.boston.ximian.com) (130.57.170.250) by peabody.ximian.com with SMTP; 4 May 2005 17:46:26 -0000 Subject: Re: [evolution-patches] fix for bug #269129 From: Jeffrey Stedfast To: evolution-patches@ximian.com In-Reply-To: <1114194313.16080.7.camel@164-99-120-36.boston.ximian.com> References: <1114194313.16080.7.camel@164-99-120-36.boston.ximian.com> Content-Type: text/plain Organization: Novell, Inc. Date: Wed, 04 May 2005 13:45:50 -0400 Message-Id: <1115228750.22481.5.camel@164-99-120-36.boston.ximian.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-25.3 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,SUBJ_HAS_UNIQ_ID version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: *poke* On Fri, 2005-04-22 at 14:25 -0400, Jeffrey Stedfast wrote: > http://bugzilla.gnome.org/show_bug.cgi?id=269129 > > should be considered for both branches > > plain text document attachment (269129.patch) > Index: ChangeLog > =================================================================== > RCS file: /cvs/gnome/evolution/mail/ChangeLog,v > retrieving revision 1.3619 > diff -u -r1.3619 ChangeLog > --- ChangeLog 13 Apr 2005 03:32:58 -0000 1.3619 > +++ ChangeLog 21 Apr 2005 20:26:26 -0000 > @@ -1,3 +1,9 @@ > +2005-04-21 Jeffrey Stedfast > + > + * em-composer-utils.c (post_reply_to_message): Use the real folder > + and real uid (not the virtual if replying to a message in a > + vfolder). Fixes bug #269129. > + > 2005-04-12 Not Zed > > ** See bug #273752 > Index: em-composer-utils.c > =================================================================== > RCS file: /cvs/gnome/evolution/mail/em-composer-utils.c,v > retrieving revision 1.36 > diff -u -r1.36 em-composer-utils.c > --- em-composer-utils.c 8 Apr 2005 17:48:45 -0000 1.36 > +++ em-composer-utils.c 21 Apr 2005 20:26:26 -0000 > @@ -52,6 +52,7 @@ > #include > #include > #include > +#include > > static EAccount * guess_account (CamelMimeMessage *message, CamelFolder *folder); > > @@ -1958,15 +1959,29 @@ > const char *message_id, *references; > CamelInternetAddress *to; > EDestination **tov = NULL; > + CamelFolder *real_folder; > EMsgComposer *composer; > char *subject, *url; > EAccount *account; > + char *real_uid; > guint32 flags; > > if (message == NULL) > return; > > - account = guess_account (message, folder); > + if (CAMEL_IS_VEE_FOLDER (folder)) { > + CamelMessageInfo *info; > + > + info = camel_folder_get_message_info (folder, uid); > + real_folder = camel_vee_folder_get_location ((CamelVeeFolder *) folder, (struct _CamelVeeMessageInfo *) info, &real_uid); > + camel_folder_free_message_info (folder, info); > + } else { > + real_folder = folder; > + camel_object_ref (folder); > + real_uid = g_strdup (uid); > + } > + > + account = guess_account (message, real_folder); > flags = CAMEL_MESSAGE_ANSWERED | CAMEL_MESSAGE_SEEN; > > to = camel_internet_address_new(); > @@ -1991,7 +2006,7 @@ > > g_free (subject); > > - url = mail_tools_folder_to_url (folder); > + url = mail_tools_folder_to_url (real_folder); > e_msg_composer_hdrs_set_post_to ((EMsgComposerHdrs *) composer->hdrs, url); > g_free (url); > > @@ -2020,12 +2035,14 @@ > > composer_set_body (composer, message, NULL); > > - em_composer_utils_setup_callbacks (composer, folder, uid, flags, flags, NULL, NULL); > + em_composer_utils_setup_callbacks (composer, real_folder, real_uid, flags, flags, NULL, NULL); > > gtk_widget_show (GTK_WIDGET (composer)); > e_msg_composer_unset_changed (composer); > - > + > + camel_object_unref (real_folder); > camel_object_unref(to); > + g_free (real_uid); > } > > /** -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. fejj@ximian.com - www.novell.com From un@gwava.com Thu May 5 13:47:53 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 137EF1247F7; Thu, 5 May 2005 13:47:53 -0400 (EDT) Received: from BEG1.beginfinite.com (unknown [216.18.123.34]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "BEG1.beginfinite.com", Issuer "BEGINFINITETREE" (not verified)) by lists.ximian.com (Postfix) with ESMTP id B90431247FD for ; Thu, 5 May 2005 13:47:41 -0400 (EDT) Received: from beg2dom-MTA by BEG1.beginfinite.com with Novell_GroupWise; Thu, 05 May 2005 17:51:43 -0400 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Date: Thu, 05 May 2005 17:46:49 -0400 From: "Ulrich Neumann" To: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part9DBEA859.0__=" X-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_20_30,HTML_MESSAGE,MSG_ID_ADDED_BY_MTA_3 version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Who can commit patches? Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__Part9DBEA859.0__= Content-Type: multipart/alternative; boundary="=__Part9DBEA859.1__=" --=__Part9DBEA859.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi,=20 =20 i've submitted two small patches during the last week but I have anon CVS = only.=20 =20 Who can commit those patches for me?=20 =20 Attached are the patches again.=20 =20 Thanks=20 =20 Uli=20 --=__Part9DBEA859.1__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Hi,
 
i've submitted two small patches during the last week but I have = anon CVS only.
 
Who can commit those patches for me?
 
Attached are the patches again.
 
Thanks
 
Uli
--=__Part9DBEA859.1__=-- --=__Part9DBEA859.0__= Content-Type: application/octet-stream; name="contact-editor.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="contact-editor.diff" LS0tIGV2b2x1dGlvbi9hZGRyZXNzYm9vay9DaGFuZ2VMb2cgCTIwMDUtMDQtMjIgMTA6MDg6MTEu MDAwMDAwMDAwICswMjAwCisrKyBldm9sdXRpb24vYWRkcmVzc2Jvb2svQ2hhbmdlTG9nCTIwMDUt MDUtMDQgMDE6MTM6MjAuMDAwMDAwMDAwICswMjAwCkBAIC0xLDMgKzEsOSBAQAorMjAwNS0wNS0w NCAgVWxyaWNoIE5ldW1hbm4gIDx1bGlAbXl1bGkuY29tPgorCisJKiBndWkvY29udGFjdC1lZGl0 b3IvY29udGFjdC1lZGl0b3IuZ2xhZGU6CisJRml4ZWQgd3JvbmcgeGFsaWduIG9mIFppcC9Qb3N0 YWwgQ29kZS4gVGhpcworCXdhcyB2ZXJ5IHVnbHkgaW4gbGFuZ3VhZ2VzIGxpa2UgZ2VybWFuLCBk dXRjaCBldGMuCisKIDIwMDUtMDQtMjEgIE1lbmdqaWUgWXUgIDxtZW5nLWppZS55dUBzdW4uY29t PgogCiAJKiBndWkvd2lkZ2V0cy9lLW1pbmljYXJkLXZpZXctd2lkZ2V0LmM6Ci0tLSBldm9sdXRp b24vYWRkcmVzc2Jvb2svZ3VpL2NvbnRhY3QtZWRpdG9yL2NvbnRhY3QtZWRpdG9yLmdsYWRlIAky MDA1LTAxLTIwIDA2OjQ5OjUzLjAwMDAwMDAwMCArMDEwMAorKysgZXZvbHV0aW9uL2FkZHJlc3Ni b29rL2d1aS9jb250YWN0LWVkaXRvci9jb250YWN0LWVkaXRvci5nbGFkZQkyMDA1LTA1LTA0IDAw OjA4OjI1LjAwMDAwMDAwMCArMDIwMApAQCAtMjczOCw3ICsyNzM4LDcgQEAKIAkJCSAgPHByb3Bl cnR5IG5hbWU9Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJv cGVydHkgbmFtZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0i c2VsZWN0YWJsZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWdu Ij4wPC9wcm9wZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+ CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9w ZXJ0eSBuYW1lPSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQi PjA8L3Byb3BlcnR5PgpAQCAtMzE0Myw3ICszMTQzLDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9 Imp1c3RpZnkiPkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFt ZT0id3JhcCI+RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJs ZSI+RmFsc2U8L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9w ZXJ0eT4KKwkJCSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxw cm9wZXJ0eSBuYW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1l PSJ4cGFkIj4wPC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3Bl cnR5PgpAQCAtMzUyNCw3ICszNTI0LDcgQEAKIAkJCSAgPHByb3BlcnR5IG5hbWU9Imp1c3RpZnki PkdUS19KVVNUSUZZX0xFRlQ8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0id3JhcCI+ RmFsc2U8L3Byb3BlcnR5PgogCQkJICA8cHJvcGVydHkgbmFtZT0ic2VsZWN0YWJsZSI+RmFsc2U8 L3Byb3BlcnR5PgotCQkJICA8cHJvcGVydHkgbmFtZT0ieGFsaWduIj4wPC9wcm9wZXJ0eT4KKwkJ CSAgPHByb3BlcnR5IG5hbWU9InhhbGlnbiI+MTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBu YW1lPSJ5YWxpZ24iPjAuNTwvcHJvcGVydHk+CiAJCQkgIDxwcm9wZXJ0eSBuYW1lPSJ4cGFkIj4w PC9wcm9wZXJ0eT4KIAkJCSAgPHByb3BlcnR5IG5hbWU9InlwYWQiPjA8L3Byb3BlcnR5Pgo= --=__Part9DBEA859.0__= Content-Type: application/octet-stream; name="e-gw-sopt.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="e-gw-sopt.patch" LS0tIGV2b2x1dGlvbi1kYXRhLXNlcnZlci9zZXJ2ZXJzL2dyb3Vwd2lzZS9DaGFuZ2VMb2cJMjAw NS0wNC0yNiAxNDo0ODoyNS4wMDAwMDAwMDAgKzAyMDAKKysrIGV2b2x1dGlvbi1kYXRhLXNlcnZl ci9zZXJ2ZXJzL2dyb3Vwd2lzZS9DaGFuZ2VMb2cJMjAwNS0wNS0wMyAyMToyMDozMC4wMDAwMDAw MDAgKzAyMDAKQEAgLTEsMyArMSw4IEBACisyMDA1LTA1LTAzICBVbHJpY2ggTmV1bWFubiA8dWxp QG15dWxpLmNvbT4KKworCSogZS1ndy1zZW5kb3B0aW9ucy5jOiBGaXhlZCB0d28gbWVtb3J5IGxl YWtzIGluCisJICBFR3dTZW5kT3B0aW9uc1N0YXR1c1RyYWNraW5nKCkuCisKIDIwMDUtMDQtMjYg IFBhcnRoYXNhcmF0aGkgU3VzYXJsYSA8c3BhcnRoYXNhcmF0aGlAbm92ZWxsLmNvbT4KIAkqIGUt Z3ctaXRlbS5bY2hdOiBSZXZlcnRpbmcgcGF0Y2ggYWRkaW5nIGl0ZW1SZWZlcmVuY2UgCiAJICBp biB0aGUgRUd3SXRlbUF0dGFjaG1lbnQgc3RydWN0dXJlLgotLS0gZXZvbHV0aW9uLWRhdGEtc2Vy dmVyL3NlcnZlcnMvZ3JvdXB3aXNlL2UtZ3ctc2VuZG9wdGlvbnMuYwkyMDA1LTAyLTAzIDE1OjIx OjAzLjAwMDAwMDAwMCArMDEwMAorKysgZXZvbHV0aW9uLWRhdGEtc2VydmVyL3NlcnZlcnMvZ3Jv dXB3aXNlL2UtZ3ctc2VuZG9wdGlvbnMuYwkyMDA1LTA1LTAzIDAyOjUzOjA2LjAwMDAwMDAwMCAr MDIwMApAQCAtNDY4LDcgKzQ2OCw3IEBAIHNldF9zdGF0dXNfdHJhY2tpbmdfY2hhbmdlcyAoU291 cFNvYXBNZXMKIAkJY29tcF9uYW1lID0gZ19zdHJjb25jYXQgKGNvbXAsICJTdGF0dXNJbmZvIiwg TlVMTCk7CiAJCWVfZ3dfc2VuZG9wdGlvbnNfd3JpdGVfc2V0dGluZ3MgKG1zZywgY29tcF9uYW1l LCB2YWx1ZSwgTlVMTCwgVFJVRSk7CiAJCWdfZnJlZSAoY29tcF9uYW1lKSwgY29tcF9uYW1lID0g TlVMTDsKLQkJCisJCWdfZnJlZSAodmFsdWUpLCB2YWx1ZSA9IE5VTEw7CiAJfQogCQkKIAlpZiAo IXN0cmNtcCAoY29tcCwgIm1haWwiKSkgewpAQCAtNDgwLDYgKzQ4MCw3IEBAIHNldF9zdGF0dXNf dHJhY2tpbmdfY2hhbmdlcyAoU291cFNvYXBNZXMKIAkJCWNvbXBfbmFtZSA9IGdfc3RyY29uY2F0 IChjb21wLCAiQXV0b0RlbGV0ZSIsIE5VTEwpOwogCQkJZV9nd19zZW5kb3B0aW9uc193cml0ZV9z ZXR0aW5ncyAobXNnLCBjb21wX25hbWUsIHZhbHVlLCBOVUxMLCBUUlVFKTsKIAkJCWdfZnJlZSAo Y29tcF9uYW1lKSwgY29tcF9uYW1lID0gTlVMTDsKKwkJCWdfZnJlZSAodmFsdWUpLCB2YWx1ZSA9 IE5VTEw7CiAJCX0KIAl9CiAK --=__Part9DBEA859.0__=-- From un@gwava.com Thu May 5 14:28:35 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 3B16E124803; Thu, 5 May 2005 14:28:35 -0400 (EDT) Received: from BEG1.beginfinite.com (unknown [216.18.123.34]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "BEG1.beginfinite.com", Issuer "BEGINFINITETREE" (not verified)) by lists.ximian.com (Postfix) with ESMTP id BD9371247E2 for ; Thu, 5 May 2005 14:28:23 -0400 (EDT) Received: from beg2dom-MTA by BEG1.beginfinite.com with Novell_GroupWise; Thu, 05 May 2005 18:32:23 -0400 Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.4 Date: Thu, 05 May 2005 18:27:09 -0400 From: "Ulrich Neumann" To: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part604355AD.0__=" X-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_20_30,HTML_MESSAGE,MSG_ID_ADDED_BY_MTA_3 version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Patch to fix memory leak in e-gw-item.c Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=__Part604355AD.0__= Content-Type: multipart/alternative; boundary="=__Part604355AD.1__=" --=__Part604355AD.1__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi,=20 =20 attached is a patch that fixes a memory leak in get_notification_value().= =20 =20 If someone approves this platch please commit it as well, because I have = anonCVS=20 access only.=20 =20 Cheers=20 =20 Uli=20 --=__Part604355AD.1__= Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Description: HTML =20
Hi,
 
attached is a patch that fixes a memory leak in get_notification_valu= e().
 
If someone approves this platch please commit it as well, = because I have anonCVS
access only.
 
Cheers
 
Uli
--=__Part604355AD.1__=-- --=__Part604355AD.0__= Content-Type: application/octet-stream; name="e-gw-item.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="e-gw-item.diff" LS0tIGV2b2x1dGlvbi1kYXRhLXNlcnZlci9zZXJ2ZXJzL2dyb3Vwd2lzZS9DaGFuZ2VMb2cJMjAw NS0wNC0yNiAxNDo0ODoyNS4wMDAwMDAwMDAgKzAyMDAKKysrIGV2b2x1dGlvbi1kYXRhLXNlcnZl ci9zZXJ2ZXJzL2dyb3Vwd2lzZS9DaGFuZ2VMb2cJMjAwNS0wNS0wNiAwMDowNDoyNS4wMDAwMDAw MDAgKzAyMDAKQEAgLTEsMyArMSw3IEBACisyMDA1LTA1LTA2ICBVbHJpY2ggTmV1bWFubiA8dWxp QG15dWxpLmNvbT4KKworCSogZS1ndy1pdGVtLmM6IEZpeGVkIG1lbW9yeSBsZWFrIGluIGdldF9u b3RpZmljYXRpb25fdmFsdWUoKS4KKwogMjAwNS0wNC0yNiAgUGFydGhhc2FyYXRoaSBTdXNhcmxh IDxzcGFydGhhc2FyYXRoaUBub3ZlbGwuY29tPgogCSogZS1ndy1pdGVtLltjaF06IFJldmVydGlu ZyBwYXRjaCBhZGRpbmcgaXRlbVJlZmVyZW5jZSAKIAkgIGluIHRoZSBFR3dJdGVtQXR0YWNobWVu dCBzdHJ1Y3R1cmUuCi0tLSBldm9sdXRpb24tZGF0YS1zZXJ2ZXIvc2VydmVycy9ncm91cHdpc2Uv ZS1ndy1pdGVtLmMJMjAwNS0wNC0yNiAxNDo0ODoyNS4wMDAwMDAwMDAgKzAyMDAKKysrIGV2b2x1 dGlvbi1kYXRhLXNlcnZlci9zZXJ2ZXJzL2dyb3Vwd2lzZS9lLWd3LWl0ZW0uYwkyMDA1LTA1LTA2 IDAwOjAyOjE1LjAwMDAwMDAwMCArMDIwMApAQCAtNjI4LDggKzYyOCwxMiBAQCBnZXRfbm90aWZp Y2F0aW9uX3ZhbHVlIChTb3VwU29hcFBhcmFtZXRlCiAJCXN1YnBhcmFtID0gc291cF9zb2FwX3Bh cmFtZXRlcl9nZXRfZmlyc3RfY2hpbGRfYnlfbmFtZSAoc3VicGFyYW0sICJtYWlsIik7CiAJCWlm IChzdWJwYXJhbSkKIAkJCXZhbHVlID0gc291cF9zb2FwX3BhcmFtZXRlcl9nZXRfc3RyaW5nX3Zh bHVlIChzdWJwYXJhbSk7Ci0JCWlmICh2YWx1ZSAmJiAhZ19hc2NpaV9zdHJjYXNlY21wICh2YWx1 ZSwgIjEiKSkKKwkJaWYgKHZhbHVlICYmICFnX2FzY2lpX3N0cmNhc2VjbXAgKHZhbHVlLCAiMSIp KSB7CisJCQlnX2ZyZWUgKHZhbHVlKSwgdmFsdWUgPSBOVUxMOwogCQkJcmV0dXJuIEVfR1dfSVRF TV9OT1RJRllfTUFJTDsKKwkJfQorCQlpZiAodmFsdWUpCisJCQlnX2ZyZWUgKHZhbHVlKSwgdmFs dWUgPSBOVUxMOwogCX0KIAlyZXR1cm4gRV9HV19JVEVNX05PVElGWV9OT05FOwogfQo= --=__Part604355AD.0__=-- From jpr@novell.com Thu May 5 19:50:47 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 3EE2B124782; Thu, 5 May 2005 19:50:47 -0400 (EDT) Received: from lyle.provo.novell.com (lyle.provo.novell.com [137.65.81.174]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "imap.novell.com", Issuer "SERVICES2" (not verified)) by lists.ximian.com (Postfix) with ESMTP id 1BABD124742 for ; Thu, 5 May 2005 19:50:35 -0400 (EDT) Received: from bishop.blr.novell.com ([137.65.81.216]) by lyle.provo.novell.com; Thu, 05 May 2005 21:51:31 -0600 Subject: Re: [evolution-patches] Patch to fix memory leak in e-gw-item.c From: JP Rosevear To: Ulrich Neumann Cc: evolution-patches@lists.ximian.com In-Reply-To: References: Content-Type: text/plain Organization: Novell, Inc. Date: Fri, 06 May 2005 09:21:48 +0530 Message-Id: <1115351508.9688.275.camel@bishop.rosevear.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-22.9 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,REFERENCES,REPLY_WITH_QUOTES version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: On Thu, 2005-05-05 at 18:27 -0400, Ulrich Neumann wrote: > Hi, > > attached is a patch that fixes a memory leak in > get_notification_value(). Note that g_free actually does a NULL check itself, so the if (value) check is redundant. -JP -- JP Rosevear Novell, Inc. From rsushma@novell.com Thu May 5 21:10:29 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id A58C512401F; Thu, 5 May 2005 21:10:29 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id CA8F1124020 for ; Thu, 5 May 2005 21:10:14 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 499789D8A0; Fri, 6 May 2005 10:48:01 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-/bjyGBOEr3ZXVg7aH7cP" Date: Fri, 06 May 2005 10:48:00 +0530 Message-Id: <1115356680.14458.3.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=1.5 required=5.0 tests=RCVD_IN_UNCONFIRMED_DSBL,SUBJ_HAS_UNIQ_ID version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Exchange connector: Patch for #270363 Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-/bjyGBOEr3ZXVg7aH7cP Content-Type: text/plain Content-Transfer-Encoding: 7bit Corrected the message and marked for translation. Please review, Sushma. --=-/bjyGBOEr3ZXVg7aH7cP Content-Disposition: inline; filename=quota-msg.diff Content-Type: text/plain; name=quota-msg.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IHN0b3JhZ2UvZXhjaGFuZ2UtYWNjb3VudC5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog L2N2cy9nbm9tZS9ldm9sdXRpb24tZXhjaGFuZ2Uvc3RvcmFnZS9leGNoYW5nZS1hY2NvdW50LmMs dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjM5DQpkaWZmIC11IC1yMS4zOSBleGNoYW5nZS1hY2Nv dW50LmMNCi0tLSBzdG9yYWdlL2V4Y2hhbmdlLWFjY291bnQuYwkxMSBNYXIgMjAwNSAwNzo1MDoy MSAtMDAwMAkxLjM5DQorKysgc3RvcmFnZS9leGNoYW5nZS1hY2NvdW50LmMJMTEgTWFyIDIwMDUg MTM6MTE6MjcgLTAwMDANCkBAIC0xNTIzLDExICsxNTIzLDExIEBADQogCWlmIChnY3N0YXR1cyA9 PSBFMktfR0xPQkFMX0NBVEFMT0dfT0spIHsNCiANCiAJCWlmIChlbnRyeS0+cXVvdGFfbm9yZWN2 ICYmIGFjY291bnQtPm1ib3hfc2l6ZSA+PSBlbnRyeS0+cXVvdGFfbm9yZWN2KSB7DQotCQkJcXVv dGFfbXNnID0gZ19zdHJkdXBfcHJpbnRmICgiWW91IGhhdmUgZXhjZWVkZWQgeW91ciBxdW90YSBm b3Igc3RvcmluZyBtYWlscyBvbiB0aGlzIHNlcnZlci4gWW91ciBjdXJyZW50IHVzYWdlIGlzIDog JWQgLiBZb3Ugd2lsbCBub3QgYmUgYWJsZSB0byBlaXRoZXIgc2VuZCBvciByZWNpZXZlIG1haWxz IG5vd1xuIiwgZW50cnktPnF1b3RhX25vcmVjdik7DQorCQkJcXVvdGFfbXNnID0gZ19zdHJkdXBf cHJpbnRmIChfKCJZb3UgaGF2ZSBleGNlZWRlZCB5b3VyIHF1b3RhIG9mICVkICVzIGZvciBzdG9y aW5nIG1haWxzIG9uIHRoaXMgc2VydmVyLiBZb3VyIGN1cnJlbnQgdXNhZ2UgaXMgOiAlLjBmICVz LiBZb3Ugd2lsbCBub3QgYmUgYWJsZSB0byBlaXRoZXIgc2VuZCBvciByZWNpZXZlIG1haWxzIG5v d1xuIiksIGVudHJ5LT5xdW90YV9ub3JlY3YsICJLQiIsIGFjY291bnQtPm1ib3hfc2l6ZSwgIktC IiApOw0KIAkJfSBlbHNlIGlmIChlbnRyeS0+cXVvdGFfbm9zZW5kICYmIGFjY291bnQtPm1ib3hf c2l6ZSA+PSBlbnRyeS0+cXVvdGFfbm9zZW5kKSB7DQotCQkJcXVvdGFfbXNnID0gZ19zdHJkdXBf cHJpbnRmICgiWW91IGFyZSBuZWFyaW5nIHlvdXIgcXVvdGEgYXZhaWxhYmxlIGZvciBzdG9yaW5n IG1haWxzIG9uIHRoaXMgc2VydmVyLiBZb3VyIGN1cnJlbnQgdXNhZ2UgaXMgOiAlZCAuIFlvdSB3 aWxsIG5vdCBiZSBhYmxlIHRvIHNlbmQgbWFpbHMgdGlsbCB5b3UgY2xlYXIgdXAgc29tZSBzcGFj ZSBieSBkZWxldGluZyBzb21lIG1haWxzLlxuIiwgZW50cnktPnF1b3RhX25vc2VuZCk7DQorCQkJ cXVvdGFfbXNnID0gZ19zdHJkdXBfcHJpbnRmIChfKCJZb3UgYXJlIG5lYXJpbmcgeW91ciBxdW90 YSBvZiAlZCAlcyBmb3Igc3RvcmluZyBtYWlscyBvbiB0aGlzIHNlcnZlci4gWW91ciBjdXJyZW50 IHVzYWdlIGlzIDogJS4wZiAlcy4gWW91IHdpbGwgbm90IGJlIGFibGUgdG8gc2VuZCBtYWlscyB0 aWxsIHlvdSBjbGVhciB1cCBzb21lIHNwYWNlIGJ5IGRlbGV0aW5nIHNvbWUgbWFpbHMuXG4iKSwg ZW50cnktPnF1b3RhX25vc2VuZCwgIktCIiwgYWNjb3VudC0+bWJveF9zaXplLCAiS0IiKTsNCiAJ CX0gZWxzZSBpZiAoZW50cnktPnF1b3RhX3dhcm4gJiYgYWNjb3VudC0+bWJveF9zaXplID49IGVu dHJ5LT5xdW90YV93YXJuKSB7DQotCQkJcXVvdGFfbXNnID0gZ19zdHJkdXBfcHJpbnRmICgiWW91 IGFyZSBuZWFyaW5nIHlvdXIgcXVvdGEgYXZhaWxhYmxlIGZvciBzdG9yaW5nIG1haWxzIG9uIHRo aXMgc2VydmVyLiBZb3VyIGN1cnJlbnQgdXNhZ2UgaXMgOiAlZCAuIFRyeSB0byBjbGVhciB1cCBz b21lIHNwYWNlIGJ5IGRlbGV0aW5nIHNvbWUgbWFpbHMuXG4iLCBlbnRyeS0+cXVvdGFfd2Fybik7 DQorCQkJcXVvdGFfbXNnID0gZ19zdHJkdXBfcHJpbnRmIChfKCJZb3UgYXJlIG5lYXJpbmcgeW91 ciBxdW90YSBvZiAlZCAlcyBmb3Igc3RvcmluZyBtYWlscyBvbiB0aGlzIHNlcnZlci4gWW91ciBj dXJyZW50IHVzYWdlIGlzIDogJS4wZiAlcy4gVHJ5IHRvIGNsZWFyIHVwIHNvbWUgc3BhY2UgYnkg ZGVsZXRpbmcgc29tZSBtYWlscy5cbiIpLCBlbnRyeS0+cXVvdGFfd2FybiwgIktCIiwgYWNjb3Vu dC0+bWJveF9zaXplLCAiS0IiKTsNCiAJCX0NCiAJCQ0KIAkJaWYgKHF1b3RhX21zZykNCkluZGV4 OiBDaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1l eGNoYW5nZS9DaGFuZ2VMb2csdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI5NQ0KZGlmZiAtdSAt cjEuMjk1IENoYW5nZUxvZw0KLS0tIENoYW5nZUxvZwkxMSBNYXIgMjAwNSAwNzo1MDoyMSAtMDAw MAkxLjI5NQ0KKysrIENoYW5nZUxvZwkxMSBNYXIgMjAwNSAxMzoxMTozNyAtMDAwMA0KQEAgLTEs NCArMSw5IEBADQogMjAwNS0wMy0xMSAgU3VzaG1hIFJhaSAgPHJzdXNobWFAbm92ZWxsLmNvbT4N CisNCisJKiBzdG9yYWdlL2V4Y2hhbmdlLWFjY291bnQuYyAoZXhjaGFuZ2VfYWNjb3VudF9jb25u ZWN0KTogQ29ycmVjdGVkIHRoZQ0KKwlxdW90YSB3YXJuaW5nIG1lc3NhZ2UgYW5kIG1hcmtlZCBp dCBmb3IgdHJhbnNsYXRpb24uIEZpeGVzICM3MDM2My4NCisNCisyMDA1LTAzLTExICBTdXNobWEg UmFpICA8cnN1c2htYUBub3ZlbGwuY29tPg0KIAkNCiAJKiBzdG9yYWdlL2V4Y2hhbmdlLWFjY291 bnQuYyAoaXNfcGFzc3dvcmRfZXhwaXJlZCkNCiAJKGV4Y2hhbmdlX2FjY291bnRfc2V0X3Bhc3N3 b3JkKTogSWYga2VyYmVyb3MgY2FsbHMgd2l0aCB3aW5kb3dzIGRvbWFpbg0K --=-/bjyGBOEr3ZXVg7aH7cP-- From rsushma@novell.com Thu May 5 21:11:07 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id 1D277124020; Thu, 5 May 2005 21:11:07 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 5961412401D for ; Thu, 5 May 2005 21:10:55 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id F0FF89D7FA; Fri, 6 May 2005 10:48:40 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-fzdGIcJl/ngcFTCsAc5X" Date: Fri, 06 May 2005 10:48:40 +0530 Message-Id: <1115356720.14458.4.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=2.4 required=5.0 tests=DATE_IN_FUTURE_03_06,RCVD_IN_UNCONFIRMED_DSBL, SUBJ_HAS_UNIQ_ID version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Exchange connector: Patch for #274066 Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-fzdGIcJl/ngcFTCsAc5X Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, Even if the account was removed or disabled same warning message was getting printed. Please review. -Sushma. --=-fzdGIcJl/ngcFTCsAc5X Content-Disposition: inline; filename=warn-account-disable-74066.diff Content-Type: text/plain; name=warn-account-disable-74066.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IHN0b3JhZ2UvZXhjaGFuZ2UtY29uZmlnLWxpc3RlbmVyLmMNCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD UyBmaWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1leGNoYW5nZS9zdG9yYWdlL2V4Y2hhbmdlLWNv bmZpZy1saXN0ZW5lci5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNg0KZGlmZiAtdSAtcCAt cjEuMTYgZXhjaGFuZ2UtY29uZmlnLWxpc3RlbmVyLmMNCi0tLSBzdG9yYWdlL2V4Y2hhbmdlLWNv bmZpZy1saXN0ZW5lci5jCTI4IEZlYiAyMDA1IDE0OjU3OjI3IC0wMDAwCTEuMTYNCisrKyBzdG9y YWdlL2V4Y2hhbmdlLWNvbmZpZy1saXN0ZW5lci5jCTI2IE1hciAyMDA1IDA4OjI0OjMwIC0wMDAw DQpAQCAtODIzLDggKzgyMywxNCBAQCBhY2NvdW50X3JlbW92ZWQgKEVBY2NvdW50TGlzdCAqYWNj b3VudF9sDQogCQlwcml2LT5jb25maWd1cmVkX25hbWUgPSBOVUxMOw0KIAl9IGVsc2Ugew0KIAkJ LyogVGhlIGFjY291bnQgaXMgaW4gdXNlLiBXZSBjYW4ndCByZW1vdmUgaXQuICovDQotCQllX25v dGljZSAoTlVMTCwgR1RLX01FU1NBR0VfSU5GTywNCi0JCQkgIF8oIlRoZSBFeGNoYW5nZSBhY2Nv dW50IHdpbGwgYmUgcmVtb3ZlZCB3aGVuIHlvdSBxdWl0IEV2b2x1dGlvbiIpKTsNCisJCWlmIChh Y2NvdW50LT5lbmFibGVkKSANCisJCQllX25vdGljZSAoTlVMTCwgR1RLX01FU1NBR0VfSU5GTywN CisJCQkgIAlfKCJUaGUgRXhjaGFuZ2UgYWNjb3VudCB3aWxsIGJlIHJlbW92ZWQgd2hlbiB5b3Ug cXVpdCBFdm9sdXRpb24iKSk7DQorCQllbHNlIHsNCisJCQkvKiBhY2NvdW50IGlzIGRpc2FibGVk LCBub3QgcmVtb3ZlZCAqLw0KKwkJCWVfbm90aWNlIChOVUxMLCBHVEtfTUVTU0FHRV9JTkZPLA0K KwkJCQlfKCJUaGUgRXhjaGFuZ2UgYWNjb3VudCB3aWxsIGJlIGRpc2FibGVkIHdoZW4geW91IHF1 aXQgRXZvbHV0aW9uIikpOw0KKwkJfQ0KIAl9DQogfQ0KIA0K --=-fzdGIcJl/ngcFTCsAc5X-- From rsushma@novell.com Thu May 5 21:12:51 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id BCC0E12403E; Thu, 5 May 2005 21:12:51 -0400 (EDT) Received: from linux.local (unknown [202.144.86.147]) by lists.ximian.com (Postfix) with ESMTP id 23ACD12403B for ; Thu, 5 May 2005 21:12:39 -0400 (EDT) Received: by linux.local (Postfix, from userid 0) id 0AC149D45C; Fri, 6 May 2005 10:50:26 +0530 (IST) From: Sushma Rai To: Evolution Patches List Content-Type: multipart/mixed; boundary="=-irLIUpL+xBbSPo9pzy2d" Date: Fri, 06 May 2005 10:50:26 +0530 Message-Id: <1115356826.14508.6.camel@linux.local> Mime-Version: 1.0 X-Mailer: Evolution 2.3.0 X-Spam-Status: No, hits=1.6 required=5.0 tests=DATE_IN_FUTURE_03_06,RCVD_IN_UNCONFIRMED_DSBL version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] Exchange connector: Patch for 272514 Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-irLIUpL+xBbSPo9pzy2d Content-Type: text/plain Content-Transfer-Encoding: 7bit URL was included in the translatable message. -Sushma. --=-irLIUpL+xBbSPo9pzy2d Content-Disposition: inline; filename=i18n_url.diff Content-Type: text/plain; name=i18n_url.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IGxpYi9lMmstYXV0b2NvbmZpZy5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2cy9n bm9tZS9ldm9sdXRpb24tZXhjaGFuZ2UvbGliL2Uyay1hdXRvY29uZmlnLmMsdg0KcmV0cmlldmlu ZyByZXZpc2lvbiAxLjEwDQpkaWZmIC11IC1wIC1yMS4xMCBlMmstYXV0b2NvbmZpZy5jDQotLS0g bGliL2Uyay1hdXRvY29uZmlnLmMJMTAgRmViIDIwMDUgMTM6Mjc6MzggLTAwMDAJMS4xMA0KKysr IGxpYi9lMmstYXV0b2NvbmZpZy5jCTI0IEZlYiAyMDA1IDExOjI4OjMwIC0wMDAwDQpAQCAtMTM5 NSw3ICsxMzk1LDcgQEAgdmFsaWRhdGUgKGNvbnN0IGNoYXIgKm93YV91cmwsIGNoYXIgKnVzZQ0K IAlFMmtPcGVyYXRpb24gb3A7ICAgICAgICAvKiBGSVhNRSAqLw0KIAlFMmtBdXRvY29uZmlnUmVz dWx0IHJlc3VsdDsNCiAJZ2Jvb2xlYW4gdmFsaWQgPSBGQUxTRTsNCi0JY29uc3QgY2hhciAqb2xk LCAqbmV3Ow0KKwljb25zdCBjaGFyICpvbGQsICpuZXcsICp1cmw7DQogDQogCWFjID0gZTJrX2F1 dG9jb25maWdfbmV3IChvd2FfdXJsLCB1c2VyLCBwYXNzd29yZCwgDQogCQkJCSBFMktfQVVUT0NP TkZJR19VU0VfRUlUSEVSKTsNCkBAIC0xNDY5LDYgKzE0NjksNyBAQCB2YWxpZGF0ZSAoY29uc3Qg Y2hhciAqb3dhX3VybCwgY2hhciAqdXNlDQogCQkJYnJlYWs7DQogDQogCQljYXNlIEUyS19BVVRP Q09ORklHX0NBTlRfQlBST1BGSU5EOg0KKwkJCXVybCA9ICJodHRwOi8vc3VwcG9ydC5ub3ZlbGwu Y29tL2NnaS1iaW4vc2VhcmNoL3NlYXJjaHRpZC5jZ2k/L3hpbWlhbi94aW1pYW4zMjguaHRtbCI7 DQogCQkJZV9ub3RpY2UgKA0KIAkJCQlOVUxMLCBHVEtfTUVTU0FHRV9FUlJPUiwNCiAJCQkJXygi WGltaWFuIENvbm5lY3RvciByZXF1aXJlcyBhY2Nlc3MgdG8gY2VydGFpbiAiDQpAQCAtMTQ3OSw3 ICsxNDgwLDcgQEAgdmFsaWRhdGUgKGNvbnN0IGNoYXIgKm93YV91cmwsIGNoYXIgKnVzZQ0KIAkJ CSAgCSJ5b3UgdG8gYmUgYWJsZSB0byB1c2UgWGltaWFuIENvbm5lY3Rvci5cblxuIg0KIAkJCSAg CSJGb3IgaW5mb3JtYXRpb24gdG8gcHJvdmlkZSB0byB5b3VyIEV4Y2hhbmdlICINCiAJCQkgIAki YWRtaW5pc3RyYXRvciwgcGxlYXNlIGZvbGxvdyB0aGUgbGluayBiZWxvdzpcbiINCi0JCQkJImh0 dHA6Ly9zdXBwb3J0Lm5vdmVsbC5jb20vY2dpLWJpbi9zZWFyY2gvc2VhcmNodGlkLmNnaT8veGlt aWFuL3hpbWlhbjMyOC5odG1sICIpKTsNCisJCQkJIiVzIiksIHVybCk7DQogDQogCQkJdmFsaWQg PSBGQUxTRTsNCiAJCQlicmVhazsNCkluZGV4OiBDaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBm aWxlOiAvY3ZzL2dub21lL2V2b2x1dGlvbi1leGNoYW5nZS9DaGFuZ2VMb2csdg0KcmV0cmlldmlu ZyByZXZpc2lvbiAxLjI2NQ0KZGlmZiAtdSAtcCAtcjEuMjY1IENoYW5nZUxvZw0KLS0tIENoYW5n ZUxvZwkyMCBGZWIgMjAwNSAwNjo1Nzo0NiAtMDAwMAkxLjI2NQ0KKysrIENoYW5nZUxvZwkyNCBG ZWIgMjAwNSAxMjoxMDowMiAtMDAwMA0KQEAgLTEsMyArMSw4IEBADQorMjAwNS0wMi0yNCAgU3Vz aG1hIFJhaSAgPHJzdXNobWFAbm92ZWxsLmNvbT4NCisNCisJKiBsaWIvZTJrLWF1dG9jb25maWcu YyAodmFsaWRhdGUpOiBSZW1vdmVkIHRoZSBoYXJkIGNvZGVkIHN1cHBvcnQgdXJsDQorCWZyb20g dHJhbnNsYXRlYWJsZSBlcnJvciBtZXNzYWdlLiBGaXhlcyAjNzI1MTQNCisNCiAyMDA1LTAyLTIw ICBTdXNobWEgUmFpIDxyc3VzaG1hQG5vdmVsbC5jb20+DQogDQogCSogYWRkcmVzc2Jvb2svZS1i b29rLWJhY2tlbmQtZ2FsLmMgKGZ1bmNfaXNfb3JfYmVnaW5zX3dpdGgpOiBBbGxvd2luZw0K --=-irLIUpL+xBbSPo9pzy2d-- From notzed@ximian.com Thu May 5 21:52:01 2005 Return-Path: Received: by lists.ximian.com (Postfix, from userid 38) id B3D3F12400F; Thu, 5 May 2005 21:52:01 -0400 (EDT) Received: from peabody.ximian.com (peabody.ximian.com [130.57.169.10]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by lists.ximian.com (Postfix) with ESMTP id 5407712402F for ; Thu, 5 May 2005 21:51:50 -0400 (EDT) Received: (qmail 19573 invoked from network); 6 May 2005 05:52:50 -0000 Received: from localhost (HELO ?164.99.152.107?) (127.0.0.1) by localhost with SMTP; 6 May 2005 05:52:50 -0000 From: Not Zed To: asdf Content-Type: multipart/mixed; boundary="=-gnQP8uJgDvMPvAoddXrN" Date: Fri, 06 May 2005 11:25:25 +0530 Message-Id: <1115358926.15078.46.camel@lostzed.mmc.com.au> Mime-Version: 1.0 X-Mailer: Evolution 2.3.1 X-Spam-Status: No, hits=-5.1 required=5.0 tests=HTML_30_40,HTML_MESSAGE,PATCH_UNIFIED_DIFF version=2.53 X-Spam-Checker-Version: SpamAssassin 2.53 (1.174.2.15-2003-03-30-exp) Subject: [evolution-patches] i18n for eplugins Sender: evolution-patches-admin@lists.ximian.com Errors-To: evolution-patches-admin@lists.ximian.com X-BeenThere: evolution-patches@lists.ximian.com X-Mailman-Version: 2.0.13 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: patches against evolution go here List-Unsubscribe: , List-Archive: --=-gnQP8uJgDvMPvAoddXrN Content-Type: multipart/alternative; boundary="=-2qhoCND8bm8YynrH7Ouk" --=-2qhoCND8bm8YynrH7Ouk Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi guys, I've worked out a sane method for i18n for eplugins using similar mechanisms to other xml data. Including fixing the error stuff not to need e-error-tool anymore. Attached is a patch which should fix it all up for mailing-list-actions and the plugin-manager plugins. Several major changes: eplugin files should be stored in cvs to end in '.eplug.xml' rather than '.eplug.in'. This is so the i18n extractor knows it is an xml file. I could have chosen '.eplug.xml.in' which also works, but that seems to add unecessary mess. error files should now be stored in cvs to end in '.error.xml' rather than '.xml'. We now dynamically generate the i18n data, so the corresponding '.xml.h' files should be removed. It also greatly simplifies the Makefile.am foo. There is a slight problem in that you may have a clash with older error files which ended in '.xml' - e-error will just load all the files present in the errors directory - but that only affects people building unstable from source. Tags are no longer hard-coded for translation based on their name. Just use the <_tag _attribute="foo">bar syntax in the file. Where contents must retain whitespace, add the property xml:space="preserve" to the tag. e.g. in multi-line secondary error texts. All of the various 'xml' files - eplugin.xml, error.xml and the bonobo menu '.xml' files that have translatable strings just then get added to POTFILES.in as with any other source file. I _presume_ this will make make dist work ... :) Michael --=-2qhoCND8bm8YynrH7Ouk Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi guys,

I've worked out a sane method for i18n for eplugins using similar mechanisms to other xml data.  Including fixing the error stuff not to need e-error-tool anymore.

Attached is a patch which should fix it all up for mailing-list-actions and the plugin-manager plugins.

Several major changes:

eplugin files should be stored in cvs to end in '.eplug.xml'  rather than '.eplug.in'.  This is so the i18n extractor knows it is an xml file.  I could have chosen '.eplug.xml.in' which also works, but that seems to add unecessary mess.

error files should now be stored in cvs to end in '.error.xml' rather than '.xml'.  We now dynamically generate the i18n data, so the corresponding '.xml.h' files should be removed.  It also greatly simplifies the Makefile.am foo.  There is a slight problem in that you may have a clash with older error files which ended in '.xml' - e-error will just load all the files present in the errors directory - but that only affects people building unstable from source.  Tags are no longer hard-coded for translation based on their name.  Just use the <_tag _attribute="foo">bar</_tag> syntax in the file.

Where contents must retain whitespace, add the property  xml:space="preserve" to the tag.  e.g. in multi-line secondary error texts.

All of the various 'xml' files - eplugin.xml, error.xml and the bonobo menu '.xml' files that have translatable strings just then get added to POTFILES.in as with any other source file.

I _presume_ this will make make dist work ... :)

Michael


--=-2qhoCND8bm8YynrH7Ouk-- --=-gnQP8uJgDvMPvAoddXrN Content-Disposition: attachment; filename=eplugin-i18n-1.diff Content-Type: text/plain; name=eplugin-i18n-1.diff; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Index: ChangeLog =================================================================== RCS file: /cvs/gnome/evolution/ChangeLog,v retrieving revision 1.1460 diff -u -p -r1.1460 ChangeLog --- ChangeLog 5 May 2005 13:44:18 -0000 1.1460 +++ ChangeLog 6 May 2005 05:37:55 -0000 @@ -1,3 +1,9 @@ +2005-05-06 Not Zed + + * plugin.mk: changed .eplug rule to also convert i18n tags if it + ends in xml. Also convert .error.xml into .error converting i18n + tags. + 2005-05-05 Harish Krishnaswamy * configure.in: reset upgrade revision to 0 Index: plugin.mk =================================================================== RCS file: /cvs/gnome/evolution/plugin.mk,v retrieving revision 1.1 diff -u -p -r1.1 plugin.mk --- plugin.mk 20 Oct 2004 05:17:54 -0000 1.1 +++ plugin.mk 6 May 2005 05:37:55 -0000 @@ -1,2 +1,9 @@ %.eplug: %.eplug.in sed -e 's|\@PLUGINDIR\@|$(plugindir)|' $< > $@ + +%.eplug: %.eplug.xml + LC_ALL=C $(INTLTOOL_MERGE) -x -u /tmp $< - | \ + sed -e 's|\@PLUGINDIR\@|$(plugindir)|' > $@ + +%.error: %.error.xml + LC_ALL=C $(INTLTOOL_MERGE) -x -u /tmp $< $@ Index: plugins/mailing-list-actions/Makefile.am =================================================================== RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/Makefile.am,v retrieving revision 1.3 diff -u -p -r1.3 Makefile.am --- plugins/mailing-list-actions/Makefile.am 9 Nov 2004 18:23:56 -0000 1.3 +++ plugins/mailing-list-actions/Makefile.am 6 May 2005 05:37:55 -0000 @@ -10,15 +10,14 @@ plugin_LTLIBRARIES = liborg-gnome-mailin liborg_gnome_mailing_list_actions_la_SOURCES = mailing-list-actions.c liborg_gnome_mailing_list_actions_la_LDFLAGS = -module -avoid-version -error_DATA = org-gnome-mailing-list-actions-errors.xml -error_i18n = $(error_DATA:.xml=.xml.h) +error_DATA = org-gnome-mailing-list-actions.error errordir = $(privdatadir)/errors -%.xml.h: %.xml - $(top_builddir)/e-util/e-error-tool $^ -BUILT_SOURCES = $(error_i18n) +BUILT_SOURCES = \ + org-gnome-mailing-list-actions.eplug \ + org-gnome-mailing-list-actions.error + EXTRA_DIST = \ - $(error_DATA) \ - $(error_i18n) \ - org-gnome-mailing-list-actions.eplug.in \ + org-gnome-mailing-list-actions.eplug.xml \ + org-gnome-mailing-list-actions.error.xml \ org-gnome-mailing-list-actions.xml Index: plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml =================================================================== RCS file: plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml diff -N plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml --- plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml 17 Nov 2004 04:03:45 -0000 1.3 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,38 +0,0 @@ - - - - - Action not available - This message does not contain the header information required for this action. - - - - Posting not allowed - Posting to this mailing list is not allowed. Possibly, this is a read-only mailing list. Contact the list owner for details. - - - - Send e-mail message to mailing list? - An e-mail message will be sent to the URL "{0}". You can either send the message automatically, or see and change it first. - -You should receive an answer from the mailing list shortly after the message has been sent. -