[evolution-patches] Re: plz review the patch for bug #269685

[chen <pchenthill novell com>]

On Mon, 2005-08-29 at 07:23 -0400, Chakravarthi P wrote:
> +               ECalComponent *comp = e_cal_component_new ();
>  
> +               e_cal_component_set_icalcomponent (comp, l->data);

The component created is not freed.

> @@ -584,6 +594,11 @@ query_objects_changed_cb (ECal *client, 
>                 if (alarms == NULL || alarms->alarms == NULL) {
>                         if (alarms)
>                                 e_cal_component_alarms_free (alarms);
> +                       if (cqa && cqa->alarms) {
> +                               /* Update the comp with alarm and the
> cqa structure with the comp*/
> +                               cqa->alarms->comp =
> e_cal_component_clone (comp);
> +                               set_comp_queued_alarms (ca, uid, cqa);
> +                
The alarms or alarms->alarms is NULL here, causing the problem which
should be fixed.

thanks, Chenthill.