Re: Removing _construct functions when fixing _new() functions.



murrayc t-online de (Murray Cumming) writes:

> I have 3 patches here
> http://bugzilla.gnome.org/show_bug.cgi?id=77225
> to make libbonoboui's various widgets' *_new() functions into mere
> convenience wrappers for g_object_new(). This is achieved by adding
> properties. That's what's they're supposed to be, for the sake of
> language bindings and glade.
> 
> While doing this I've removed the old *_construct() functions. They were
> the GTK1.2 way to solve this problem.
> 
> Officially, this breaks API, but only language bindings (not many for
> libbonoboui yet) and glade (doesn't seem to affect it yet) are going to
> notice, and they should stop using *_construct() anyway. It doesn't make
> much difference, but when *_construct() are removed it makes it easier
> to see that libbonoboui does things properly.

Not really my place to say this here, but I think we need to really be
strict and say that we don't make incompatible API changes within a 
stable API. Ever. Even if we think that nobody could/should be using the API.

And especially not just as a cleanup.

Regards,
                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]