Re: [gnome-db] New patch. Closes bug #68577

[Rodrigo Moya <rodrigo gnome-db org>]

On Thu, 2002-01-17 at 21:11, Gonzalo Paniagua Javier wrote:
> 	Here it is. Smaller than the preceding. Works ok.
> 
> 	I've also added documentation for gda-command.
> 
please go ahead and commit. Only some comments:

> +
> +/**
> + * gda_command_get_command_option
>
could you rename it gda_command_get_options? This is because it makes
sense to add more options to the enum, and still use the same field (an
OR'ed flag value).

> + * gda_command_set_command_option
> 
the same, please rename it to gda_command_set_options
		
>  			status = PQresultStatus(pg_res);
> -			if (status == PGRES_TUPLES_OK ||
> +			if (option == GDA_COMMAND_OPTION_IGNORE_ERRORS	||
>
and here, use:

if (option & GDA_COMMAND_OPTION_IGNORE_ERRORS)...

so that future changes to the enum don't affect that part of the code.

cheers
-- 
Rodrigo Moya <rodrigo gnome-db org> - <rodrigo ximian com>
http://www.gnome-db.org/ - http://www.ximian.com/