Re: Committed patches

[Peter Williams <peter newton cx>]

One little thing I happened to note at the very top of the patch:

> --- configure.in	28 Oct 2005 20:37:36 -0000	1.192
> +++ configure.in	30 Nov 2005 15:01:49 -0000
> @@ -54,6 +54,8 @@
>  [
>  	gconf-2.0
>  	gnome-doc-utils >= 0.3.1
> +        libgnomeprint-2.2,
> +        libgnomeprintui-2.2,
>  	gnome-vfs-2.0 >= 1.1
>  	gtk+-2.0 >= 2.5.3
>  	libbonobo-2.0 >= 1.108.0

Shouldn't be any commas at the end of the new lines.

Peter

On Sat, 2005-12-10 at 15:28 +0000, Don Scorgie wrote:
> Hey all,
> 
> With shaunm's permission (or something approaching that), I have just
> committed a big patch that should improve info page support a fair bit.
> 
> As smitten pointed out on IRC, 2.13.3 is due on the 12th (Monday).  To
> this end, I would like to propose adding printing support [1][2] for
> this.  The patch has been reviewed by Christian Persch (mostly the gecko
> parts).
> 
> Any comments / suggestions / reasons for committal / reasons for
> non-committal?
> 
> Cheers
> Don
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=126456
> [2] http://bugzilla.gnome.org/attachment.cgi?id=55426&action=view
> 
> _______________________________________________
> gnome-doc-devel-list mailing list
> gnome-doc-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-doc-devel-list
> 
> 
-- 
Peter Williams / peter newton cx