Re: just some patches..

[Timo Sirainen <aaaaaa sicom fi>]

On Wed, 27 May 1998, Martin Baulig wrote:

> >  libobgnome_la_LDFLAGS = -version-info 0:0:0 -rpath $(libdir) -lobjc
> > -libobgnome_la_LIBADD = $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)
> > +libobgnome_la_LIBADD = $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)
> 
> I'm just trying to find out what exactly these patches do; on my system
> this would be:
> 
> GNOMEUI_LIBS = -lgnomeui -lgnome -lgnomesupport -ldl -lgdk_imlib -ltiff
> - -lz -ljpeg -ljpeg -lpng -lz -lSM -lICE -L/home/baulig/INSTALL/lib
> - -L/usr/X11R6/lib -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm
> 
> GNOME_LIBS = -lgnome -lgnomesupport -ldl
> 
> GTK_LIBS = -lSM -lICE -L/home/baulig/INSTALL/lib -L/usr/X11R6/lib
> - -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm
> 
> GNOME_LIBDIR = -L/home/baulig/INSTALL/lib
> 
> Sorry, I can't see any reason for this chunk; it seems that it throws
> away things that are needed.

I don't have GTK libs in same dir as GNOME libs so my linker doesn't find
gnome libs without adding that $(GNOME_LIBDIR) there..

> >  obgnome_hello_LDADD = \
> > -       libobgnome.la ../obgtk/libobgtk.la $(GNOMEUI_LIBS) $(GNOME_LIBS) \
> > +       libobgnome.la ../obgtk/libobgtk.la $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) \
> >         -lgtktty $(GTK_LIBS) $(OBJC_LIBS) $(INTLLIBS)
> 
> You use $(GTK_LIBS) here, but you put them out above ?

Put out? .. Only things I've done is added that $(GNOME_LIBDIR) to start
of both lines.

> > -INCLUDES = $(GTK_CFLAGS) $(X_CFLAGS)   \
> > +INCLUDES = $(GNOME_INCLUDEDIR) $(GTK_CFLAGS) $(X_CFLAGS)       \
> >            -I$(top_srcdir)              \
> >            -I$(top_srcdir)/widgets
..
> Ok, this may be reasonable.
> 
> Well, in general patches should only be applied is there's any actual
> reason for them - could you please be a little more specific about this
> and also provide a ChangeLog entry ?

I hate those ChangeLogs :) Hm. Some how's this:

gnome-admin/gxsnmp/ChangeLog:

Wed May 27 12:16:00 EEST 1998 Timo Sirainen <a@sicom.fi>

	* widgets/Makefile.am (INDLUDES) : Added $(GNOME_INCLUDEDIR)

And for gnome-objc same except $(GNOME_LIBDIR) ? :)