Re: [sigc] Implementatoin in .cc file

[Martin Schulze <martin-ml hippogriff de>]

Am 2004.02.14 17:20 schrieb(en) Murray Cumming:
> On Sat, 2004-02-14 at 09:19, Martin Schulze wrote:
> > Am 2004.02.13 19:54 schrieb(en) Murray Cumming:
> > > On Fri, 2004-02-13 at 12:57, Martin Schulze wrote:
> > > > Am 2004.02.10 15:30 schrieb(en) Murray Cumming:
> > > > > I noticed that libsigc++ 2 has some method implementation in
> the
> > > .h
> > > > > files - for instance slot_base in slot.h. This should be in a
> .cc
> > > > > file.
> > > > > I'll try to get around to fixing it.
> > > >
> > > > Then we need a benchmark to see the performance drop of having
> > > these
> > > > functions non-inline!
> > >
> > > Maybe. Note that anything already marked as inline with the  
> inline
> > > keyword will stay inline. I'm checking some changes in now.
> >
> > Ah, I wasn't aware of that! Then the functions we move into the
> > implementation files should probably all be marked as inline.
>
> You want to make everything inline? I'm not sure that that is wise or
> that it will make any difference, but you are the maintainer.

The problem is that I don't have a c++ book at hand. Could you
please make clear whether in an optimized build gcc automatically
marks member functions that are implemented in the class definition
as inline? I.e. are the functions in slot_base and so on currently
inline?

As a general rule I like having "one-line" functions inline and in
the case of sigc++ also most short functions that get executed during
signal emission and connection/disconnection of slots.

Regards,

 Martin