Re: [PATCH] Multi-VC chooser preferences

[Stephen Kennedy <stevek gnome org>]

Ah that's super! I think we're on the same page on this one. You've
got my vote to commit.

Looks like the history entry has some extra padding which accounts for
the size strangeness.
I've modified it to remove an unused vbox (see patch) and it's now the
same size here.
It's a pity that custom python widget support in glade isn't better.

Stephen.

On Thu, Mar 5, 2009 at 7:03 PM, Vincent Legoll <vincent legoll gmail com> wrote:
> Hello,
> here is a first step in the hopefully right direction.
>
> A combobox is added at the left side of the location
> text entry & button.
>
> But I have a hard time giving that combobox the same
> size as the text entry and the button...
>
> The problem is far more visible on my gentoo desktop
> than on the ubuntu notebook, but could be better.
>
> Tell me what you think of this one.
>
> --
> Vincent Legoll
>

Index: historyentry.py
===================================================================
--- historyentry.py	(revision 1218)
+++ historyentry.py	(working copy)
@@ -219,7 +219,7 @@
         return os.path.join(os.getcwd(), filename)
 
 
-class HistoryFileEntry(gtk.VBox, gtk.Editable):
+class HistoryFileEntry(gtk.HBox, gtk.Editable):
     __gsignals__ = {
         "browse_clicked" : (gobject.SIGNAL_RUN_LAST, gobject.TYPE_NONE, []),
         "activate" : (gobject.SIGNAL_RUN_LAST, gobject.TYPE_NONE, [])
@@ -239,22 +239,17 @@
 
         self.set_spacing(4)
 
-        # Allow for a preview thingie to be smacked on top of the file entry
-        hbox = gtk.HBox(False, 4)
-        hbox.show()
-        self.pack_end(hbox, False, False, 0)
-
         self.gtk_entry.connect("changed", self.__entry_changed_signal)
         self.gtk_entry.connect("activate", self.__entry_activate_signal)
 
         self._setup_dnd()
 
-        hbox.pack_start(self.__gentry, True, True, 0)
+        self.pack_start(self.__gentry, True, True, 0)
         self.__gentry.show()
 
         button = gtk.Button(_("_Browse..."))
         button.connect("clicked", self.__browse_clicked)
-        hbox.pack_start(button, False, False, 0)
+        self.pack_start(button, False, False, 0)
         button.show()
 
         access_entry = self.__gentry.get_accessible()