Re: meld filename scans entire tree

[Grant Edwards <grant b edwards gmail com>]

On 2010-04-25, Peter Tyser <ptyser gmail com> wrote:
> On Sat, Apr 24, 2010 at 11:02 PM, Kai Willadsen <kai willadsen gmail com> wrote:
>> On 22 April 2010 03:51, Grant Edwards <grant b edwards gmail com> wrote:
>>
>>> Recently I noticed that I can no longer look at the changes I've made
>>> to a single file under SVN control by doing "meld filename".  I swear
>>> that used to just show me the changes for the specified file.
>>
>> Do you mean that this doesn't work, or that it does work, but also
>> uselessly scans the directory tree? From my testing, this works in git
>> (modulo the scanning).
>
> I also see the behavior Kai describes - "meld $FILE" works as
> expected, it just unnecessarily scans the rest of the repository.

That's the behavior I see as well.  Where we differ is the definition
of "as expected".  When I ask for diffs on a signle file, I didn't
expect it to spend the next 5 minutes scanning a gigabyte of other
files.

> Would it be sufficient to not call _search_recursively_iter() in
> meld/vcview.py:_set_location() when a file was given on the command
> line?  A quick test indicates it gives the desired result, but the
> flow of a single file diff is difficult for me to wrap my head around
> and its unclear if this is the "right" way to fix it (ie, its probably
> not:).  I'll send a patch with my workaround for review.

I'll spend some time looking at it tomorrow.

-- 
Grant