Re: [Setup-tool-hackers] XST-Time-Warnings-Fix

[Chema Celorio <chema ximian com>]

Thanks for the patch, a couple of comments:

This change is not needed:

 	if (GTK_WIDGET_HAS_FOCUS (tool->seconds))
 	    gtk_editable_select_region (GTK_EDITABLE (tool->seconds),
-					start_pos, end_pos);
+	    start_pos, end_pos);


Don't leave unneeded code around:

+        /* Removed because it is not needed by GtkSpinButton --AleX
+        gtk_signal_connect (GTK_OBJECT (spin), "spin_up",
 			    GTK_SIGNAL_FUNC (xst_time_spin_up),
 			    tool);
 	gtk_signal_connect (GTK_OBJECT (spin), "spin_down",
 			    GTK_SIGNAL_FUNC (xst_time_spin_down),
 			    tool);
+	*/
 
 	return spin;
 }

This comment is also unneeded, it will look obsolete soon. I mean nobody needs
to rember that before we didn't included the max number:

+	/* Modified to include max number --AleX */

+	tool->seconds = xst_time_spin_button_create (tool, 60);
+	tool->minutes = xst_time_spin_button_create (tool, 60);
+	tool->hours   = xst_time_spin_button_create (tool, 24);
 	tool->map_hover_label = xst_dialog_get_widget (dialog, "location_label");
 

Can you send a new patch?

thanks,
Chema


_______________________________________________
setup-tool-hackers maillist  -  setup-tool-hackers@ximian.com
http://lists.ximian.com/mailman/listinfo/setup-tool-hackers