Re: [xml] win32 thread safety patch

[Igor Zlatkovic <igor stud fh-frankfurt de>]

Hello.

Serguei, sorry, my fault. I said my judgement was based on the first glance,
not the actual compilation. I take it back, all of it.

I haven't got the time to test it on a longer run, but it seems to work, at
least with the MS compiler.

Thanks,
Igor


----- Original Message -----
From: "Serguei Narojnyi" <serguein opencola com>
To: <xml gnome org>
Sent: Tuesday, January 08, 2002 3:14 PM
Subject: RE: [xml] win32 thread safety patch


> > Please wait for a day. Serguei, no offense meant, it seems to
> > me that the
> > patch is wrong. You have put #ifdef _MSC_VER instead of
> > #ifndef on at least
> > two places. This is a conclusion drawn from the first glance,
> > not from the
> > actual compile. I don't have Windows machine available at the
> > moment, I'll
> > check this later today.
>
> i've tested it, it's correct, all #ifdefs and #ifndefs as well as specific
> function calls are deliberate and correct (i think). can you please point
> out which ones you think are wrong so i can explain them to you?