[xslt] Work report/code review part 1



This is the first part in series of xslt@gnome posts that explains what
I've been doing.  Please post reguarding this message to the xslt@gnome mail 
list.

This part presents a summary of requested changes to libxml in
the order that they occur in libxml2-2.4.3_ki.diff. And has been created so
the the changes I recommend can be reviewed. Most of the changes are to
allow the reuse of code within debugXML.c. The attached file
libxml2-2.4.3_ki.diff is much smaller than version on sourceforge and as I
have removed all "noise" diff text about rebuildable files.

File: debugXML.c
Reason for change : allow public access to debugXML.c functions
Changes: make public functions named xmlLsCountNode, xmlLsOneNode

File: debugXML.c
Reason for change : simplify libxml usage (convenience and better reuse of
code)
Changes : Add new functions xmlBoolToText, xmlGetLineNo,
xmlShellPrintXpathError, xmlShellPrintNode, xmlShellPrintXPathResult

File: debugXML.c
Reason for change : allow public access to debugXML.c functions
Changes : make public functions named xmlShellList, xmlShellBase, xmlShellDir,
 xmlShellCat

File: debugXML.c (old line 1287, 1296) (new line 1450, 1459)
Reason change occured : difference in spaces used
Change : change to be rejected?

File: debugXML.c
Reason change occured : allow public access to debugXML.c functions
Changes : make public functions name xmlShellLoad, xmlShellWrite,
xmlShellSave, xmlShellValidate, xmlShellDu, xmlShellPwd

File: debugXML.c
Reason change occured : Allow xmlShellPwd to become name space aware
Changes : added local variable nametemp, modified snprintf to become namespace
aware

File: debugXML.h
Reason change occured : allow public access to debugXML.c functions
Changes : added declaration to xmlLsOneNode

File: debugXML.h
Reason change occured : simplify libxml usage (convenience and better reuse of
code)
Change : added new function declarations xmlBoolToText, xmlGetLineNo,
xmlShellPrintXPathError, xmlShellPrintNode, xmlShellPrintXPathResult

File: debugXML.h
Reason change occured : allow public access to debugXML.c functions
 Changes : added declaration to xmlShellList, xmlShellBase, xmlShellDir,
xmlShellCat, xmlShellLoad, xmlShellWrite, xmlShellSave, xmlShellValidate,
xmlShellDu, xmlShellPwd

File: debugXML.h (old line 104,109) (new line 326,335)
Reason change occured : difference in spaces used
Change : change to be rejected?


File: tree.c
Reason change occured : fix for segmentation fault when "xmlShellCat" on
attribute node
Change :detect attribute nodes and act accordingly

bye,

Keith 

attached: libxml2-2.4.3_ki.dif.gz 
compression used : gzip 

Diffs on libxml2-2.4.3



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]