Re: String additions to 'gnome-shell.master'



On Wed, Oct 5, 2011 at 2:58 AM, Claude Paroz <claude 2xlibre net> wrote:
> Le mercredi 05 octobre 2011 à 02:52 -0400, Jasper St. Pierre a écrit :
>> On Wed, Oct 5, 2011 at 2:49 AM, Claude Paroz <claude 2xlibre net> wrote:
>> > Le mardi 04 octobre 2011 à 22:55 +0200, Piotr Drąg a écrit :
>> >> 2011/10/4 GNOME Status Pages <noreply gnome org>:
>> >> > There have been following string additions to module 'gnome-shell.master':
>> >> >
>> >> > + "tray"
>> >> >
>> >>
>> >> It's already existing string, so it's not a string freeze break, but
>> >> could you explain what this 'tray' actually mean? I've found it's a
>> >> button in on-screen keyboard, but I couldn't figure out what does it
>> >> do.
>> >
>> > No, this string did not exist previously in gnome-shell. This is a real
>> > string freeze break, so please revert, branch or formally ask for an
>> > exception.
>> > Thanks!
>> >
>> > Claude
>> >
>>
>> This is the commit that "added the string". It's been there before, I
>> just added the _(). From what I've been told, xgettext will extract
>> the string without it (which is why we use '' for untranslated
>> strings). I could be wrong, though.
>>
>> http://git.gnome.org/browse/gnome-shell/commit/?id=4e114107ed3ddf71c784cb63ca592ee88911d2a4
>>
>
> Oh sorry, I misunderstood Piotr message. Of course, this is in the
> category "String previously not marked for translation", so it is valid.
>
> But I'm not sure I understand what you said: "xgettext will extract the
> string without it". That should be "xgettext will *not* extract the
> string without it", shouldn't it?
>
> Claude

I have been told that a string like "FooBar" will be extracted, but a
string like 'FooBar' won't, due to how xgettext and JS work. From the
bug as well:

"This doesn't add a string but mark an existing string as
translatable, this is not subject to string freeze."

https://bugzilla.gnome.org/show_bug.cgi?id=660600

-- 
  Jasper


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]