Re: Compose window From: field

[Pawel Salek <pawsa theochem kth se>]

On 14 Feb, micah craig wrote:
> I've been wondering what the reasoning is behind making the From: 
> field in the compose window un-editable.  Is there a technical 
> reason, or is it a policy decion?

Well, I believe there is no technical(?) or policy reason to make this
field not editable. Patching it is as simple as enclosed solution.

There is only one "but": the sending procedure doesn't use this field,
it seems it never used it, the procedure always reffered to the
identity information set in preferences. This would take a little bit
more time to fix - I am not yet familiar with message->from->personal
allocation methods and I don't want to submit a quick, memory leaking
hack.

Pawel

Index: src/sendmsg-window.c
===================================================================
RCS file: /cvs/gnome/balsa/src/sendmsg-window.c,v
retrieving revision 1.156
diff -u -r1.156 sendmsg-window.c
--- src/sendmsg-window.c	2000/02/15 03:08:37	1.156
+++ src/sendmsg-window.c	2000/02/15 08:19:52
@@ -468,8 +468,6 @@
   msg->from[1] = gtk_entry_new ();
   gtk_table_attach (GTK_TABLE (table), msg->from[1], 1, 2, 1, 2,
 		    GTK_FILL | GTK_EXPAND, GTK_FILL | GTK_SHRINK, 0, 0);
-  GTK_WIDGET_UNSET_FLAGS (msg->from[1], GTK_CAN_FOCUS);
-  gtk_entry_set_editable (GTK_ENTRY (msg->from[1]), FALSE);
 
   msg->from[2] = gtk_button_new ();
   gtk_button_set_relief (GTK_BUTTON (msg->from[2]), GTK_RELIEF_NONE);