Re: GnomeCard, AddressBook fixes.
- From: Ali Akcaagac <ali akcaagac stud fh-wilhelmshaven de>
- To: Pawel Salek <pawsa TheoChem kth se>
- Cc: Ali Akcaagac <ali akcaagac stud fh-wilhelmshaven de>,balsa-list gnome org
- Subject: Re: GnomeCard, AddressBook fixes.
- Date: Wed, 15 Aug 2001 12:55:02 +0200
On 2001.08.15 12:27:53 +0200 Pawel Salek wrote:
>
> On 2001-08-15 12:15 Ali Akcaagac wrote:
> > during my exercise through the balsa code, i've detected
> > something strange that should really get fixed as soon
> > as possible so here the patch.
>
> The patch looks OK, I have just one comment on style: calling strlen()
> to check is string is empty is a bad habit, str[0] == '\0' is a much
> fastest test, particularly for non-empty strings (I know it does not
> matter much in this particular case, but good style is a good style).
>
> I am looking forward to other comments (if there are none I will commit
> this patch after some further testing).
of course, please feel free to adjust it as needed. i was working
the whole night on this :) and thanks for reply.
--
Name....: Ali Akcaagac
Status..: Student Of Computer & Economic Science
E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]