Re: Balsa command line attachement patch



On 2001-06-29 00:57 W. Michael Petullo wrote:
> I recently downloaded Balsa 1.1.6 and was a little disappointed that a
> patch I have submitted was not included.

(I can only apologise but I have had really hard time recently and could
not follow balsa-list as closely as I wish I could; it is useful to add
[PATCH] to mails containing patches, they are easier to find; one can
also file a patch in bugzilla marking it as bug fix or enhancement
depending on its nature).

> 
> I would like to resubmit the patch to you which allows one to specify
> an
> attachment on the command line, in addition to a recipient.  My patch
> adds a -a or --attach option which takes paths as an argument.
> 
> ``balsa -a /foo/bar'' and ``balsa --attach=/foo/bar,/foo/baz'' are two
> examples of my patch's use.

The patch is OK apart from the choice of the separator character: comma
is a legal character in Unix file name and is used to mark version of
the file (CVS, RCS). I think ';' would be better. Even better solution
would be to allow multiple '-a' options, I believe it is possible with
the popt library. Would you mind having look at it? I would truly
appreciate it (and all the balsa users as well, I guess).

/Pawel




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]