UI issues



Sorry to interrupt the libESMTP discussion, but...

I noticed a couple of weeks ago that page-up/page-down only move about
1/2 a screen when reading mail.  I'm not a bit mouse user and point
and click interfaces, scrollbars, etc. are a bit uncomfortable for me
to use on a regular basis.  In looking this over, it appears that the
GTK viewport widget has a hardcoded page increment of half the window
size and no nice way to change this.  The code and documentation
indicates that the app is free to stuff new values into the adjustment
structure, but I couldn't get that to work right.  Rather than muck with
GTK stuff, i decided that it was far easier to just use a different
value for the scroll increment when calling scroll_change().

Here is a quick patch that changes the PU/PD to scroll the window 90%.
It may be nicer to make it a preference option that the user can control
but I haven't had the time to figure out how that code works yet.

I have noticed that when typing an address in the compose window that 
the text jumps back and forth in the textbox on nearly every character
typed.  Does anyone else see this?

And finally, how can I select or override the mime-type of an attachment?
For example, I wanted to attach the patch as balsa-message-scroll.pf but
when I did that it got marked as application/octet-stream instead of
text/plain.  Renaming the file to something ending in '.txt' did change
the mime-type to text/plain.  Effective but not very flexible.
-- 
Lynn Kerby <mailto:lfk@kerbit.net>
Index: balsa/src/balsa-message.c
===================================================================
RCS file: /cvs/gnome/balsa/src/balsa-message.c,v
retrieving revision 1.161
diff -w -u -r1.161 balsa-message.c
--- balsa/src/balsa-message.c	2001/03/30 10:18:27	1.161
+++ balsa/src/balsa-message.c	2001/04/21 01:07:32
@@ -1705,11 +1705,11 @@
 	break;
     case GDK_Page_Up:
 	scroll_change(viewport->vadjustment,
-		      -viewport->vadjustment->page_increment);
+		      -viewport->vadjustment->page_size * 9 / 10);
 	break;
     case GDK_Page_Down:
 	scroll_change(viewport->vadjustment,
-		      viewport->vadjustment->page_increment);
+		      viewport->vadjustment->page_size * 9 / 10);
 	break;
     case GDK_Home:
 	if (event->state & GDK_CONTROL_MASK)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]