Re: PATCH: balsa exit code cleanup

[Albrecht Dreß <albrecht dress arcormail de>]

Am 05.09.2001 15:23:07 schrieb(en) Pawel Salek:
> I would like to commit the attached patch that cleans up balsa exit
> code. Basically, so far balsa used very rough&hard combination of
> destroy&quit calls. The proposed patch replaces it with a softer
> approach using "delete-event" signals that give a chance to save
> composed messages etc.

Wow, *this* is really an improvement!!! BTW, maybe its also possible to catch
system signals in the case that balsa (or something else, like the window
manager) crashes, so that unfinished messages can be saved? It is not
necessary to save them in the draftbox, a file in the user's home wold help to
avoid losses...

> I would appreciate if somebody else would test the patch a little:
> quit balsa, quit balsa with several compose windows open, quit using
> different ways etc.

O.k., here are my remarks (I still use yesterday's cvs, but I will upgrade
soon...)

* The compilation bombed in src/main-window.c (this is related to your patch
only by adding Werror to gcc's flags) due to a duplicate define. This patch
fixes that, but I think this issue needs more attention:

--- src/main-window.c.orig      Wed Sep  5 18:25:53 2001
+++ src/main-window.c   Wed Sep  5 18:28:28 2001
@@ -308,7 +308,7 @@
       message_print_cb, NULL, NULL, GNOME_APP_PIXMAP_STOCK, 
       GNOME_STOCK_MENU_PRINT, 'P', GDK_CONTROL_MASK, NULL},
     GNOMEUIINFO_SEPARATOR,
-#define MENU_FILE_PRINT_POS 8
+#define MENU_FILE_ADDRESS_BOOK_POS 8
     {
      GNOME_APP_UI_ITEM, N_("_Address Book..."),
      N_("Open the address book"),


* If I open a message window, don't change anything at all, and select
File->Close or press the WM's close button, I still get the dialog if I want
to save the message or not.


* File->Close doesn't work if I did not enter a recipient (or anything at
all), but the WM's close button still works. So the only way of destroying a
compose window I don't want (e.g. opend by error) is by using the WM's close
button.


* A new message without a recipient set is not saved even if I typed something
*and* said "yes" in the save dialog (I sometimes type a message and set the
list of recipients later).


* Upon exit, I get loads of warning messages, like (shortened):
Gtk-WARNING **: invalid class type `(unknown)' in cast to `GtkToolbar'
Gtk-WARNING **: invalid class type `(unknown)' in cast to `GtkContainer'
Gtk-CRITICAL **: file gtkcontainer.c: line 1119 (gtk_container_foreach):
assertion `GTK_IS_CONTAINER (container)' failed.
Gtk-WARNING **: gtk_signal_handler_block_by_func(): could not find handler
(0x100421E0) containing data (0x10140E18)
Gtk-WARNING **: gtk_signal_handler_unblock_by_func(): could not find blocked
handler (0x100421E0) containing data (0x10140E18)
Gtk-WARNING **: invalid class type `(unknown)' in cast to `GtkCTree'
This seems to be related to killed messages without recipient. However, I
always get the last warning (invalid cast to GtkCTree).


But, again, I think it's a great improvement, **Please continue with that
work!**

Cheers, Albrecht.


P.S.: I almost finished a really big patch to get postpone/continue as well as
forwarding as attachment working as expected. Do you think this should go into
1.2, or better wait for 1.3?


-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Albrecht Dreß  -  Monschauer Straße 22  -  D-53121 Bonn (Germany)
      Phone (+49) 228 6199571  -  mailto:albrecht.dress@arcormail.de
_________________________________________________________________________