Re: TEST : Peter's Patch

[Carlos Morgado <chbm chbm nu>]

On 2002.01.30 09:16:11 +0000 Emmanuel wrote:
> 	Hi all,
> I've shortly tested a patch from Peter. In 2 words : It's great! It just 
> rips a lot of duplicated code from gtk+ out of the address-entry sources 
> without trouble (at least I have seen nothing). I only noticed that the 
> expansion is no more highlighted, but I don't think this is an issue.

there must be a visual clue of the expansion i think

> Moreover this will be far easier to port to gtk+-2.0 now. So I think this 
> patch should be considered for more testing and then inclusion in CVS/1.2.4 
> (the patch applies on vanilla 1.2.4).

certainly not 1.2.4 :) that's done and closed business :)

> Moreover there are quite a lot of clean-ups for the remaining code (that 
> has drastically been reduced by the patch : about 20Ko of sources and 15Ko 
> of object file!), that should cure several mem leaks, overkill algo...
> I'll wait to see what happens to Peter's patch before releasing a clean-up 
> patch.

lets have it then :)

-- 
Carlos Morgado - chbm(at)chbm(dot)nu - http://chbm.nu/ -- gpgkey: 0x1FC57F0A
http://wwwkeys.pgp.net/ FP:0A27 35D3 C448 3641 0573 6876 2A37 4BB2 1FC5 7F0A
Software is like sex; it's better when it's free. - Linus Torvalds