[PATCH] Re: Iconwidth

[Peter Bloomfield <PeterBloomfield MindSpring com>]

On 2002.07.15 09:28 Simon Brown wrote:
>> For reasons I don't recall, they're GTK_ICON_SIZE_BUTTON. Could you 
>> try GTK_ICON_SIZE_SMALL_TOOLBAR, or GTK_ICON_SIZE_LARGE_TOOLBAR, and 
>> let us know which size works best?
> 
> I replaced all instances of GTK_ICON_SIZE_BUTTON with 
> GTK_ICON_SIZE_LARGE_TOOLBAR as it seemed most appropriate. The 
> results are great, the icons are now slightly larger and much better 
> definition. In true naff tv show style I've put up before and after 
> pictures.
> 
> http://usitweb.shef.ac.uk/~simon/before.png
> http://usitweb.shef.ac.uk/~simon/after.png

Great! That's a real improvement.

> I don't see the point in testing the other sizes as I don't think it 
> will improve. I would attach a patch but I don't know how :-)

OK--I've attached one, made with

$ cvs -z3 diff src/toolbar*.c > ../toolbar.balsa2-patch

> I'm also not sure it's the best solution, as the two address book 
> books on the compose window are now much larger. Still pretty though 
> :-)

Well...your original comment was about the toolbar icons, so those are 
the only ones that this patch changes. The other places where images 
are sized as GTK_ICON_SIZE_BUTTON really are for buttons, so that may 
be the more appropriate size.

Peter
Index: src/toolbar-factory.c
===================================================================
RCS file: /cvs/gnome/balsa/src/toolbar-factory.c,v
retrieving revision 1.17.2.3
diff -u -r1.17.2.3 toolbar-factory.c
--- src/toolbar-factory.c	27 Apr 2002 11:45:00 -0000	1.17.2.3
+++ src/toolbar-factory.c	15 Jul 2002 14:37:48 -0000
@@ -579,7 +579,7 @@
 			window, toolbar_buttons[button].pixmap_id),
 #else
                     gtk_image_new_from_stock(toolbar_buttons[button].pixmap_id,
-                                             GTK_ICON_SIZE_BUTTON),
+                                             GTK_ICON_SIZE_LARGE_TOOLBAR),
 #endif                          /* BALSA_MAJOR < 2 */
 		    GTK_SIGNAL_FUNC(tmpdata[i].callback),
 		    tmpdata[i].data != NULL ? tmpdata[i].data : window);
Index: src/toolbar-prefs.c
===================================================================
RCS file: /cvs/gnome/balsa/src/toolbar-prefs.c,v
retrieving revision 1.18.2.4
diff -u -r1.18.2.4 toolbar-prefs.c
--- src/toolbar-prefs.c	15 Apr 2002 22:02:20 -0000	1.18.2.4
+++ src/toolbar-prefs.c	15 Jul 2002 14:37:48 -0000
@@ -301,7 +301,7 @@
 					  toolbar_buttons[index].pixmap_id),
 #else
                 gtk_image_new_from_stock(toolbar_buttons[index].pixmap_id,
-                                         GTK_ICON_SIZE_BUTTON),
+                                         GTK_ICON_SIZE_LARGE_TOOLBAR),
 #endif                          /* BALSA_MAJOR < 2 */
 		NULL,
 		NULL);
@@ -894,7 +894,7 @@
 #else
     GdkPixbuf *pixbuf =
         gtk_widget_render_icon(GTK_WIDGET(clist), stock_id,
-                               GTK_ICON_SIZE_BUTTON, "Balsa");
+                               GTK_ICON_SIZE_LARGE_TOOLBAR, "Balsa");
 
     gdk_pixbuf_render_pixmap_and_mask(pixbuf, &pixmap, &mask, 1);
     gdk_pixbuf_unref(pixbuf);