Re: howto compile balsa?

[Peter Bloomfield <PeterBloomfield bellsouth net>]

On 01/20/2004 01:49:31 AM, Kacper Wysocki wrote:
[ snip ]
> balsa-2.0.16 gives:
> [...]
> g-prototypes -Wreturn-type -c address-entry.c
> In file included from message.h:31,
>                 from libbalsa.h:38,
>                 from address-entry.c:41:
> rfc3156.h:53: error: parse error before "gpgme_error_t"
> rfc3156.h:53: warning: no semicolon at end of struct or union
> rfc3156.h:54: warning: data definition has no type or storage  
> class
> rfc3156.h:55: error: parse error before "trust"
> rfc3156.h:55: warning: data definition has no type or storage  
> class
> rfc3156.h:61: error: parse error before '}' token

Aside from possible interactions between gpgme versions, having  
this error pop up when compiling address-entry.c is weird!  I've  
seen some quite obscure consequences of the spaghetti-bowl  
includes in libbalsa.  The includes can apparently be pared down  
as in the attached patch.

HTH,

Peter
Index: libbalsa/address-entry.c
===================================================================
RCS file: /cvs/gnome/balsa/libbalsa/address-entry.c,v
retrieving revision 1.32.2.2
diff -u -r1.32.2.2 address-entry.c
--- libbalsa/address-entry.c	20 Sep 2003 09:02:53 -0000	1.32.2.2
+++ libbalsa/address-entry.c	20 Jan 2004 20:01:57 -0000
@@ -27,18 +27,11 @@
 #include "config.h"
 
 #include <gnome.h>
-#include <gdk/gdkkeysyms.h>
-#include <gdk/gdki18n.h>
-
-#include <stdio.h>
-#include <sys/stat.h>
-#include <ctype.h>
 #include <string.h>
 
 /*
  * LibBalsa includes.
  */
-#include "libbalsa.h"
 #include "address-entry.h"
 
 
Index: libbalsa/address-entry.h
===================================================================
RCS file: /cvs/gnome/balsa/libbalsa/address-entry.h,v
retrieving revision 1.10.2.1
diff -u -r1.10.2.1 address-entry.h
--- libbalsa/address-entry.h	19 Sep 2003 19:15:23 -0000	1.10.2.1
+++ libbalsa/address-entry.h	20 Jan 2004 20:01:57 -0000
@@ -20,10 +20,11 @@
  * 02111-1307, USA.
  */
 
-
 #ifndef __LIBBALSA_ADDRESS_ENTRY_H__
 #define __LIBBALSA_ADDRESS_ENTRY_H__
 
+#include "address.h"
+
 #define FOCUS_LOST 0
 #define FOCUS_TAINTED 1
 #define FOCUS_CACHED 2