Re: [PATCH] Attachments in mailto: URLs
- From: Peter Bloomfield <peterbloomfield bellsouth net>
- To: balsa-list gnome org
- Subject: Re: [PATCH] Attachments in mailto: URLs
- Date: Wed, 01 Nov 2006 08:51:04 -0500
On 11/01/2006 08:33:30 AM Wed, Blackwell, Steve @ GSI wrote:
Seems to me that a memory leak has been introduced here. If
add_attachment()
is called, then g_free(val) is not but "val = decode_and_strdup(ptr,'&',
&ptr);" is called every time.
Steve
Hi Steve:
That's because add_attachment() steals the string. The version in cvs
moves the test to sendmsg_window_set_field(), so key is always freed in
sendmsg_window_process_url(), but a new copy is passed to add_attachment()
in sendmsg_window_set_field().
Peter
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]