Re: SVN searlier than 7994: error while lauching a link from a mail

[Peter Bloomfield <peterbloomfield bellsouth net>]

Hi Jean-Luc:

On 12/07/2008 06:28:38 AM Sun, Jean-Luc Coulon (f5ibh) wrote:
> Hi,
>
> The problem us still living with SVN 8014.
> The url is correctly displayed in the status bar, as well as in the
> popup error windows.
>
> Regards
>
> Jean-Luc

One recent change was migrating from gnome_url_show to gtk_show_uri, when  
Gtk version is at least 2.14.  Perhaps that's the source of the  
proglem--the attached patch is a hack to revert to gnome_url_show--could  
you check it?

Thanks!

Peter

Index: src/balsa-mime-widget-message.c
===================================================================
--- src/balsa-mime-widget-message.c	(revision 8014)
+++ src/balsa-mime-widget-message.c	(working copy)
@@ -22,7 +22,7 @@
 #include <string.h>
 #include <gtk/gtk.h>
 
-#if !GTK_CHECK_VERSION(2, 14, 0)
+#if 1 /* !GTK_CHECK_VERSION(2, 14, 0) */
 #include <libgnome/gnome-url.h>
 #endif
 
@@ -292,7 +292,7 @@
     GError *err = NULL;
 
     g_return_if_fail(url);
-#if GTK_CHECK_VERSION(2, 14, 0)
+#if 0 /* GTK_CHECK_VERSION(2, 14, 0) */
     gtk_show_uri(NULL, url, gtk_get_current_event_time(), &err);
 #else
     gnome_url_show(url, &err);
Index: src/main-window.c
===================================================================
--- src/main-window.c	(revision 8014)
+++ src/main-window.c	(working copy)
@@ -2552,7 +2552,7 @@
 {
     GError *err = NULL;
 
-#if GTK_CHECK_VERSION(2, 14, 0)
+#if 0 /* GTK_CHECK_VERSION(2, 14, 0) */
     gtk_show_uri(NULL, link, gtk_get_current_event_time(), &err);
 #else                           /* GTK_CHECK_VERSION(2, 14, 0) */
     gnome_url_show(link, &err);
Index: src/sendmsg-window.c
===================================================================
--- src/sendmsg-window.c	(revision 8014)
+++ src/sendmsg-window.c	(working copy)
@@ -1809,7 +1809,7 @@
     g_return_if_fail(uri != NULL);
 
     g_message("open URL %s", uri);
-#if GTK_CHECK_VERSION(2, 14, 0)
+#if 0 /* GTK_CHECK_VERSION(2, 14, 0) */
     gtk_show_uri(NULL, uri, gtk_get_current_event_time(), &err);
 #else
     gnome_url_show(uri, &err);
Index: src/balsa-mime-widget-text.c
===================================================================
--- src/balsa-mime-widget-text.c	(revision 8014)
+++ src/balsa-mime-widget-text.c	(working copy)
@@ -33,7 +33,7 @@
 #include "balsa-mime-widget-text.h"
 #include "balsa-cite-bar.h"
 
-#if !GTK_CHECK_VERSION(2, 14, 0)
+#if 1 /* !GTK_CHECK_VERSION(2, 14, 0) */
 #include <libgnome/gnome-url.h>
 #endif
 
@@ -928,7 +928,7 @@
         gtk_statusbar_push(statusbar, context_id, notice);
         SCHEDULE_BAR_REFRESH();
         g_free(notice);
-#if GTK_CHECK_VERSION(2, 14, 0)
+#if 0 /* GTK_CHECK_VERSION(2, 14, 0) */
         gtk_show_uri(NULL, url->url, gtk_get_current_event_time(), &err);
 #else
     gnome_url_show(url->url, &err);
@@ -1203,7 +1203,7 @@
 {
     GError *err = NULL;
 
-#if GTK_CHECK_VERSION(2, 14, 0)
+#if 0 /* GTK_CHECK_VERSION(2, 14, 0) */
     gtk_show_uri(NULL, url, gtk_get_current_event_time(), &err);
 #else
     gnome_url_show(url, &err);

Attachment: pgpKCBIg6qgbw.pgp
Description: PGP signature