Hi Mario: On 09/10/2008 04:27:15 AM Wed, Mario Mikocevic wrote:
Hi, On 09/10/2008 08:43:13 AM, Pawel Salek wrote:We will have to track the button icon problem down but let's first debug the mailbox crash...Caught it ->
That's really helpful! I still haven't reproduced the problem. If you still see it, could you try the attached patch? Balsa may report an error, and you may get some console messages, but it shouldn't crash.
Thanks! Peter
Index: libbalsa/mailbox_mbox.c
===================================================================
--- libbalsa/mailbox_mbox.c (revision 7967)
+++ libbalsa/mailbox_mbox.c (working copy)
@@ -548,6 +548,7 @@
(gpointer) & msg_info->local_info.message);
msg_info->local_info.message = NULL;
}
+ g_free(msg_info);
}
static void
@@ -559,7 +560,6 @@
struct message_info *msg_info =
g_ptr_array_index(msgno_2_msg_info, i);
free_message_info(msg_info);
- g_free(msg_info);
}
g_ptr_array_free(msgno_2_msg_info, TRUE);
}
@@ -1025,6 +1025,7 @@
* the first new message--start parsing here. */
break;
+g_print("%s backing up over message %d\n", __func__, msgno);
/* Back up over this message and try again. */
msg_info = message_info_from_msgno(mbox, msgno);
start = msg_info->start;
Index: libbalsa/body.c
===================================================================
--- libbalsa/body.c (revision 7967)
+++ libbalsa/body.c (working copy)
@@ -476,6 +476,7 @@
default:
break;
}
+#if 0
} else if (body->mime_part) {
/* Not a GMimePart... */
GMimeObject *object = body->mime_part;
@@ -489,6 +490,7 @@
g_mime_object_write_to_stream(object, stream);
libbalsa_mailbox_unlock_store(body->message->mailbox);
g_object_unref(object);
+#endif
} else {
g_set_error(err, LIBBALSA_MAILBOX_ERROR, LIBBALSA_MAILBOX_ACCESS_ERROR,
"Internal error in get_stream");
Attachment:
pgp9MjfjSXkL5.pgp
Description: PGP signature