Re: crash in settings in svn version



On 10/19/2009 07:57:29 PM Mon, Jack wrote:
On 2009.10.19 19:39, Peter Bloomfield wrote:
On 09/30/2009 08:17:01 AM Wed, Jean-Luc Coulon (f5ibh) wrote:
100% reproductble:

Settings -> Toolbars -> Toolbar style

crash

...so the crash occurs when the default toolbar style is "Text Beside Icons"...which reminds me, we set the text beside *all* icons. Some apps advertise "Priority Text Beside Icons", but Balsa has never identified "Priority" text, and as a result this option is pretty much unusable--the toolbar becomes over-wide. It's not too hard to implement--question is, which buttons should show their text, and which are unambiguous without it? The "print" and "exit" buttons are clear, and "spell-check" is universal, but which others could we safely leave unlabeled?

Trash is pretty universal. I think Reply, ReplyAll, and Forward are also, but I just noticed "Next Unread" is also an envelope with an arrow, so maybe only a half vote here.

OK, so here's a (perhaps aggressive) proposal:

No text:

    {GTK_STOCK_QUIT, N_("Quit"), FALSE},
    {BALSA_PIXMAP_RECEIVE, N_("Check"), FALSE},
    {BALSA_PIXMAP_COMPOSE, N_("Compose"), FALSE},
    {BALSA_PIXMAP_REPLY, N_("Reply"), FALSE},
    {BALSA_PIXMAP_REPLY_ALL, N_("Reply\nto all"), FALSE},
    {BALSA_PIXMAP_NEXT_UNREAD, N_("Next\nunread"), FALSE},
    {GTK_STOCK_DELETE, N_("Trash /\nDelete"), FALSE},
    {GTK_STOCK_PRINT, N_("Print"), FALSE},
    {BALSA_PIXMAP_ATTACHMENT, N_("Attach"), FALSE},
    {GTK_STOCK_SAVE, N_("Save"), FALSE},
    {BALSA_PIXMAP_IDENTITY, N_("Identity"), FALSE},
    {GTK_STOCK_SPELL_CHECK, N_("Spelling"), FALSE},
    {GTK_STOCK_CLOSE, N_("Close"), FALSE},
    {GTK_STOCK_UNDO, N_("Undo"), FALSE},
    {GTK_STOCK_REDO, N_("Redo"), FALSE},
    {GTK_STOCK_EDIT, N_("Edit"), FALSE},

With text:

    {BALSA_PIXMAP_CONTINUE, N_("Continue"), TRUE},
    {BALSA_PIXMAP_REPLY_GROUP, N_("Reply\nto group"), TRUE},
    {BALSA_PIXMAP_FORWARD, N_("Forward"), TRUE},
    {BALSA_PIXMAP_PREVIOUS, N_("Previous"), TRUE},
    {BALSA_PIXMAP_NEXT, N_("Next"), TRUE},
    {BALSA_PIXMAP_NEXT_FLAGGED, N_("Next\nflagged"), TRUE},
    {BALSA_PIXMAP_PREVIOUS_PART, N_("Previous\npart"), TRUE},
    {BALSA_PIXMAP_NEXT_PART, N_("Next\npart"), TRUE},
    {BALSA_PIXMAP_POSTPONE, N_("Postpone"), TRUE},
    {BALSA_PIXMAP_REQUEST_MDN, N_("Request\nMDN"), TRUE},
    {BALSA_PIXMAP_SEND, N_("Send"), TRUE},
    {BALSA_PIXMAP_SEND_RECEIVE, N_("Exchange"), TRUE},
    {BALSA_PIXMAP_MARKED_NEW, N_("Toggle\nnew"), TRUE},
    {BALSA_PIXMAP_MARK_ALL, N_("Mark all"), TRUE},
    {BALSA_PIXMAP_SHOW_HEADERS, N_("All\nheaders"), TRUE},
    {GTK_STOCK_CANCEL, N_("Reset\nFilter"), TRUE},
    {BALSA_PIXMAP_SHOW_PREVIEW, N_("Msg Preview"), TRUE},
#ifdef HAVE_GPGME
    {BALSA_PIXMAP_GPG_SIGN, N_("Sign"), TRUE},
    {BALSA_PIXMAP_GPG_ENCRYPT, N_("Encrypt"), TRUE},
#endif
    {GTK_STOCK_CLEAR, N_("Expunge"), TRUE},
    {GTK_STOCK_REMOVE, N_("Empty\nTrash"), TRUE},

Comments?

Peter

Attachment: pgpRHh8KOs5Zm.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]