Re: Debuggin by environment variable instead of compile time. Was: GIT version - no display of html messages



On 07/07/2018 04:42 PM, Peter Bloomfield wrote:
On 07/07/2018 03:43:15 PM Sat, Albrecht Dreß wrote:
Am 07.07.18 21:01 schrieb(en) Albrecht Dreß:
Am 07.07.18 20:49 schrieb(en) Peter Bloomfield:
Albrecht has been making that change in various places, using g_debug() instead of various printing calls. I've just done the same in the HTML code, so you can run Balsa with:

G_MESSAGES_DEBUG=html src/balsa

Ooops, looks as if we had the same idea at the same time…

…and attached is a new patch for libbalsa/html.c, on top of your changes, fixing the HTML rendering issue.  Also defines the html log domain only if we have html rendering.

Thanks for the rapid response patch! I tested with webkit2gtk3-2.20.3 and it still works fine. Pushed to master.

It would be cool if you could add the changes to README (from the 1st one), so we have it documented.

Done!

Peter
Will we release a 2.5.7, or should I test if this latest commit will apply cleanly to 2.5.6?  I guess 2.5.6 is fine for anyone with a newer webkit-gtk, but not anyone using an older version, so it depends on distro, but any distro with an older webkit-gtk will have no HTML in balsa.

Also - thanks to Helmut for actually being the first to point out this problem.

Jack


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]