Hi Albrecht: On 11/04/2018 05:40:42 AM Sun, Albrecht Dreß wrote:
Hi all, attached is a patch for cleaning up improving Balsa's password ui. (1) If available, use the GCR password dialogue. (2) Implement asking the user for a user certificates passphrase if required, using the same dialogue as the password dialogue. (3) Clean up the LibBalsaServer signals (see [1]). Regarding the "get-password" signal, the additional LibBalsaMailbox argument which was never used properly (passing the mailbox to config_mailbox_init() in src/save-restore.c, l. 422, sets the /third/ user_data argument of the callback which is never evaluated) is replaced by a string which is either empty for reading the user password, or contains the user certificate's subject for the passphrase of the latter. (4) Simplify the user certificate passphrase callback from libnetclient by passing the certificate subject instead of the certificate binary data. (5) Reading the password can be simplified due to the omitted (useless) LibBalsaMailbox argument.
Thanks again for the work! Patch applies, builds, and runs--I'm dog-fooding it now.
Please note that the patch goes on top of the following pending patches: * the “unified server configuration GUI” patch I submitted October 21st, * Peter's fixes for building with LDAP support for this patch and * the “Fix broken IMAP Kerberos authentication” patch I submitted October 23rd.
I just pushed all those as a single "Unified server configuration GUI", so this latest patch should apply cleanly to an updated git tree. Best, Peter
Attachment:
pgpB1YJiJ7Wgj.pgp
Description: PGP signature