On Tue, 2008-07-29 at 13:48 -0500, Gabriel Burt wrote: <modesty force me to remove this> > > As the previous one, these are patches that I think deserve some > > attention. It's completely subjective, and so, totally biased. > > This is totally fair/fine, but let's change the process slightly. For > the next one, can you solicit input on #banshee for a day or two > before sending? I think Andrew Conkling has some input... :) Andrew, > do you use IRC? Do you mean I have to be organised and all ? ;) OK I'll try to do this. > > 541828 - Karma DAP support is not in 1.0 > > http://bugzilla.gnome.org/show_bug.cgi?id=541828 > > Adds support for Rio Karma back to banshee. > > Needs testing > > Do you have a Rio device? I don't, so I can't test. Let's keep this > patch review e-mail more focused on patches that need maintainer > review and/or are ready to commit (by your or other contributors' > judgement). Also, might be helpful to mention who wrote or reviewed > the patch, if it's somebody who is a regular contributor. I don't have a Rio, so I was trying to get some feedback on the patch. As suggested above, I'll try to get this kind of feedback before sending the e-mail. Adding author is a good idea, will do. > Thanks for your work, I think we're churning through patches far > faster than usual! The number of unreviewed patches is indeed decreasing, but let's get on top of this report : http://bugzilla.gnome.org/reports/patch-diligence-report.cgi Banshee (or somebody banshee-related) is in all the other good reports, so we can do this ! ;) -- Bertrand Lorentz <bertrand lorentz gmail com> > http://flickr.com/photos/bl8/ <
Attachment:
signature.asc
Description: This is a digitally signed message part