Re: [Banshee-List] [Patch] Podcast Transfer Destination

[David Spreen <netzwurm debian org>]

I should have mentioned that this is a patch against current svn.

Best,

David 

David Spreen <netzwurm debian org> writes:

> Hello,
>
> first of all apologies for including a patch. My ISP has been banned
> from bugs.gnome.org (which isn't really understandable to me as it is a
> reputable local provider here in California). I sent the required email
> 2 weeks ago and have yet to receive a response.
>
> So maybe somebody could open a bug (or find a relevant one) and attach
> the following patch.
>
> At least since 1.4, podcasts are not transferred to Musicdir/Podcasts
> when copied to mass-storage devices anymore. Since we can't rely on the
> genre to be set correctly, there is no way to tell podcasts apart from
> music files. The following patch makes sure, podcasts are (as in the
> music collection) copied to Musicdir/Podcasts/Album/Track. 
>
> This is probably not the cleanest solution but it works here. Let me
> know what folks think.
>
> Anybody please commit this to bugs.gnome.org. In the past couple of
> weeks I have used onion routing to access the bug tracker but it's super
> slow and a pain in the butt.
>
> Best Wishes,
>
> David Spreen
>
>
> Index: src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs
> ===================================================================
> --- src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs	(revision 4849)
> +++ src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs	(working copy)
> @@ -541,7 +541,13 @@
>          private string GetTrackPath (TrackInfo track, string ext)
>          {
>              string file_path = null;
> -            if (ms_device == null || !ms_device.GetTrackPath (track, out file_path)) {
> +            
> +            if (track.HasAttribute (TrackMediaAttributes.Podcast)) {
> +                string album = FileNamePattern.Escape (track.AlbumTitle);
> +                string title = FileNamePattern.Escape (track.TrackTitle);
> +                file_path = System.IO.Path.Combine ("Podcasts", album);
> +                file_path = System.IO.Path.Combine (file_path, title);
> +            } else if (ms_device == null || !ms_device.GetTrackPath (track, out file_path)) {
>                  file_path = FileNamePattern.CreateFromTrackInfo (track);
>              }
>  
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 4849)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,8 @@
> +2008-11-20  David Spreen  <netzwurm debian org>
> +	* src/Dap/Banshee.Dap.MassStorage/MassStorageSource.cs:
> +	Patch from David Spreen making sure Podcasts are copied to Podcasts/Album 
> +	on mass-storage devices. Otherwise they are indistinguishable from Music.
> +
>  2008-11-18  Gabriel Burt  <gabriel burt gmail com>
>  
>  	* src/Libraries/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Interaction.cs:
>
> _______________________________________________
> banshee-list mailing list
> banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list